Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upTrace_macros!() is not effectively gated #31753
Comments
This comment has been minimized.
This comment has been minimized.
|
Compilation doesn't complete, so is it really a stability hazard? |
huonw
added
I-nominated
T-compiler
labels
Feb 19, 2016
This comment has been minimized.
This comment has been minimized.
|
I'd say that gate is pretty effective, but the compilation is indeed not effect-free ... ha ha ha... |
This comment has been minimized.
This comment has been minimized.
|
Discussed in @rust-lang/compiler triage mtg. Since compilation doesn't succeed, it's not really possible to publish crates that rely on this. If we take it away, some people could get upset, but it won't cause widescale breakage (and people can always get upset when you take something away, feature-gate or no). Therefore, P-low. triage: P-low |
rust-highfive
added
P-low
and removed
I-nominated
labels
Feb 25, 2016
Mark-Simulacrum
added
A-stability
C-bug
labels
Jul 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
bluss commentedFeb 18, 2016
Since the trace_macros feature has effect before compilation stops, it's not really effectively gated.
output: