Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trace_macros!() is not effectively gated #31753

Open
bluss opened this Issue Feb 18, 2016 · 3 comments

Comments

Projects
None yet
7 participants
@bluss
Copy link
Contributor

bluss commented Feb 18, 2016

Since the trace_macros feature has effect before compilation stops, it's not really effectively gated.

#![feature(trace_macros)]
trace_macros!(true);

fn main() {
    println!("{}", 1);
}

output:

println! { "{}" , 1 }
print! { concat ! ( "{}" , "\n" ) , 1 }
<anon>:1:1: 1:26 error: #[feature] may not be used on the stable release channel
<anon>:1 #![feature(trace_macros)]
         ^~~~~~~~~~~~~~~~~~~~~~~~~
error: aborting due to previous error
@durka

This comment has been minimized.

Copy link
Contributor

durka commented Feb 18, 2016

Compilation doesn't complete, so is it really a stability hazard?

@pnkfelix

This comment has been minimized.

Copy link
Member

pnkfelix commented Feb 25, 2016

I'd say that gate is pretty effective, but the compilation is indeed not effect-free ... ha ha ha...

@nikomatsakis

This comment has been minimized.

Copy link
Contributor

nikomatsakis commented Feb 25, 2016

Discussed in @rust-lang/compiler triage mtg. Since compilation doesn't succeed, it's not really possible to publish crates that rely on this. If we take it away, some people could get upset, but it won't cause widescale breakage (and people can always get upset when you take something away, feature-gate or no). Therefore, P-low.

triage: P-low

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.