Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upTracking issue for <[T]>::copy_from_slice #31755
Comments
alexcrichton
added
B-RFC-approved
T-libs
labels
Feb 18, 2016
This comment has been minimized.
This comment has been minimized.
|
cc @ubsan, would you like to implement? |
This comment has been minimized.
This comment has been minimized.
|
@alexcrichton sure, I'll do it tonight :) |
This comment has been minimized.
This comment has been minimized.
|
Well... start work on it at least. make is not being nice... |
briansmith
referenced this issue
Mar 3, 2016
Closed
Replace `ring::polyfill::fill_from_slice` with use of `<[T]>::clone_from_slice()` #136
This comment has been minimized.
This comment has been minimized.
briansmith
commented
Mar 6, 2016
|
What's the reason that it is unstable? I feel like all the arguing that's been argued about it has been argued already. If it weren't destined to be stabilized then I don't think we'd have gotten this far. So, why not just stabilize it right away? |
This comment has been minimized.
This comment has been minimized.
|
All new API starts its life as unstable. |
alexcrichton
added
B-unstable
and removed
B-RFC-approved
labels
Mar 8, 2016
briansmith
referenced this issue
Mar 8, 2016
Closed
Replace use of `ring::polyfill::slice::fill_from_slice` with `copy_from_slice` #141
alexcrichton
added
the
I-nominated
label
Mar 9, 2016
This comment has been minimized.
This comment has been minimized.
|
It might be nice to have a similar memcpy version of Vec::extend_from_slice, although I guess there are enough APIs leading there that specialization might be preferred. In any case, naively calling |
This comment has been minimized.
This comment has been minimized.
|
@comex yeah... let v = Vec::with_capacity(slice.len());
unsafe {
v.set_len(slice.len());
}
v.copy_from_slice(slice); |
This comment has been minimized.
This comment has been minimized.
|
|
alexcrichton
added
final-comment-period
and removed
I-nominated
labels
Mar 11, 2016
This comment has been minimized.
This comment has been minimized.
|
The libs team discussed this during triage yesterday and the decision was to stabilize |
alexcrichton commentedFeb 18, 2016
Tracking issue for rust-lang/rfcs#1419