Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression with type parameter shadowing #32639

Closed
alexcrichton opened this Issue Mar 31, 2016 · 4 comments

Comments

Projects
None yet
3 participants
@alexcrichton
Copy link
Member

alexcrichton commented Mar 31, 2016

The following code compiles on stable/beta but fails to compile on nightly

pub enum T {       
    NonSpecific,   
}                  

fn foo<T>() {      
    T::NonSpecific;
}                  

This is minimized from a regression in the quire crate. This looks pretty intentional, however, so I just wanted to confirm! Was this intentional, and are we comfortable letting this slide through?

cc @jseyfried

@jseyfried

This comment has been minimized.

Copy link
Contributor

jseyfried commented Mar 31, 2016

Yeah, this was intentional -- it was changed in #32141 to fix #32120.
Could there be more breakage (i.e. was this not detected in a crater run)?

@alexcrichton

This comment has been minimized.

Copy link
Member Author

alexcrichton commented Mar 31, 2016

This may be all the breakage we're looking at, that was just a crater run between stable and nightly last night, and it was the only error its kind that showed up.

@jseyfried

This comment has been minimized.

Copy link
Contributor

jseyfried commented Mar 31, 2016

Ok, I'll write a PR to fix the breakage in that crate. I could also do a warning cycle pretty easily but it looks like that won't be needed.

@pnkfelix

This comment has been minimized.

Copy link
Member

pnkfelix commented Mar 31, 2016

(Yes this is expected to break due to aforementioned fix.)

@pnkfelix pnkfelix closed this Mar 31, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.