process::ExitStatus should have some kind of constructor

[nrc]

Because ExitStatus has a private field it is impossible to create one in user code, one must actually execute a process. This prevents testing/mocking. My use case is that I have some function which runs a process and generates data, however, for testing I want to mock the test run and just return a success exit status and some data. I can't do that because I can't create my own ExitStatus objects.

At the least there should be a way to create a success ExitStatus. Preferably, there would be a way to create various fail statuses too.

[frewsxcv]

Should the constructor just take an i32?

[alexcrichton]

I've also wanted a basically "raw constructor" in the past. I'd be fine adding some std::os extensions which allow construction from a c_int or DWORD (i32 and u32)

[jirutka]

+1
I’d like to extend Command, but I cannot reuse Output for return value because I can’t construct ExitStatus. :(

[alexcrichton]

I've opened a PR for this over at #33224

[jirutka]

Great, thanks! 👍

[joelself]

This would help n00bs like me who start out by copying the example code and tweaking it:

let output = Command::new("sh")
                     .arg("-c")
                     .arg("echo hello")
                     .output()
                     .unwrap_or_else(|e| { panic!("failed to execute process: {}", e) });

This example is a special case that only happens to work if the unwrap_or_else contains a panic! or something else that immediately exits. Otherwise you need to create your own Output struct to return which is currently impossible.

[alexcrichton]

🔔 This issue is now entering a cycle-long final comment period for stabilization 🔔

[alexcrichton]

Discussed recently, the libs team decided to stabilize.