Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upPanic in librbml while drunk-compiling #33015
Comments
This comment has been minimized.
This comment has been minimized.
|
Couldn't reproduce: next time I compiled, I just got a compile error in a different part of the compiled code. Just thought I would raise a ticket anyway because it should probably not have panicked the first time. Lesson for future generations of rustaceans: don't compile code on friday pub night when drunk: It's bad for your health! |
This comment has been minimized.
This comment has been minimized.
sanmai-NL
commented
Apr 16, 2016
|
You have a curious idea of a night out! |
This comment has been minimized.
This comment has been minimized.
|
I think someone is doing error recovery for "error: the crate "bitflags" has been comp |
bluss
added
the
A-amusing
label
Apr 16, 2016
This comment has been minimized.
This comment has been minimized.
|
@pierrechevalier83 Something was very strange in your original description, I tried to clean up the markdown to make it easier to read. |
This comment has been minimized.
This comment has been minimized.
|
Problem lines of code: rust/src/libsyntax/errors/mod.rs Line 209 in 2a815a2 pub fn emit(&mut self) {
if self.cancelled() {
return;
}
self.emitter.borrow_mut().emit_struct(&self);
self.cancel();
// if self.is_fatal() {
// panic!(FatalError);
// }
}Why is the panic commented? cc @nrc |
arielb1
added
I-nominated
T-compiler
labels
May 1, 2016
This comment has been minimized.
This comment has been minimized.
|
That seems like it should be uncommented. It's a mistake either way, I wouldn't deliberately check-in commented code, but I don't recall if it should be uncommented or just not there. It does seem like we should panic on fatal errors. |
This comment has been minimized.
This comment has been minimized.
|
triage: P-medium |
rust-highfive
added
P-medium
and removed
I-nominated
labels
May 5, 2016
dwillie
referenced this issue
May 19, 2016
Closed
thread 'rustc' panicked at 'explicit panic', ../src/librbml/lib.rs:436 #33733
This comment has been minimized.
This comment has been minimized.
filmor
commented
Jun 7, 2016
|
The ghost seems to be back, I'm getting this error when compiling RustAudio/synth on Windows. I'll try to get rustc compiled from source to debug this. |
This comment has been minimized.
This comment has been minimized.
|
@filmor Did you update your Rust version yet there are |
This comment has been minimized.
This comment has been minimized.
filmor
commented
Jun 7, 2016
|
Not that I'm aware, this is a fresh build with a newly rustupped rustc. To be sure I cleaned up |
pierrechevalier83 commentedApr 15, 2016
•
edited by eddyb