Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`net::{TcpStream,TcpListener}::set_only_v6` are useless #33052

Closed
troplin opened this Issue Apr 17, 2016 · 1 comment

Comments

Assignees
No one assigned
Labels
T-libs
Projects
None yet
Milestone
No milestone
2 participants
@troplin @sfackler
@troplin
Copy link
Contributor

troplin commented Apr 17, 2016

AFAIUI, net::TcpListener::set_only_v6 has to be called before binding a socket. However, with the current API this is not possible.

For TcpStream I'm not sure if this option is meaningful at all. And if it is, it surely has to be set before connecting.

I know the FCP for those is over, but they should still be removed IMO.

@sfackler sfackler added I-nominated T-libs labels Apr 17, 2016

@sfackler

This comment has been minimized.

Sign in to view
Copy link
Member

sfackler commented Apr 17, 2016

Oops, yeah, I'd say we should probably back these out of the beta. I'll raise it for discussion during libs triage.

@rust-lang/libs.

sfackler added a commit to sfackler/rust that referenced this issue Apr 21, 2016

@sfackler
Remove IPV6_V6ONLY functionality 
These settings can only be adjusted before bind time, which doesn't make
sense in the current set of functionality. These methods are stable, but
haven't hit a stable release yet.

Closes rust-lang#33052

[breaking-change]
c6480e8

@sfackler sfackler referenced this issue Apr 21, 2016

Merged

Remove IPV6_V6ONLY functionality #33124

bors added a commit that referenced this issue Apr 23, 2016

@bors
Auto merge of #33124 - sfackler:kill-ipv6-only, r=alexcrichton 
Remove IPV6_V6ONLY functionality

These settings can only be adjusted before bind time, which doesn't make
sense in the current set of functionality. These methods are stable, but
haven't hit a stable release yet.

Closes #33052

[breaking-change]

r? @alexcrichton

Will also need a backport to the beta.
23ccadd

@bors bors closed this in #33124 Apr 24, 2016

@sfackler sfackler removed the I-nominated label Apr 24, 2016

sfackler added a commit to sfackler/rust that referenced this issue Apr 28, 2016

@sfackler
Remove IPV6_V6ONLY functionality 
These settings can only be adjusted before bind time, which doesn't make
sense in the current set of functionality. These methods are stable, but
haven't hit a stable release yet.

Closes rust-lang#33052

[breaking-change]

(cherry picked from commit c6480e8)
2842d4d

@sfackler sfackler referenced this issue Apr 28, 2016

Merged

Remove IPV6_V6ONLY functionality #33263

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.