Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign uplanguage version markers #3392
Comments
ghost
assigned
graydon
Sep 5, 2012
This comment has been minimized.
This comment has been minimized.
|
This need not block 0.6. |
This comment has been minimized.
This comment has been minimized.
|
nominating for backwards compatible |
This comment has been minimized.
This comment has been minimized.
|
accepted for backwards-compatible milestone |
This comment has been minimized.
This comment has been minimized.
|
Visiting for triage; nothing to add |
flaper87
referenced this issue
Apr 16, 2014
Closed
Need a mechanism to write rust-version-specific code #3795
This comment has been minimized.
This comment has been minimized.
|
Nominating. This ought to be done with #3795. |
brson
added
the
I-nominated
label
Jun 11, 2014
This comment has been minimized.
This comment has been minimized.
|
If you want fully-general language versioning, then the approach of #3795 does not seem sufficient. (In particular, you still need to be able to parse in order to deal with the |
This comment has been minimized.
This comment has been minimized.
|
(we're going to leave I-nominated so we can wait until next week and see if @brson can explain his thoughts further.) |
This comment has been minimized.
This comment has been minimized.
|
((it seems like some of the discussion on #3795 elaborates further on what @brson might have been thinking. E.g. @cmr said there that one should only attempt to work at the level of per-crate granularity, which would probably side-step the parser issue, though I think that per-crate may be too coarse -- per mod-in-a-file is more what I was thinking...)) |
graydon
removed their assignment
Jun 16, 2014
brson
added
P-low
and removed
P-backcompat-lang
labels
Jun 19, 2014
This comment has been minimized.
This comment has been minimized.
|
P-low, not 1.0 |
thestinger
removed
the
I-completion
label
Sep 16, 2014
This comment has been minimized.
This comment has been minimized.
|
If something ever happens here it will be done as-needed. It's not really on the horizon right now. Closing. |
graydon commentedSep 5, 2012
We need a way (using the hash-comment "pre-parse" form similar to shebang comments) to mark a crate's (symbolic) language version, so we don't try parsing rust when we don't have a parser that can handle it. We'll mandate the presence of this sort of marker on a packaged-for-distribution rust file.