Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd Mutex methods that ignore poisoning #35092
Comments
brson
added
I-papercut
C-enhancement
I-nominated
T-libs
labels
Jul 28, 2016
This comment has been minimized.
This comment has been minimized.
|
For reference, this is what you type when you need to ignore poisoning: |
This comment has been minimized.
This comment has been minimized.
|
Would be worthwhile to survey existing code bases to see how common it is to ignore poisoning. |
This comment has been minimized.
This comment has been minimized.
|
I made a wrapper crate over the standard library types to do this: https://crates.io/crates/antidote I have needed to poison a data structure exactly once in my career (Rust and not-Rust). |
This comment has been minimized.
This comment has been minimized.
|
The libs team discussed this yesterday and the conclusion was that a change like this would require an RFC, so as a result we're going to close this in favor of a future incarnation in the rust-lang/rfcs repo. |
alexcrichton
closed this
Aug 16, 2016
This comment has been minimized.
This comment has been minimized.
|
Relatedly, I'd like |
This comment has been minimized.
This comment has been minimized.
|
@Ericson2314 Wouldn't that break source compatibility? (Am I right to assume that panic=abort is not supposed to?) |
This comment has been minimized.
This comment has been minimized.
|
@glaebhoerl sorry this would be a scenario thing where one can be portable/parametric wrt panic strategy, or rely on one and not work with the other. |
brson commentedJul 28, 2016
•
edited
Scenarios where one wants to ignore poisoning happen. Having to type extra incantations to ignore the poisoning can be quite unpleasant, makes Rust less ergonomic, and is a source of complaints. Let's please consider adding conveniences for cases where poisoning is not desired, either additional methods, or new types that do not poison.