Error code list which need to be updated to new format #35233

Closed
GuillaumeGomez opened this Issue Aug 3, 2016 · 300 comments

Comments

Projects
None yet
@GuillaumeGomez
Member

GuillaumeGomez commented Aug 3, 2016

If you want to work on one (or more) of the issues, just comment on it to say you're taking it!

You can read @jonathandturner's post about how to make the fixes. If you have any questions, ask us here or on #rust-internals on irc.mozilla.org.

Also, if you finish an issue and it has a "Bonus" part that you're not able to complete, just go ahead and close the issue and open a new issue for just the Bonus part. That way, someone else can jump in and work on the bonus part. You can cc me on the new issue and we can add it to the list above.

Here is the list of error codes:

Bonuses:

Note: bonuses may require more work in the compiler and may require some exploration.

EDIT: Don't forget to say "Part of #35233." in your PR so we can see who did what in here. Also, add "r? @GuillaumeGomez" or "r? @jonathandturner" to set us as reviewer.

@bstrie bstrie added the metabug label Aug 3, 2016

@cramertj

This comment has been minimized.

Show comment
Hide comment
@cramertj

cramertj Aug 3, 2016

Member

I guess I'll go first! I'll take 1, 4, 5, and 9.
Edit: Since there was so much interest, I gave these away. @Roybie has 1, @TheZoq2 has 4, @pythoneer has 5, and @DevShep has 9. Thanks for contributing, folks!

Member

cramertj commented Aug 3, 2016

I guess I'll go first! I'll take 1, 4, 5, and 9.
Edit: Since there was so much interest, I gave these away. @Roybie has 1, @TheZoq2 has 4, @pythoneer has 5, and @DevShep has 9. Thanks for contributing, folks!

@pcn

This comment has been minimized.

Show comment
Hide comment
@pcn

pcn Aug 3, 2016

Contributor

I have no idea what I'm doing. I'll take 10, 17, 23 and 25.

Contributor

pcn commented Aug 3, 2016

I have no idea what I'm doing. I'll take 10, 17, 23 and 25.

@silenuss

This comment has been minimized.

Show comment
Hide comment
@silenuss

silenuss Aug 3, 2016

Contributor

I've also got no idea what I'm doing. I'll take 27, 29, 30, and 34. This should be fun.

Contributor

silenuss commented Aug 3, 2016

I've also got no idea what I'm doing. I'll take 27, 29, 30, and 34. This should be fun.

@jonathandturner

This comment has been minimized.

Show comment
Hide comment
@jonathandturner

jonathandturner Aug 3, 2016

Contributor

For the "I have no idea what I'm doing" crowd - I'm working on a blog post that's going up soon (hopefully tomorrow!) It goes through all the steps of how to update the errors.

Thanks for jumping on them :) Once the blog goes up, I'll reply here with the link.

Contributor

jonathandturner commented Aug 3, 2016

For the "I have no idea what I'm doing" crowd - I'm working on a blog post that's going up soon (hopefully tomorrow!) It goes through all the steps of how to update the errors.

Thanks for jumping on them :) Once the blog goes up, I'll reply here with the link.

@stephen-lazaro

This comment has been minimized.

Show comment
Hide comment
@stephen-lazaro

stephen-lazaro Aug 3, 2016

Contributor

I've never done this before. I'd like to grab 91, 92, and 93 if that'd be helpful!

Contributor

stephen-lazaro commented Aug 3, 2016

I've never done this before. I'd like to grab 91, 92, and 93 if that'd be helpful!

@shri3k

This comment has been minimized.

Show comment
Hide comment
@shri3k

shri3k Aug 3, 2016

Contributor

I'll take 40 and 46 even though I don't know much about traits.

Edit: Removing 49 & 50 so that others have chance to contribute as well.

Contributor

shri3k commented Aug 3, 2016

I'll take 40 and 46 even though I don't know much about traits.

Edit: Removing 49 & 50 so that others have chance to contribute as well.

@jaredwy

This comment has been minimized.

Show comment
Hide comment
@jaredwy

jaredwy Aug 3, 2016

I will take 61, 63 and 69.

jaredwy commented Aug 3, 2016

I will take 61, 63 and 69.

@razielgn

This comment has been minimized.

Show comment
Hide comment
@razielgn

razielgn Aug 3, 2016

Contributor

Booking 71, 76 and 79. 😃

Contributor

razielgn commented Aug 3, 2016

Booking 71, 76 and 79. 😃

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Aug 3, 2016

I'll take 81, 87, 88 and 89

ghost commented Aug 3, 2016

I'll take 81, 87, 88 and 89

@nickmass

This comment has been minimized.

Show comment
Hide comment
@nickmass

nickmass Aug 3, 2016

Contributor

I will take 55, 57, and 60

Contributor

nickmass commented Aug 3, 2016

I will take 55, 57, and 60

@theypsilon

This comment has been minimized.

Show comment
Hide comment
@theypsilon

theypsilon Aug 3, 2016

Contributor

I take 94 and 384 (I think there are no more available)

Contributor

theypsilon commented Aug 3, 2016

I take 94 and 384 (I think there are no more available)

@lukehinds

This comment has been minimized.

Show comment
Hide comment
@lukehinds

lukehinds Aug 3, 2016

Contributor

Might I suggest folks just take on one or two issues, that way others wanting to learn, will have a chance to get involved too.

Contributor

lukehinds commented Aug 3, 2016

Might I suggest folks just take on one or two issues, that way others wanting to learn, will have a chance to get involved too.

@cramertj

This comment has been minimized.

Show comment
Hide comment
@cramertj

cramertj Aug 3, 2016

Member

@lukehinds Yeah, I didn't realize the precedent I was setting, nor how much interest there would be in the issue. If others who haven't contributed before would like to take any of the ones I said I would do (1, 4, 5, 9), they're welcome to it.

Member

cramertj commented Aug 3, 2016

@lukehinds Yeah, I didn't realize the precedent I was setting, nor how much interest there would be in the issue. If others who haven't contributed before would like to take any of the ones I said I would do (1, 4, 5, 9), they're welcome to it.

@TheZoq2

This comment has been minimized.

Show comment
Hide comment
@TheZoq2

TheZoq2 Aug 3, 2016

Contributor

I'll gladly take 4 then

Contributor

TheZoq2 commented Aug 3, 2016

I'll gladly take 4 then

@Roybie

This comment has been minimized.

Show comment
Hide comment
@Roybie

Roybie Aug 3, 2016

Contributor

I'll wouldn't mind taking number 1 off you then if that's ok?

Contributor

Roybie commented Aug 3, 2016

I'll wouldn't mind taking number 1 off you then if that's ok?

@stephen-lazaro

This comment has been minimized.

Show comment
Hide comment
@stephen-lazaro

stephen-lazaro Aug 3, 2016

Contributor

@lukehinds I'll release 93 then. I can always pick it back up later if no one ends up wanting it.

Contributor

stephen-lazaro commented Aug 3, 2016

@lukehinds I'll release 93 then. I can always pick it back up later if no one ends up wanting it.

@DarkEld3r

This comment has been minimized.

Show comment
Hide comment
@DarkEld3r

DarkEld3r Aug 3, 2016

Contributor

I would like to try 93 then. Thank you.

Contributor

DarkEld3r commented Aug 3, 2016

I would like to try 93 then. Thank you.

@DevShep

This comment has been minimized.

Show comment
Hide comment
@DevShep

DevShep Aug 3, 2016

Contributor

@cramertj I'll take 9 of you don't mind.

Contributor

DevShep commented Aug 3, 2016

@cramertj I'll take 9 of you don't mind.

@pythoneer

This comment has been minimized.

Show comment
Hide comment
@pythoneer

pythoneer Aug 3, 2016

Contributor

anything left? i lost count :D

Contributor

pythoneer commented Aug 3, 2016

anything left? i lost count :D

@TheZoq2

This comment has been minimized.

Show comment
Hide comment
@TheZoq2

TheZoq2 Aug 3, 2016

Contributor

@pythoneer It looks like 5 is still available from the ones @cramertj released

Contributor

TheZoq2 commented Aug 3, 2016

@pythoneer It looks like 5 is still available from the ones @cramertj released

@pythoneer

This comment has been minimized.

Show comment
Hide comment
@pythoneer

pythoneer Aug 3, 2016

Contributor

i'll jump on 5 then, thx @TheZoq2

Contributor

pythoneer commented Aug 3, 2016

i'll jump on 5 then, thx @TheZoq2

@yossi-k

This comment has been minimized.

Show comment
Hide comment
@yossi-k

yossi-k Aug 3, 2016

Contributor

Anything else left?

Contributor

yossi-k commented Aug 3, 2016

Anything else left?

@lukehinds

This comment has been minimized.

Show comment
Hide comment
@lukehinds

lukehinds Aug 3, 2016

Contributor

@pcn @silenuss could you guys free up some of your issues for @yossi-k (and likely some others too!)

Contributor

lukehinds commented Aug 3, 2016

@pcn @silenuss could you guys free up some of your issues for @yossi-k (and likely some others too!)

@razielgn

This comment has been minimized.

Show comment
Hide comment
@razielgn

razielgn Aug 3, 2016

Contributor

Releasing 76 and 79. 😄

Contributor

razielgn commented Aug 3, 2016

Releasing 76 and 79. 😄

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Aug 3, 2016

Member

Wo. Much more success than expected! I intended to do a big part of it but I guess I'll just review.

Member

GuillaumeGomez commented Aug 3, 2016

Wo. Much more success than expected! I intended to do a big part of it but I guess I'll just review.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Aug 3, 2016

Member

@yossi-k: 76 and 79 are free.

Member

GuillaumeGomez commented Aug 3, 2016

@yossi-k: 76 and 79 are free.

@Mokou

This comment has been minimized.

Show comment
Hide comment
@Mokou

Mokou Aug 3, 2016

I would like to try 76.

Mokou commented Aug 3, 2016

I would like to try 76.

@yossi-k

This comment has been minimized.

Show comment
Hide comment
@yossi-k

yossi-k Aug 3, 2016

Contributor

I'm on 79 then

Contributor

yossi-k commented Aug 3, 2016

I'm on 79 then

@nindalf

This comment has been minimized.

Show comment
Hide comment

nindalf commented Aug 3, 2016

@GuillaumeGomez any left?

@faebser

This comment has been minimized.

Show comment
Hide comment
@faebser

faebser Aug 3, 2016

Contributor

@GuillaumeGomez any left for me?

Contributor

faebser commented Aug 3, 2016

@GuillaumeGomez any left for me?

@shantanuraj

This comment has been minimized.

Show comment
Hide comment
@shantanuraj

shantanuraj Aug 3, 2016

Contributor

I'll take 80

Contributor

shantanuraj commented Aug 3, 2016

I'll take 80

@shri3k

This comment has been minimized.

Show comment
Hide comment
@shri3k

shri3k Aug 3, 2016

Contributor

@faebser @nindalf I just removed 49 & 50 from my plate if you're interested on them.

Contributor

shri3k commented Aug 3, 2016

@faebser @nindalf I just removed 49 & 50 from my plate if you're interested on them.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Aug 3, 2016

Member

@nindalf: You can take 49 and @faebser will take 50 (thanks @shri3k!).

Member

GuillaumeGomez commented Aug 3, 2016

@nindalf: You can take 49 and @faebser will take 50 (thanks @shri3k!).

@nindalf

This comment has been minimized.

Show comment
Hide comment

nindalf commented Aug 3, 2016

@shri3k thanks!

@paulfanelli

This comment has been minimized.

Show comment
Hide comment
@paulfanelli

paulfanelli Aug 3, 2016

Contributor

Any left to fix? Would love to give this a whirl.

Contributor

paulfanelli commented Aug 3, 2016

Any left to fix? Would love to give this a whirl.

@leikahing

This comment has been minimized.

Show comment
Hide comment
@leikahing

leikahing Aug 3, 2016

Contributor

I'm a little late to the party but I was also wondering if there were any left to fix?

Contributor

leikahing commented Aug 3, 2016

I'm a little late to the party but I was also wondering if there were any left to fix?

gavinb added a commit to gavinb/rust that referenced this issue Oct 1, 2016

Improve error message and snippet for "did you mean `x`"
- Fixes #36164
- Part of #35233
- handles unknown fields
- uses UI-style tests
- update all related tests

gavinb added a commit to gavinb/rust that referenced this issue Oct 1, 2016

Improve error message and snippet for "did you mean `x`"
- Fixes #36164
- Part of #35233
- handles unknown fields
- uses UI-style tests
- update all related tests (cfail, ui)

gavinb added a commit to gavinb/rust that referenced this issue Oct 2, 2016

Improve error message and snippet for "did you mean `x`"
- Fixes #36164
- Part of #35233
- handles unknown fields
- uses UI-style tests
- update all related tests (cfail, ui, incremental)

bors added a commit that referenced this issue Oct 2, 2016

Manishearth added a commit to Manishearth/rust that referenced this issue Oct 4, 2016

Rollup merge of #36798 - gavinb:fix/36164, r=GuillaumeGomez
Improve error message and snippet for "did you mean `x`"

- Fixes #36164
- Part of #35233

Based on the standalone example https://is.gd/8STXMd posted by @nikomatsakis and using the third formatting option mentioned in #36164 and agreed by @jonathandturner.

Note however this does not address the question of [how to handle an empty or unknown suggestion](rust-lang#36164 (comment)). @nikomatsakis any suggestions on how best to address that part?
@mikhail-m1

This comment has been minimized.

Show comment
Hide comment
@mikhail-m1

mikhail-m1 Oct 4, 2016

Contributor

@jonathandturner Any free bonuses? I'd like to take one

Contributor

mikhail-m1 commented Oct 4, 2016

@jonathandturner Any free bonuses? I'd like to take one

@jonathandturner

This comment has been minimized.

Show comment
Hide comment
@jonathandturner

jonathandturner Oct 4, 2016

Contributor

Yes! to @mikhail-m1 and anyone interested, there are 5 bonuses on the bonus list that haven't been completed yet. Please feel free to grab one!

Contributor

jonathandturner commented Oct 4, 2016

Yes! to @mikhail-m1 and anyone interested, there are 5 bonuses on the bonus list that haven't been completed yet. Please feel free to grab one!

@mikhail-m1

This comment has been minimized.

Show comment
Hide comment
@mikhail-m1

mikhail-m1 Oct 4, 2016

Contributor

@jonathandturner I'll take 'Doesn't live long enough'

Contributor

mikhail-m1 commented Oct 4, 2016

@jonathandturner I'll take 'Doesn't live long enough'

@gavinb

This comment has been minimized.

Show comment
Hide comment
@gavinb

gavinb Oct 5, 2016

Contributor

@jonathandturner Next time you update the list, I've completed the "EXXXX - Field unknown" bonus with #36798. Having a look at the others now.

Contributor

gavinb commented Oct 5, 2016

@jonathandturner Next time you update the list, I've completed the "EXXXX - Field unknown" bonus with #36798. Having a look at the others now.

@jonathandturner

This comment has been minimized.

Show comment
Hide comment
@jonathandturner

jonathandturner Oct 6, 2016

Contributor

@gavinb - great! It's updated

Contributor

jonathandturner commented Oct 6, 2016

@gavinb - great! It's updated

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Oct 7, 2016

bors added a commit that referenced this issue Oct 21, 2016

Auto merge of #37174 - mikhail-m1:dnlle, r=jonathandturner
improve "Doesn't live long enough" error

I've fixed only with same case

issue #36537 part of  #35233
r? @jonathandturner

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Oct 26, 2016

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Oct 26, 2016

jonathandturner added a commit to jonathandturner/rust that referenced this issue Nov 2, 2016

Rollup merge of #37405 - mikhail-m1:dnlle, r=jonathandturner
Improve "Doesn't live long enough" error

case with different lifetime scope

issue #36537 part of #35233
r? @jonathandturner
@jonathandturner

This comment has been minimized.

Show comment
Hide comment
@jonathandturner

jonathandturner Nov 4, 2016

Contributor

Long time no see! I just added a really juicy task with some good bonus material. Niko has gone into great pains to list out the steps that need to go into this, and it's fixing a common pain point: seeing _ instead of the name of the type variable.

You can see the steps here: #36554 (comment)

Contributor

jonathandturner commented Nov 4, 2016

Long time no see! I just added a really juicy task with some good bonus material. Niko has gone into great pains to list out the steps that need to go into this, and it's fixing a common pain point: seeing _ instead of the name of the type variable.

You can see the steps here: #36554 (comment)

@mikhail-m1

This comment has been minimized.

Show comment
Hide comment
@mikhail-m1

mikhail-m1 Nov 12, 2016

Contributor

I've almost done EXXXX - Fix temporary message and EXXXX - Doesn't live long enough, working on EXXXX - Better mutability

Contributor

mikhail-m1 commented Nov 12, 2016

I've almost done EXXXX - Fix temporary message and EXXXX - Doesn't live long enough, working on EXXXX - Better mutability

bors added a commit that referenced this issue Nov 12, 2016

Auto merge of #37554 - mikhail-m1:dnlle, r=jonathandturner
Improve "Doesn't live long enough" error

case with temporary variable

issue #36279 part of #35233

r? @jonathandturner

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Nov 20, 2016

Rollup merge of #37835 - ojsheikh:E0088, r=jonathandturner
Update E0088 to new error format

Fixes #35226 which is part of #35233. Is based on #36208 from @yossi-k.

r? @jonathandturner

bors added a commit that referenced this issue Nov 29, 2016

Auto merge of #37863 - mikhail-m1:mut_error, r=nikomatsakis
add hint to fix error for immutable ref in arg

fix  #36412 part of #35233
r? @jonathandturner
@bstrie

This comment has been minimized.

Show comment
Hide comment
@bstrie

bstrie Mar 21, 2017

Contributor

@jonathandturner Looks like all these are done except for the "bonus" bugs. Worth closing this issue?

Contributor

bstrie commented Mar 21, 2017

@jonathandturner Looks like all these are done except for the "bonus" bugs. Worth closing this issue?

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Mar 21, 2017

Member

Make a smaller one would be nice. I'll close once the new smaller one has been created.

Member

GuillaumeGomez commented Mar 21, 2017

Make a smaller one would be nice. I'll close once the new smaller one has been created.

@estebank

This comment has been minimized.

Show comment
Hide comment
@estebank

estebank Feb 27, 2018

Contributor

@GuillaumeGomez I feel like this ticket can now be closed, as every action item has been taken care of.

Contributor

estebank commented Feb 27, 2018

@GuillaumeGomez I feel like this ticket can now be closed, as every action item has been taken care of.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment