Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upError code list which need to be updated to new format #35233
Comments
bstrie
added
the
metabug
label
Aug 3, 2016
This comment has been minimized.
This comment has been minimized.
|
I guess I'll go first! I'll take 1, 4, 5, and 9. |
This comment has been minimized.
This comment has been minimized.
|
I have no idea what I'm doing. I'll take 10, 17, 23 and 25. |
This comment has been minimized.
This comment has been minimized.
|
I've also got no idea what I'm doing. I'll take 27, 29, 30, and 34. This should be fun. |
This comment has been minimized.
This comment has been minimized.
|
For the "I have no idea what I'm doing" crowd - I'm working on a blog post that's going up soon (hopefully tomorrow!) It goes through all the steps of how to update the errors. Thanks for jumping on them :) Once the blog goes up, I'll reply here with the link. |
This comment has been minimized.
This comment has been minimized.
|
I've never done this before. I'd like to grab 91, 92, and 93 if that'd be helpful! |
This comment has been minimized.
This comment has been minimized.
|
I'll take 40 and 46 even though I don't know much about traits. Edit: Removing 49 & 50 so that others have chance to contribute as well. |
This comment has been minimized.
This comment has been minimized.
jaredwy
commented
Aug 3, 2016
•
|
I will take 61, 63 and 69. |
This comment has been minimized.
This comment has been minimized.
|
Booking 71, 76 and 79. |
This comment has been minimized.
This comment has been minimized.
ghost
commented
Aug 3, 2016
|
I'll take 81, 87, 88 and 89 |
This comment has been minimized.
This comment has been minimized.
|
I will take 55, 57, and 60 |
This comment has been minimized.
This comment has been minimized.
|
I take 94 and 384 (I think there are no more available) |
This comment has been minimized.
This comment has been minimized.
|
Might I suggest folks just take on one or two issues, that way others wanting to learn, will have a chance to get involved too. |
This comment has been minimized.
This comment has been minimized.
|
@lukehinds Yeah, I didn't realize the precedent I was setting, nor how much interest there would be in the issue. If others who haven't contributed before would like to take any of the ones I said I would do (1, 4, 5, 9), they're welcome to it. |
This comment has been minimized.
This comment has been minimized.
|
I'll gladly take 4 then |
This comment has been minimized.
This comment has been minimized.
|
I'll wouldn't mind taking number 1 off you then if that's ok? |
This comment has been minimized.
This comment has been minimized.
|
@lukehinds I'll release 93 then. I can always pick it back up later if no one ends up wanting it. |
This comment has been minimized.
This comment has been minimized.
|
I would like to try 93 then. Thank you. |
This comment has been minimized.
This comment has been minimized.
|
@cramertj I'll take 9 of you don't mind. |
This comment has been minimized.
This comment has been minimized.
|
anything left? i lost count :D |
This comment has been minimized.
This comment has been minimized.
|
@pythoneer It looks like 5 is still available from the ones @cramertj released |
This comment has been minimized.
This comment has been minimized.
|
i'll jump on 5 then, thx @TheZoq2 |
This comment has been minimized.
This comment has been minimized.
|
Anything else left? |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Releasing 76 and 79. |
This comment has been minimized.
This comment has been minimized.
|
Wo. Much more success than expected! I intended to do a big part of it but I guess I'll just review. |
This comment has been minimized.
This comment has been minimized.
|
@yossi-k: 76 and 79 are free. |
This comment has been minimized.
This comment has been minimized.
Mokou
commented
Aug 3, 2016
|
I would like to try 76. |
This comment has been minimized.
This comment has been minimized.
|
I'm on 79 then |
This comment has been minimized.
This comment has been minimized.
nindalf
commented
Aug 3, 2016
|
@GuillaumeGomez any left? |
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this issue
Oct 7, 2016
mikhail-m1
referenced this issue
Oct 14, 2016
Merged
improve "Doesn't live long enough" error #37174
bors
added a commit
that referenced
this issue
Oct 21, 2016
jonathandturner
referenced this issue
Oct 24, 2016
Closed
Incomprehensible error message when inference fails for closure #24680
This was referenced Oct 25, 2016
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this issue
Oct 26, 2016
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this issue
Oct 26, 2016
jonathandturner
added a commit
to jonathandturner/rust
that referenced
this issue
Nov 2, 2016
This comment has been minimized.
This comment has been minimized.
|
Long time no see! I just added a really juicy task with some good bonus material. Niko has gone into great pains to list out the steps that need to go into this, and it's fixing a common pain point: seeing You can see the steps here: #36554 (comment) |
This comment has been minimized.
This comment has been minimized.
|
I've almost done EXXXX - Fix temporary message and EXXXX - Doesn't live long enough, working on EXXXX - Better mutability |
bors
added a commit
that referenced
this issue
Nov 12, 2016
mikhail-m1
referenced this issue
Nov 18, 2016
Merged
add hint to fix error for immutable ref in arg #37863
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this issue
Nov 20, 2016
bors
added a commit
that referenced
this issue
Nov 29, 2016
This comment has been minimized.
This comment has been minimized.
|
@jonathandturner Looks like all these are done except for the "bonus" bugs. Worth closing this issue? |
This comment has been minimized.
This comment has been minimized.
|
Make a smaller one would be nice. I'll close once the new smaller one has been created. |
bstrie
referenced this issue
Mar 23, 2017
Open
Switch `run-make` tests from Makefiles to rust #40713
Mark-Simulacrum
removed
the
A-amusing
label
Jun 23, 2017
Mark-Simulacrum
added
the
C-tracking-issue
label
Jul 25, 2017
Manishearth
added
hacktoberfest
and removed
hacktoberfest
labels
Sep 28, 2017
This comment has been minimized.
This comment has been minimized.
|
@GuillaumeGomez I feel like this ticket can now be closed, as every action item has been taken care of. |
GuillaumeGomez commentedAug 3, 2016
•
edited by estebank
If you want to work on one (or more) of the issues, just comment on it to say you're taking it!
You can read @jonathandturner's post about how to make the fixes. If you have any questions, ask us here or on #rust-internals on irc.mozilla.org.
Also, if you finish an issue and it has a "Bonus" part that you're not able to complete, just go ahead and close the issue and open a new issue for just the Bonus part. That way, someone else can jump in and work on the bonus part. You can cc me on the new issue and we can add it to the list above.
Here is the list of error codes:
Bonuses:
Note: bonuses may require more work in the compiler and may require some exploration.
cc @jonathandturner
EDIT: Don't forget to say "Part of #35233." in your PR so we can see who did what in here. Also, add "r? @GuillaumeGomez" or "r? @jonathandturner" to set us as reviewer.