Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error code list which need to be updated to new format #35233

Closed
188 tasks done
GuillaumeGomez opened this issue Aug 3, 2016 · 300 comments
Closed
188 tasks done

Error code list which need to be updated to new format #35233

GuillaumeGomez opened this issue Aug 3, 2016 · 300 comments
Labels
A-diagnostics Area: Messages for errors, warnings, and lints C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. E-easy Call for participation: Experience needed to fix: Easy / not much (good first issue) E-mentor Call for participation: This issue is currently mentored. metabug Issues about issues themselves ("bugs about bugs")

Comments

@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Aug 3, 2016

If you want to work on one (or more) of the issues, just comment on it to say you're taking it!

You can read @jonathandturner's post about how to make the fixes. If you have any questions, ask us here or on #rust-internals on irc.mozilla.org.

Also, if you finish an issue and it has a "Bonus" part that you're not able to complete, just go ahead and close the issue and open a new issue for just the Bonus part. That way, someone else can jump in and work on the bonus part. You can cc me on the new issue and we can add it to the list above.

Here is the list of error codes:

Bonuses:

Note: bonuses may require more work in the compiler and may require some exploration.

EDIT: Don't forget to say "Part of #35233." in your PR so we can see who did what in here. Also, add "r? @GuillaumeGomez" or "r? @jonathandturner" to set us as reviewer.

@bstrie bstrie added the metabug Issues about issues themselves ("bugs about bugs") label Aug 3, 2016
@cramertj
Copy link
Member

cramertj commented Aug 3, 2016

I guess I'll go first! I'll take 1, 4, 5, and 9.
Edit: Since there was so much interest, I gave these away. @Roybie has 1, @TheZoq2 has 4, @pythoneer has 5, and @devshep has 9. Thanks for contributing, folks!

@pcn
Copy link
Contributor

pcn commented Aug 3, 2016

I have no idea what I'm doing. I'll take 10, 17, 23 and 25.

@silenuss
Copy link
Contributor

silenuss commented Aug 3, 2016

I've also got no idea what I'm doing. I'll take 27, 29, 30, and 34. This should be fun.

@jntrnr
Copy link
Contributor

jntrnr commented Aug 3, 2016

For the "I have no idea what I'm doing" crowd - I'm working on a blog post that's going up soon (hopefully tomorrow!) It goes through all the steps of how to update the errors.

Thanks for jumping on them :) Once the blog goes up, I'll reply here with the link.

@stephen-lazaro
Copy link
Contributor

stephen-lazaro commented Aug 3, 2016

I've never done this before. I'd like to grab 91, 92, and 93 if that'd be helpful!

@shri3k
Copy link
Contributor

shri3k commented Aug 3, 2016

I'll take 40 and 46 even though I don't know much about traits.

Edit: Removing 49 & 50 so that others have chance to contribute as well.

@jaredwy
Copy link

jaredwy commented Aug 3, 2016

I will take 61, 63 and 69.

@razielgn
Copy link
Contributor

razielgn commented Aug 3, 2016

Booking 71, 76 and 79. 😃

@ghost
Copy link

ghost commented Aug 3, 2016

I'll take 81, 87, 88 and 89

@nickmass
Copy link
Contributor

nickmass commented Aug 3, 2016

I will take 55, 57, and 60

@theypsilon
Copy link
Contributor

theypsilon commented Aug 3, 2016

I take 94 and 384 (I think there are no more available)

@lukehinds
Copy link
Contributor

lukehinds commented Aug 3, 2016

Might I suggest folks just take on one or two issues, that way others wanting to learn, will have a chance to get involved too.

@cramertj
Copy link
Member

cramertj commented Aug 3, 2016

@lukehinds Yeah, I didn't realize the precedent I was setting, nor how much interest there would be in the issue. If others who haven't contributed before would like to take any of the ones I said I would do (1, 4, 5, 9), they're welcome to it.

@TheZoq2
Copy link
Contributor

TheZoq2 commented Aug 3, 2016

I'll gladly take 4 then

@Roybie
Copy link
Contributor

Roybie commented Aug 3, 2016

I'll wouldn't mind taking number 1 off you then if that's ok?

@stephen-lazaro
Copy link
Contributor

stephen-lazaro commented Aug 3, 2016

@lukehinds I'll release 93 then. I can always pick it back up later if no one ends up wanting it.

@stanislav-tkach
Copy link
Contributor

stanislav-tkach commented Aug 3, 2016

I would like to try 93 then. Thank you.

@LionOps
Copy link
Contributor

LionOps commented Aug 3, 2016

@cramertj I'll take 9 of you don't mind.

@pythoneer
Copy link
Contributor

pythoneer commented Aug 3, 2016

anything left? i lost count :D

@TheZoq2
Copy link
Contributor

TheZoq2 commented Aug 3, 2016

@pythoneer It looks like 5 is still available from the ones @cramertj released

@pythoneer
Copy link
Contributor

pythoneer commented Aug 3, 2016

i'll jump on 5 then, thx @TheZoq2

@yossi-k
Copy link
Contributor

yossi-k commented Aug 3, 2016

Anything else left?

@lukehinds
Copy link
Contributor

lukehinds commented Aug 3, 2016

@pcn @silenuss could you guys free up some of your issues for @yossi-k (and likely some others too!)

@razielgn
Copy link
Contributor

razielgn commented Aug 3, 2016

Releasing 76 and 79. 😄

@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Aug 3, 2016

Wo. Much more success than expected! I intended to do a big part of it but I guess I'll just review.

@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Aug 3, 2016

@yossi-k: 76 and 79 are free.

@Mokou
Copy link

Mokou commented Aug 3, 2016

I would like to try 76.

@yossi-k
Copy link
Contributor

yossi-k commented Aug 3, 2016

I'm on 79 then

@nindalf
Copy link

nindalf commented Aug 3, 2016

@GuillaumeGomez any left?

bors added a commit that referenced this issue Oct 21, 2016
improve "Doesn't live long enough" error

I've fixed only with same case

issue #36537 part of  #35233
r? @jonathandturner
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Oct 26, 2016
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Oct 26, 2016
jntrnr pushed a commit to jntrnr/rust that referenced this issue Nov 2, 2016
Improve "Doesn't live long enough" error

case with different lifetime scope

issue rust-lang#36537 part of rust-lang#35233
r? @jonathandturner
@jntrnr
Copy link
Contributor

jntrnr commented Nov 4, 2016

Long time no see! I just added a really juicy task with some good bonus material. Niko has gone into great pains to list out the steps that need to go into this, and it's fixing a common pain point: seeing _ instead of the name of the type variable.

You can see the steps here: #36554 (comment)

@mikhail-m1
Copy link
Contributor

mikhail-m1 commented Nov 12, 2016

I've almost done EXXXX - Fix temporary message and EXXXX - Doesn't live long enough, working on EXXXX - Better mutability

bors added a commit that referenced this issue Nov 12, 2016
Improve "Doesn't live long enough" error

case with temporary variable

issue #36279 part of #35233

r? @jonathandturner
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Nov 20, 2016
bors added a commit that referenced this issue Nov 29, 2016
add hint to fix error for immutable ref in arg

fix  #36412 part of #35233
r? @jonathandturner
@bstrie
Copy link
Contributor

bstrie commented Mar 21, 2017

@jonathandturner Looks like all these are done except for the "bonus" bugs. Worth closing this issue?

@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Mar 21, 2017

Make a smaller one would be nice. I'll close once the new smaller one has been created.

@Mark-Simulacrum Mark-Simulacrum added the C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. label Jul 25, 2017
@Manishearth Manishearth added hacktoberfest hacktoberfest projects - https://hacktoberfest.digitalocean.com/ and removed hacktoberfest hacktoberfest projects - https://hacktoberfest.digitalocean.com/ labels Sep 28, 2017
@estebank
Copy link
Contributor

estebank commented Feb 27, 2018

@GuillaumeGomez I feel like this ticket can now be closed, as every action item has been taken care of.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. E-easy Call for participation: Experience needed to fix: Easy / not much (good first issue) E-mentor Call for participation: This issue is currently mentored. metabug Issues about issues themselves ("bugs about bugs")
Projects
None yet
Development

No branches or pull requests