Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for static lifetime in statics (RFC #1623) #35897

Closed
nikomatsakis opened this Issue Aug 22, 2016 · 37 comments

Comments

Assignees
No one assigned
Labels
B-RFC-approved B-unstable E-mentor T-lang final-comment-period
Projects
None yet
Milestone
No milestone
@nikomatsakis
Copy link
Contributor

nikomatsakis commented Aug 22, 2016

Tracking issue for "static lifetime in statics", rust-lang/rfcs#1623, which defaults omitted lifetimes in statics to 'static.

cc @llogiq

@nikomatsakis nikomatsakis added B-RFC-approved T-lang B-unstable E-help-wanted E-mentor and removed E-help-wanted labels Aug 22, 2016

@nikomatsakis

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

nikomatsakis commented Aug 22, 2016 •
edited

I would be up for mentoring someone in implementing this (nmatsakis on IRC).
@llogiq

This comment has been minimized.

Sign in to view
Copy link
Contributor

llogiq commented Aug 22, 2016

Cool! I'm not sure if I can find the time, but if I do, I'd be glad to code this up.
@nikomatsakis

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

nikomatsakis commented Aug 22, 2016

Here are some pointers into the code:

  • first off, for historical reasons, the code often calls lifetimes regions :)
  • when a region is elided, that winds up being resolved in librustc_typeck by a RegionScope, defined in librustc_typeck/rscope.rs; in particular the anon_regions() method is called to figure out what to do
  • currently statics use an ExplicitRscope; this is selected in this code in collect.rs, which handles statics and constants
  • we would want to switch that to a ElidableRscope with default set to ty::ReStatic, I think
@llogiq

This comment has been minimized.

Sign in to view
Copy link
Contributor

llogiq commented Aug 22, 2016

Great! I think with those pointers I should be able to make some progress even with a modest amount of time.

bors added a commit that referenced this issue Sep 2, 2016

@bors
Auto merge of #35915 - llogiq:rfc-1623, r=nikomatsakis 
implementing RFC 1623. This fixes #35897.

This is a work in progress. In particular, I want to add more tests,
especially the compile-fail test is very bare-bones.
022cb6d

@bors bors closed this in cfce351 Sep 2, 2016

@nikomatsakis nikomatsakis reopened this Sep 2, 2016

@nikomatsakis

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

nikomatsakis commented Sep 2, 2016

This should not have been closed.
@nikomatsakis

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

nikomatsakis commented Sep 2, 2016

(Until it becomes stable.)

@nikomatsakis nikomatsakis referenced this issue Sep 2, 2016

Closed

Missing feature gate for the default of `'static` #36216

@llogiq

This comment has been minimized.

Sign in to view
Copy link
Contributor

llogiq commented Sep 14, 2016

@chriskrycho just a friendly heads-up: Did you get around to documenting this?
@chriskrycho

This comment has been minimized.

Sign in to view
Copy link
Contributor

chriskrycho commented Sep 14, 2016

I did not, but it’s on my list for after-work tasks this week!
@nikomatsakis

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

nikomatsakis commented Nov 11, 2016

@llogiq this is fully implemented at this point, right? I guess we are blocked on some documentation efforts? I'd like to stabilize this change.
@chriskrycho

This comment has been minimized.

Sign in to view
Copy link
Contributor

chriskrycho commented Nov 11, 2016

@nikomatsakis

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

nikomatsakis commented Nov 14, 2016

@chriskrycho

This was, perhaps ironically given my RFC, blocked on me actually getting around to documenting it. I will aim to document it Monday.

OK :)
@llogiq

This comment has been minimized.

Sign in to view
Copy link
Contributor

llogiq commented Nov 14, 2016

I too would love to see this stabilized. Thank you Niko for pushing this forward! Also thank you Chris for caring about the docs.
@chriskrycho

This comment has been minimized.

Sign in to view
Copy link
Contributor

chriskrycho commented Nov 15, 2016

Sorry, didn’t get to this today as I was sick. Tomorrow, tomorrow, tomorrow!
@llogiq

This comment has been minimized.

Sign in to view
Copy link
Contributor

llogiq commented Nov 15, 2016

Get well soon!
@chriskrycho

This comment has been minimized.

Sign in to view
Copy link
Contributor

chriskrycho commented Nov 22, 2016

Documentation PR inbound shortly!

@chriskrycho chriskrycho referenced this issue Nov 22, 2016

Merged

Document RFC 1623: static lifetime elision. #37928

@aturon

This comment has been minimized.

Sign in to view
Copy link
Member

aturon commented Dec 14, 2016

I'm going to go ahead and nominate for FCP, to kick the process off. Note that actual stabilization is blocked by docs landing, but we can at least start discussing whether to move to FCP (which itself lasts several weeks).

@rfcbot fcp merge
@llogiq

This comment has been minimized.

Sign in to view
Copy link
Contributor

llogiq commented Dec 14, 2016

As I commented on #37928, removing the feature gate would very probably make the doc tests pass, thus removing the last hurdle before merging.

It's a bit unfortunate to have this deadlock problem, but perhaps we can learn something from it?
@chriskrycho

This comment has been minimized.

Sign in to view
Copy link
Contributor

chriskrycho commented Dec 14, 2016

Yeah, this is a process thing I didn't see coming in the discussion in rust-lang/rfcs#1636.

@aturon aturon added the final-comment-period label Jan 4, 2017

@nikomatsakis

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

nikomatsakis commented Jan 7, 2017

@rfcbot reviewed
@rfcbot

This comment has been minimized.

Sign in to view
Copy link

rfcbot commented Jan 23, 2017

🔔 This is now entering its final comment period, as per the review above. 🔔

psst @aturon, I wasn't able to add the final-comment-period label, please do so.

est31 added a commit to est31/rust that referenced this issue Jan 23, 2017

@est31
Stabilize static lifetime in statics 
Stabilizes the "static_in_const" feature.

Closes rust-lang#35897.
69139b6

est31 added a commit to est31/rust that referenced this issue Jan 27, 2017

@est31
Stabilize static lifetime in statics 
Stabilizes the "static_in_const" feature.

Closes rust-lang#35897.
459113b

est31 added a commit to est31/rust that referenced this issue Jan 28, 2017

@est31
Stabilize static lifetime in statics 
Stabilizes the "static_in_const" feature.

Closes rust-lang#35897.
8ac8f0d

est31 added a commit to est31/rust that referenced this issue Jan 28, 2017

@est31
Stabilize static lifetime in statics 
Stabilizes the "static_in_const" feature.

Closes rust-lang#35897.
35191d0
@rfcbot

This comment has been minimized.

Sign in to view
Copy link

rfcbot commented Feb 2, 2017

The final comment period is now complete.

est31 added a commit to est31/rust that referenced this issue Feb 5, 2017

@est31
Stabilize static in const 
Closes rust-lang#35897.
0361dcf

bors added a commit that referenced this issue Feb 7, 2017

@bors
Auto merge of #39265 - est31:master, r=nrc 
Stabilize static lifetime in statics

Stabilize the "static_in_const" feature. Blockers before this PR can be merged:

* [x] The [FCP with inclination to stabilize](#35897 (comment)) needs to be over. FCP lasts roughly three weeks, so will be over at Jan 25, aka this thursday.
* [ ] Documentation needs to be added (#37928)

Closes #35897.
Loading status checks…
443866e

est31 added a commit to est31/rust that referenced this issue Feb 8, 2017

@est31
Stabilize static in const 
Closes rust-lang#35897.
d471ee9

est31 added a commit to est31/rust that referenced this issue Feb 8, 2017

@est31
Stabilize static in const 
Closes rust-lang#35897.
f8b6108

frewsxcv added a commit to frewsxcv/rust that referenced this issue Feb 9, 2017

@frewsxcv
Rollup merge of rust-lang#37928 - chriskrycho:document-rfc-1623, r=st… 
…eveklabnik

Document RFC 1623: static lifetime elision.

This should be the last item required for stabilizing RFC 1623 (rust-lang#35897).
cc455b3

frewsxcv added a commit to frewsxcv/rust that referenced this issue Feb 9, 2017

@frewsxcv
Rollup merge of rust-lang#37928 - chriskrycho:document-rfc-1623, r=st… 
…eveklabnik

Document RFC 1623: static lifetime elision.

This should be the last item required for stabilizing RFC 1623 (rust-lang#35897).
7f7dc76

bors added a commit that referenced this issue Feb 9, 2017

@bors
Auto merge of #39265 - est31:master, r=petrochenkov 
Stabilize static lifetime in statics

Stabilize the "static_in_const" feature. Blockers before this PR can be merged:

* [x] The [FCP with inclination to stabilize](#35897 (comment)) needs to be over. FCP lasts roughly three weeks, so will be over at Jan 25, aka this thursday.
* [x] Documentation needs to be added (#37928)

Closes #35897.
Loading status checks…
1129ce5

@bors bors closed this in #39265 Feb 9, 2017

@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor

brson commented Feb 15, 2017

Reopening until this is backported to 1.16.

@brson brson reopened this Feb 15, 2017

@brson brson added this to the 1.16.0 milestone Feb 15, 2017

@nikomatsakis

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

nikomatsakis commented Feb 16, 2017

@brson wait, why are we backporting? We don't normally backport new features and stabilizations, do we? This seems relatively minor.
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Feb 17, 2017

@nikomatsakis would the lang team prefer to not backport? I don't think there's been a definitive answer in either #39265 (stabilization PR) or in #37928 (doc PR).

I believe @est31 proposed a backport and I tagged it as such b/c of the request, but no answer has been had.

If the answer is "no", however, then we can denominate and remove from milestones.
@est31

This comment has been minimized.

Sign in to view
Copy link
Contributor

est31 commented Feb 17, 2017

Just note that back when I was proposing the backport, I thought that stabilisations usually do get backported. Didn't know that its usually only done exceptionally.
@llogiq

This comment has been minimized.

Sign in to view
Copy link
Contributor

llogiq commented Feb 17, 2017

Given that it's not much code, a backport wouldn't be that costly (and probably much appreciated 😄).

But I'm also fine with waiting for 1.17 if there are more pressing matters.
@aturon

This comment has been minimized.

Sign in to view
Copy link
Member

aturon commented Feb 21, 2017

@alexcrichton I think we should not backport. This is just a normal stabilization and should follow the normal process.
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Feb 21, 2017

Sounds like the backport isn't gonna happen, so I'm going to remove beta-nominated from the PRs and un-milestone this issue.

@alexcrichton alexcrichton removed this from the 1.16.0 milestone Feb 21, 2017

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Feb 21, 2017

Er, also re-close this issue

@alexcrichton alexcrichton closed this Feb 21, 2017

@golddranks golddranks referenced this issue Mar 10, 2017

Merged

Release notes for 1.16 #39835

@golddranks

This comment has been minimized.

Sign in to view
Copy link
Contributor

golddranks commented Mar 12, 2017

@brson, this feature is still mentioned in release notes, even though it didn't land.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.