Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upFix unwinding on emscripten #36514
Comments
brson
added
A-runtime
A-libs
E-hard
labels
Sep 16, 2016
This was referenced Sep 16, 2016
This comment has been minimized.
This comment has been minimized.
|
I've started a patch to use the libcxxabi APIs on emscripten for unwinding. |
This comment has been minimized.
This comment has been minimized.
|
My utterly broken patch is https://github.com/brson/rust/tree/emscripten-unwind. Not sure I will continue to make progress on it, but it would be good to at least get it into a state where we can enable ERROR_ON_UNDEFINED_SYMBOLS #36515 |
This comment has been minimized.
This comment has been minimized.
|
I've pushed a fix for this to #36339 |
This comment has been minimized.
This comment has been minimized.
|
I've pushed a patch to #36339 |
This comment has been minimized.
This comment has been minimized.
|
Fixed. |
brson
closed this
Oct 1, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
brson commentedSep 16, 2016
Today it's totally busted because, among other things, the libunwind symbols are unimplemented in emscripten. It may be worth having an unwinding path that uses libcxxabi for this target so that work doesn't need to be done in emscripten.