Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidy script no longer checks lang features #37013

Closed
brson opened this issue Oct 7, 2016 · 4 comments

Comments

@brson
Copy link
Contributor

commented Oct 7, 2016

Here's a recent output. This script used to list all features in one place and now it only lists lib features.

@brson brson added I-wrong labels Oct 7, 2016

@brson

This comment has been minimized.

Copy link
Contributor Author

commented Oct 7, 2016

The problem is almost certainly that the script no longer detects the source file containing language features correctly. Update the script (src/tools/tidy/src/fetaures.rs) and add an assert that it found at least some lang feature to prevent this happening again.

@brson brson added the E-easy label Oct 7, 2016

@knight42

This comment has been minimized.

Copy link
Contributor

commented Oct 7, 2016

@brson

The root of problem is that the status of lang features listed in src/tools/tidy/src/fetaures.rs were altered to lowercase in this commit, so the lines were all filtered out.

After a fix, the tidy check failed because of the following errors:

tidy check stage1 (x86_64-unknown-linux-gnu)
* 454 error codes
* highest error code: E0568
rust/src/libcore/fmt/mod.rs:1359: duplicating a lang feature
rust/src/libcore/fmt/mod.rs:1366: duplicating a lang feature
rust/src/libcore/cmp.rs:709: duplicating a lang feature
rust/src/libcore/cmp.rs:716: duplicating a lang feature
rust/src/libcore/cmp.rs:719: duplicating a lang feature
rust/src/libcore/cmp.rs:726: duplicating a lang feature
rust/src/libstd/macros.rs:287: duplicating a lang feature
thread 'main' panicked at 'some tidy checks failed', src/tools/tidy/src/main.rs:55

The feature never_type is used multiple times.

@knight42

This comment has been minimized.

Copy link
Contributor

commented Oct 7, 2016

Perhaps we can put those implementations in a submodule?

@brson

This comment has been minimized.

Copy link
Contributor Author

commented Oct 7, 2016

@knight42 Thanks for looking into this. Which implementations do you suggest putting into a submodule, and how will that get the script working again?

I think we can probably just rename the libs features that are violating the check.

tamird added a commit to tamird/rust that referenced this issue Oct 15, 2016
tidy/features: fix checking of lang features
Removes the `STATUSES` static which duplicates truth from the pattern
match in `collect_lang_features`.

Fixes existing duplicates by:
- Renaming never_type{,_impls} on `impl`s on `!`
- Removing the stability attribute on `concat_idents!`

Fixes rust-lang#37013.
tamird added a commit to tamird/rust that referenced this issue Oct 15, 2016
tidy/features: fix checking of lang features
Removes the `STATUSES` static which duplicates truth from the pattern
match in `collect_lang_features`.

Fixes existing duplicates by renaming:
- never_type{,_impls} on `impl`s on `!`
- concat_idents{,_macro} on `macro_rules! concat_idents`

Fixes rust-lang#37013.

@bors bors closed this in bef1911 Oct 28, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.