New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite serialization to use reflection #3714

Closed
erickt opened this Issue Oct 10, 2012 · 2 comments

Comments

Projects
None yet
3 participants
@erickt
Contributor

erickt commented Oct 10, 2012

We need to use a syntax extension to automatically build serializers for records, structs, and enums. Instead, we should switch over to using the visitor-based reflection facilities.

@nikomatsakis

This comment has been minimized.

Show comment
Hide comment
@nikomatsakis

nikomatsakis Oct 10, 2012

Contributor

I am not sure this is a good idea. Some types must have specialized serialization. A deriving-based solution may be more appropriate. (auto_serialize is essentially deriving, of course)

Contributor

nikomatsakis commented Oct 10, 2012

I am not sure this is a good idea. Some types must have specialized serialization. A deriving-based solution may be more appropriate. (auto_serialize is essentially deriving, of course)

@bstrie

This comment has been minimized.

Show comment
Hide comment
@bstrie

bstrie Apr 30, 2013

Contributor

erickt doesn't think this is still relevant.

Contributor

bstrie commented Apr 30, 2013

erickt doesn't think this is still relevant.

@bstrie bstrie closed this Apr 30, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment