Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`try!()` macro is generating the `unused_qualifications` lint #37345

Closed
bluss opened this Issue Oct 22, 2016 · 5 comments

Comments

Assignees
No one assigned
Labels
A-macros T-compiler regression-from-stable-to-nightly
Projects
None yet
Milestone
No milestone
4 participants
@bluss @jseyfried @TimNN @retep998
@bluss
Copy link
Contributor

bluss commented Oct 22, 2016

The macro should not cause warnings in the user's code. This seems to show up due to other changes.

Seen here: https://internals.rust-lang.org/t/regression-report-stable-2016-10-20-vs-nightly-2016-10-21/4255

The lint is allow by default, but some configurations will enable it.
@bluss

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

bluss commented Oct 22, 2016

I don't think adding an allow in try!() is the right fix. Using explicit qualifications is the right thing to do in every macro, and we don't want every user-defined macro to have to add the allow attribute.

@jseyfried Do you know anything about this?
@jseyfried

This comment has been minimized.

Sign in to view
Copy link
Contributor

jseyfried commented Oct 22, 2016

I'm not aware of any recent changes that would cause new warnings / regressions, but I could disable the lint for macro-expanded paths easily.

TheNeikos added a commit to TheNeikos/rustbreak that referenced this issue Oct 22, 2016

@TheNeikos
Remove unusued qualifications lint 
This is due to rust-lang/rust#37345, once that is fixed this can be
reverted
Verified
This commit was signed with a verified signature.
@TheNeikos TheNeikos Marcel Müller
GPG key ID: 84BD3634786D56CF Learn about signing commits
Loading status checks…
d39a369
@TimNN

This comment has been minimized.

Sign in to view
Copy link
Contributor

TimNN commented Oct 22, 2016

Introduced between nightly-2016-10-19 and nightly-2016-10-21 (Changes).

@jseyfried: This could probably be a side effect of #37213.

@TimNN TimNN added A-macros regression-from-stable-to-nightly A-compiler T-compiler and removed A-compiler labels Oct 22, 2016

TheNeikos added a commit to TheNeikos/rustbreak that referenced this issue Oct 22, 2016

@TheNeikos
Remove unusued qualifications lint 
This is due to rust-lang/rust#37345, once that is fixed this can be
reverted
413f13d

@jseyfried jseyfried referenced this issue Oct 23, 2016

Merged

Fix `$crate`-related regressions #37361

@jseyfried

This comment has been minimized.

Sign in to view
Copy link
Contributor

jseyfried commented Oct 23, 2016

@TimNN Indeed, fixed in #37361.

bors added a commit that referenced this issue Oct 26, 2016

@bors
Auto merge of #37361 - jseyfried:fix_crate_var_regressions, r=nrc 
Fix `$crate`-related regressions

Fixes #37345, fixes #37357, fixes #37352, and improves the `unused_extern_crates` lint.
r? @nrc
Loading status checks…
a7557e7

@bors bors closed this in #37361 Oct 26, 2016

@retep998

This comment has been minimized.

Sign in to view
Copy link
Member

retep998 commented Oct 27, 2016

Totally just got bitten by this in winapi, can't wait for the next nightly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.