Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upBeta cargo version needs to change #37969
Comments
alexcrichton
added
the
regression-from-stable-to-beta
label
Nov 23, 2016
alexcrichton
referenced this issue
Nov 23, 2016
Closed
cargo 0.15 depends on non-system /usr/local/opt/openssl on mac #3320
This comment has been minimized.
This comment has been minimized.
|
I like that option too. |
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this issue
Nov 24, 2016
xeonchen
pushed a commit
to xeonchen/gecko-cinnabar
that referenced
this issue
Nov 24, 2016
This comment has been minimized.
This comment has been minimized.
|
I don't understand what "Start release branches of Cargo now with the support from rust-lang/cargo#3239" means. What are release branches in this context and how does that solve the problem? |
This comment has been minimized.
This comment has been minimized.
|
I think you are saying create a new branch named "stable" (or something), based off some older commit, have it upload to s3, then backport whatever fixes we need. Then update rust-packaging to source cargo from those uploads instead of the nightlies. That sounds fine to me. I think we do need a release branch for cargo that we can backport to. |
This comment has been minimized.
This comment has been minimized.
|
If you do that, can you make Cargo not build with |
This comment has been minimized.
This comment has been minimized.
|
@brson oh yes sorry I mean creating Also yeah I think we could fix the |
This comment has been minimized.
This comment has been minimized.
|
I've opened rust-lang/cargo#3345 to explore release branches on Cargo. |
This was referenced Dec 1, 2016
bors
added a commit
to rust-lang/cargo
that referenced
this issue
Dec 1, 2016
brson
added
the
P-high
label
Dec 1, 2016
brson
assigned
alexcrichton
Dec 1, 2016
This comment has been minimized.
This comment has been minimized.
|
rust-lang/cargo#3353 is the first batch of backports for the Cargo associated with Rust 1.14.0 |
bors
added a commit
to rust-lang/cargo
that referenced
this issue
Dec 1, 2016
bors
added a commit
to rust-lang/cargo
that referenced
this issue
Dec 1, 2016
bors
added a commit
to rust-lang/cargo
that referenced
this issue
Dec 1, 2016
bors
added a commit
to rust-lang/cargo
that referenced
this issue
Dec 2, 2016
This comment has been minimized.
This comment has been minimized.
|
Next beta build will have a fixed Cargo, closing. |
alexcrichton commentedNov 23, 2016
Don't know a better place to file this where we can track it, so filing here.
Right now the Cargo tied to 1.14 beta suffers from rust-lang/cargo#3303, which we need to fix. This regression in required libraries was introduced by rust-lang/cargo#3272 and was later fixed by rust-lang/cargo#3311 and rust-lang/cargo#3315.
Beta's Cargo date is 2016-11-16, corresponding to rust-lang/cargo@a9c23dd and includes rust-lang/cargo#3272. The previous nightly, 2016-11-15, corresponds to rust-lang/cargo@9f1beaf which also includes rust-lang/cargo#3272. The previous successful nightly was 2016-11-09 which corresponds to rust-lang/cargo@5b5684e. Unfortunately that nightly does not contain rust-lang/cargo#3280 which is required for beta to bootstrap with rustbuild.
So we've got a few options:
My preference is to go with rust-lang/cargo#3239. @brson what do you think?