Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upThere are s3 addresses in the Rust 1.14 manifests #38519
Comments
brson
added
regression-from-stable-to-stable
T-tools
labels
Dec 21, 2016
This comment has been minimized.
This comment has been minimized.
|
The cargo tarballs mentioned in the manifest also don't have accompanying .asc signatures, which people expect as part of our release process. There are .sha256 files. Fortunately the cargo hashes are captured in the signed manifest. For this release I will go make the signatures and upload them to the cargo-builds s3 bucket by hand. cc @rillian |
This comment has been minimized.
This comment has been minimized.
|
Thanks @brson! I have a packaging script I use to upload new releases to the Firefox build infrastructure and it failed on the missing cargo signatures. Thanks also for pointing out that the manifest is signed; I'll add that as a verification step. |
This comment has been minimized.
This comment has been minimized.
|
I've deployed .asc files for the cargo builds and checked that the hashes match. |
This comment has been minimized.
This comment has been minimized.
|
Signature files are working now. |
This comment has been minimized.
This comment has been minimized.
|
@brson how serious is a regression is this? Is it something we should fix ASAP? Patch rustup ASAP? I don't currently have plans to fix this until we redo releases entirely, but we can prioritize a fix if it's causing active breakage. |
This comment has been minimized.
This comment has been minimized.
|
I'd like to fix before the next release. I think the fix as of now is in rust-buildbot. |
brson
self-assigned this
Dec 29, 2016
brson
added
the
P-high
label
Dec 29, 2016
This comment has been minimized.
This comment has been minimized.
|
I'm still on it. |
brson
referenced this issue
Jan 14, 2017
Merged
Copy cargo bins from rust-lang-ci to static-rust-lang-org #148
This comment has been minimized.
This comment has been minimized.
|
I've deployed a fix to production. We should expect tomorrow's nightly manifests to contain the right URLs. Leaving this open until I've confirmed it works in beta as well, since the code paths are slightly different. |
This comment has been minimized.
This comment has been minimized.
|
\o/ |
This comment has been minimized.
This comment has been minimized.
|
Nightly looks fixed. Still waiting to see a beta, and actually I want to wait until we get a new stable to close this, because that's the code path that's different. |
brson commentedDec 21, 2016
This is incorrect. Every address in the manifest should be from static.rust-lang.org. I don't want to make any guarantees that https://s3.amazonaws.com/rust-lang-ci/cargo-builds will always exist. I believe there is minor functionality in rustup that will break if the manifest contains multiple root URLs.