Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for reverting `cargo check` in Rust 1.15 #38666

Closed
alexcrichton opened this Issue Dec 28, 2016 · 3 comments

Comments

Assignees

@alexcrichton alexcrichton

Labels
P-high regression-from-stable-to-beta
Projects
None yet
Milestone
No milestone
1 participant
@alexcrichton
@alexcrichton
Copy link
Member

alexcrichton commented Dec 28, 2016 •
edited

This is a tracking issue for the tasks to revert cargo check and --crate-type=metadata in the Rust 1.15 release branch. currently --crate-type=metadata is on the beta branch of this repository and cargo check is itself in the rust-1.15.0 branch of the Cargo repository.

Unfortunately there have been a number of bugs associated with cargo check since first implemented:

All of these issues, however, should be fixed by these two changes:

We need to fix the issues on beta in one way or another, and today the tools team decided to go ahead and revert the changes on beta and let the bug fixes ride the trains to stable in the Rust 1.16 release. There's two things that need to happen to close out this issue:

@alexcrichton alexcrichton added P-high regression-from-stable-to-beta T-tools labels Dec 28, 2016

@alexcrichton alexcrichton self-assigned this Dec 28, 2016

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Dec 28, 2016

I'm tagging this as a regression to make sure we don't lose track of it, but to be clear there's not actually a regression here. Just want to piggy back off the processes that triage beta regressions!

alexcrichton added a commit to alexcrichton/cargo that referenced this issue Dec 28, 2016

@alexcrichton
Remove the `cargo check` subcommand from Rust 1.15 
This commit removes the `cargo check` subcommand from the `rust-1.15.0` branch
of Cargo. The rationale is explained in rust-lang/rust#38666, but the tl;dr; is
that it's relatively buggy and not ready to ride the trains to stable. This
commit takes as little an invasive as approach as possible by simply removing
the `cargo check` command and associated tests. The backend remains with support
for `cargo check`, but we shouldn't be exercising it in practice.
c9e7ec7

@alexcrichton alexcrichton referenced this issue Dec 28, 2016

Merged

Remove the `cargo check` subcommand from Rust 1.15 #3465

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Dec 28, 2016

cc @nrc

bors added a commit to rust-lang/cargo that referenced this issue Dec 28, 2016

@bors
Auto merge of #3465 - alexcrichton:remove-cargo-check, r=brson 
Remove the `cargo check` subcommand from Rust 1.15

This commit removes the `cargo check` subcommand from the `rust-1.15.0` branch
of Cargo. The rationale is explained in rust-lang/rust#38666, but the tl;dr; is
that it's relatively buggy and not ready to ride the trains to stable. This
commit takes as little an invasive as approach as possible by simply removing
the `cargo check` command and associated tests. The backend remains with support
for `cargo check`, but we shouldn't be exercising it in practice.
Loading status checks…
7b5bb38

bors added a commit to rust-lang/cargo that referenced this issue Dec 29, 2016

@bors
Auto merge of #3465 - alexcrichton:remove-cargo-check, r=brson 
Remove the `cargo check` subcommand from Rust 1.15

This commit removes the `cargo check` subcommand from the `rust-1.15.0` branch
of Cargo. The rationale is explained in rust-lang/rust#38666, but the tl;dr; is
that it's relatively buggy and not ready to ride the trains to stable. This
commit takes as little an invasive as approach as possible by simply removing
the `cargo check` command and associated tests. The backend remains with support
for `cargo check`, but we shouldn't be exercising it in practice.
Loading status checks…
bfee18f

@nrc nrc referenced this issue Dec 29, 2016

Merged

Remove --crate-type=metadata from beta #38668

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Dec 29, 2016

Ok, this should be done now, so closing.

@alexcrichton alexcrichton closed this Dec 29, 2016

@c410-f3r c410-f3r referenced this issue Jan 8, 2017

Closed

cargo check not working #151

@Wilfred Wilfred referenced this issue Feb 19, 2017

Open

rustc --test should not check linking when using --emit=metadata or -Z no-trans #39948

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.