Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impl AddAssign<char> for String #38784

Closed
Timmmm opened this Issue Jan 2, 2017 · 2 comments

Comments

Assignees
No one assigned
Labels
T-libs
Projects
None yet
Milestone
No milestone
3 participants
@Timmmm @Stebalien @Mark-Simulacrum
@Timmmm
Copy link

Timmmm commented Jan 2, 2017

Is there any reason there is an impl AddAssign<&str> for String, but not impl AddAssign<char>? Anyway it's something I would expect.
@Stebalien

This comment has been minimized.

Sign in to view
Copy link
Contributor

Stebalien commented Jan 3, 2017 •
edited

FYI, it was implemented for &str because there was already a stable implementation of Add<&str>. See #34890.

@Mark-Simulacrum Mark-Simulacrum added the T-libs label May 18, 2017

@Mark-Simulacrum

This comment has been minimized.

Sign in to view
Copy link
Member

Mark-Simulacrum commented May 18, 2017

Seems like something we shouldn't track, but would probably accept a PR for.

@Mark-Simulacrum Mark-Simulacrum closed this May 18, 2017

@LukasKalbertodt LukasKalbertodt referenced this issue Jun 29, 2018

Open

Adding `impl Add<char> for String` breaks code (adding an impl leads to breakage due to deref coercions) #51916

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.