Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

impl AddAssign<char> for String #38784

Closed
Timmmm opened this issue Jan 2, 2017 · 2 comments
Closed

impl AddAssign<char> for String #38784

Timmmm opened this issue Jan 2, 2017 · 2 comments
Labels
T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@Timmmm
Copy link
Contributor

Timmmm commented Jan 2, 2017

Is there any reason there is an impl AddAssign<&str> for String, but not impl AddAssign<char>? Anyway it's something I would expect.
@Stebalien
Copy link
Contributor

Stebalien commented Jan 3, 2017 •
edited
Loading

FYI, it was implemented for &str because there was already a stable implementation of Add<&str>. See #34890.

@Mark-Simulacrum Mark-Simulacrum added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label May 18, 2017
@Mark-Simulacrum
Copy link
Member

Seems like something we shouldn't track, but would probably accept a PR for.

@LukasKalbertodt LukasKalbertodt mentioned this issue Jun 29, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Stebalien @Timmmm @Mark-Simulacrum