Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upGet test suite working with wasm #38800
Comments
brson
added
A-testsuite
O-wasm
E-help-wanted
I-wrong
labels
Jan 3, 2017
This comment has been minimized.
This comment has been minimized.
|
This is still a critical wasm bug, and not a difficult one to fix. Run the test suite against the wasm target to see how it's currently broken. Most should simply be failing to load the wasm correctly. It should be possible to get verbose output from the test suite, then take that output and run the node.js test command by hand to figure out the correct invocation; then modify compiletest to do it correctly. |
This comment has been minimized.
This comment has been minimized.
|
I'm going to have a look at this but I make no promises so someone else who wants to take it should do so. |
This comment has been minimized.
This comment has been minimized.
|
OK my strategy is
I'm away for a few days so if this looks good I'll probably do it on wednesday :) |
This comment has been minimized.
This comment has been minimized.
|
Oh and I also had to pass "-s BINARYEN_METHOD='native-wasm,interpret-binary'" as it defaulted to just |
derekdreery
referenced this issue
May 17, 2017
Merged
Make compiletest set cwd before running js tests #42059
Mark-Simulacrum
added
the
C-enhancement
label
Jul 26, 2017
bors
added a commit
that referenced
this issue
Jul 26, 2017
Mark-Simulacrum
removed
the
I-wrong
label
Jul 28, 2017
This comment has been minimized.
This comment has been minimized.
|
I believe this has largely be done and can be verified with the containers in-tree, so closing. |
brson commentedJan 3, 2017
Last I looked compiletest could not deal with wasm as outputted today by rustc because the binaryen interpreter expects the wasm file to be located in a specific relative path that compiletest does not set up correctly.
I recall the fix being a matter of refactoring compiletest to pass certain paths down to the process spawning node.