Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mismatched types in extprim_literals-1.1.0, Rust 1.16 #38971

Closed
brson opened this Issue Jan 10, 2017 · 5 comments

Comments

Projects
None yet
2 participants
@brson
Copy link
Contributor

brson commented Jan 10, 2017

https://github.com/kennytm/extprim 39d117ce44388ecace80c03720ee492ecff8ef4e (the literals crate is a subdir)

Not on stable/beta.

101 brian@ip-10-145-43-250:~⟫ rustc +nightly -Vv
rustc 1.16.0-nightly (47c8d9fdc 2017-01-08)
binary: rustc
commit-hash: 47c8d9fdcf2e6502cf4ca7d7f059fdc1a2810afa
commit-date: 2017-01-08
host: x86_64-unknown-linux-gnu
release: 1.16.0-nightly
LLVM version: 3.9
brian@ip-10-145-43-250:~/dev/extprim/extprim_literals⟫ cargo +nightly test
   Compiling log v0.3.6
   Compiling bitflags v0.5.0
   Compiling semver v0.1.20
   Compiling unicode-xid v0.0.3
   Compiling libc v0.2.19
   Compiling winapi-build v0.1.1
   Compiling num-traits v0.1.36
   Compiling winapi v0.2.8
   Compiling rustc-serialize v0.3.22
   Compiling rustc_version v0.1.7
   Compiling kernel32-sys v0.2.2
   Compiling term v0.2.14
   Compiling rand v0.3.15
   Compiling extprim_literals v1.1.0 (file:///mnt2/dev/extprim/extprim_literals)
   Compiling extprim v1.1.1 (file:///mnt2/dev/extprim)
   Compiling syntex_syntax v0.36.0
   Compiling syntex v0.36.0
error[E0308]: mismatched types
   --> src/lib.rs:193:50
    |
193 |                     cx.expr_lit(sp, LitKind::Int(number.hi, U64_TYPE))
    |                                                  ^^^^^^^^^ expected u128, found u64

error[E0308]: mismatched types
   --> src/lib.rs:197:50
    |
197 |                     cx.expr_lit(sp, LitKind::Int(number.lo, U64_TYPE))
    |                                                  ^^^^^^^^^ expected u128, found u64

error[E0308]: mismatched types
   --> src/lib.rs:221:54
    |
221 |                         cx.expr_lit(sp, LitKind::Int(number.0.hi, U64_TYPE))
    |                                                      ^^^^^^^^^^^ expected u128, found u64

error[E0308]: mismatched types
   --> src/lib.rs:225:54
    |
225 |                         cx.expr_lit(sp, LitKind::Int(number.0.lo, U64_TYPE))
    |                                                      ^^^^^^^^^^^ expected u128, found u64

error: aborting due to 4 previous errors

error: Could not compile `extprim_literals`.

To learn more, run the command again with --verbose.
@brson

This comment has been minimized.

Copy link
Contributor Author

brson commented Jan 10, 2017

@sfackler

This comment has been minimized.

Copy link
Member

sfackler commented Jan 11, 2017

Looks like the crate is linking against libsyntax and hasn't been updated in a long time. Seems like we can close.

@brson

This comment has been minimized.

Copy link
Contributor Author

brson commented Jan 11, 2017

It links to synt_e_x, and this builds on stable. So something here changed. And since 128-bit ints are not stable I would not expect them to impact inference like this.

@sfackler

This comment has been minimized.

Copy link
Member

sfackler commented Jan 11, 2017

It does some build-time checking to automatically use libsyntax on nightly and syntex on stable: https://github.com/kennytm/extprim/blob/master/extprim_literals/src/lib.rs#L77-L81

@brson

This comment has been minimized.

Copy link
Contributor Author

brson commented Jan 12, 2017

Closing per @sfackler.

@brson brson closed this Jan 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.