Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo on beta needs updating to build Rust on master #39504

Closed
alexcrichton opened this Issue Feb 3, 2017 · 1 comment

Comments

Assignees

@alexcrichton alexcrichton

Labels
P-high regression-from-stable-to-beta
Projects
None yet
Milestone
  1.16.0
2 participants
@alexcrichton @brson
@alexcrichton
Copy link
Member

alexcrichton commented Feb 3, 2017

In #39463 I've opted due to not upgrade Cargo yet due to the errors preventing landing.

We need to track down what's causing this problem, land that change on Cargo master, then backport that change to rust-1.16.0 Cargo, and then update the Cargo used to bootstrap Rust on the master branch.

I'm tagging this as a regression as it's something we'll need to fix before the next release, and we shouldn't lose track of it!

@alexcrichton alexcrichton added the regression-from-stable-to-beta label Feb 3, 2017

@alexcrichton alexcrichton referenced this issue Feb 3, 2017

Merged

Bump version, upgrade bootstrap #39463

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Feb 3, 2017

So here's what I'm thinking is happening

  • Cargo emits $folder\deps\libcompiler_builtins-$hash.rlib
  • Cargo hard-links that to $folder\libcompiler_builtins.rlib
  • Rustbuild hard-links the former to $sysroot/lib/.../libcompiler_builtins-$hash.rlib
  • Later on we run cargo test
  • As part of cargo test's normal execution, it attempts to re-hard-link the $hash file to the non-deps file (the first two steps above)
  • Presumably some concurrent invocation of rustc has the library open (to read it)

This means that we're deleting a hard link where the actual file has a handle open to it elsewhere (opened through another link). Windows doesn't like this!

alexcrichton added a commit to alexcrichton/rust that referenced this issue Feb 4, 2017

@alexcrichton
rustbuild: Use copies instead of hard links 
The original motivation for hard links was to speed up the various stages of
rustbuild, but in the end this is causing problems on Windows (rust-lang#39504).

This commit tweaks the build system to use copies instead of hard links
unconditionally to ensure that the files accessed by Windows are always
disjoint.

Locally this added .3s to a noop build, so it shouldn't be too much of a
regression hopefully!
32e6c9f

@alexcrichton alexcrichton referenced this issue Feb 4, 2017

Merged

rustbuild: Use copies instead of hard links #39518

@brson brson added T-tools P-high labels Feb 9, 2017

@brson brson assigned alexcrichton Feb 9, 2017

bors added a commit that referenced this issue Feb 10, 2017

@bors
Auto merge of #39518 - alexcrichton:update-cargo, r=brson 
rustbuild: Use copies instead of hard links

The original motivation for hard links was to speed up the various stages of
rustbuild, but in the end this is causing problems on Windows (#39504).

This commit tweaks the build system to use copies instead of hard links
unconditionally to ensure that the files accessed by Windows are always
disjoint.

Locally this added .3s to a noop build, so it shouldn't be too much of a
regression hopefully!

Closes #39504
Loading status checks…
9658b3b

@brson brson modified the milestone: 1.16.0 Feb 11, 2017

@alexcrichton alexcrichton added this to the 1.16.0 milestone Feb 11, 2017

alexcrichton added a commit to alexcrichton/rust that referenced this issue Feb 16, 2017

@alexcrichton
rustbuild: Use copies instead of hard links 
The original motivation for hard links was to speed up the various stages of
rustbuild, but in the end this is causing problems on Windows (rust-lang#39504).

This commit tweaks the build system to use copies instead of hard links
unconditionally to ensure that the files accessed by Windows are always
disjoint.

Locally this added .3s to a noop build, so it shouldn't be too much of a
regression hopefully!
cf0fe01

alexcrichton added a commit to alexcrichton/rust that referenced this issue Mar 2, 2017

@alexcrichton
rustbuild: Use copies instead of hard links 
The original motivation for hard links was to speed up the various stages of
rustbuild, but in the end this is causing problems on Windows (rust-lang#39504).

This commit tweaks the build system to use copies instead of hard links
unconditionally to ensure that the files accessed by Windows are always
disjoint.

Locally this added .3s to a noop build, so it shouldn't be too much of a
regression hopefully!
1ecc019

bors added a commit that referenced this issue Mar 4, 2017

@bors
Auto merge of #39518 - alexcrichton:update-cargo, r=brson 
rustbuild: Use copies instead of hard links

The original motivation for hard links was to speed up the various stages of
rustbuild, but in the end this is causing problems on Windows (#39504).

This commit tweaks the build system to use copies instead of hard links
unconditionally to ensure that the files accessed by Windows are always
disjoint.

Locally this added .3s to a noop build, so it shouldn't be too much of a
regression hopefully!

Closes #39504
Loading status checks…
617b496

alexcrichton added a commit to alexcrichton/rust that referenced this issue Mar 6, 2017

@alexcrichton
rustbuild: Use copies instead of hard links 
The original motivation for hard links was to speed up the various stages of
rustbuild, but in the end this is causing problems on Windows (rust-lang#39504).

This commit tweaks the build system to use copies instead of hard links
unconditionally to ensure that the files accessed by Windows are always
disjoint.

Locally this added .3s to a noop build, so it shouldn't be too much of a
regression hopefully!
44bf3ec

bors added a commit that referenced this issue Mar 7, 2017

@bors
Auto merge of #39518 - alexcrichton:update-cargo, r=brson 
rustbuild: Use copies instead of hard links

The original motivation for hard links was to speed up the various stages of
rustbuild, but in the end this is causing problems on Windows (#39504).

This commit tweaks the build system to use copies instead of hard links
unconditionally to ensure that the files accessed by Windows are always
disjoint.

Locally this added .3s to a noop build, so it shouldn't be too much of a
regression hopefully!

Closes #39504
Loading status checks…
d8bef59

alexcrichton added a commit to alexcrichton/rust that referenced this issue Mar 7, 2017

@alexcrichton
rustbuild: Use copies instead of hard links 
The original motivation for hard links was to speed up the various stages of
rustbuild, but in the end this is causing problems on Windows (rust-lang#39504).

This commit tweaks the build system to use copies instead of hard links
unconditionally to ensure that the files accessed by Windows are always
disjoint.

Locally this added .3s to a noop build, so it shouldn't be too much of a
regression hopefully!
6d32add

bors added a commit that referenced this issue Mar 8, 2017

@bors
Auto merge of #39518 - alexcrichton:update-cargo, r=brson 
rustbuild: Use copies instead of hard links

The original motivation for hard links was to speed up the various stages of
rustbuild, but in the end this is causing problems on Windows (#39504).

This commit tweaks the build system to use copies instead of hard links
unconditionally to ensure that the files accessed by Windows are always
disjoint.

Locally this added .3s to a noop build, so it shouldn't be too much of a
regression hopefully!

Closes #39504
Loading status checks…
7044ba7

bors added a commit that referenced this issue Mar 8, 2017

@bors
Auto merge of #39518 - alexcrichton:update-cargo, r=brson 
rustbuild: Use copies instead of hard links

The original motivation for hard links was to speed up the various stages of
rustbuild, but in the end this is causing problems on Windows (#39504).

This commit tweaks the build system to use copies instead of hard links
unconditionally to ensure that the files accessed by Windows are always
disjoint.

Locally this added .3s to a noop build, so it shouldn't be too much of a
regression hopefully!

Closes #39504
Loading status checks…
d6d2116

bors added a commit that referenced this issue Mar 8, 2017

@bors
Auto merge of #39518 - alexcrichton:update-cargo, r=brson 
rustbuild: Use copies instead of hard links

The original motivation for hard links was to speed up the various stages of
rustbuild, but in the end this is causing problems on Windows (#39504).

This commit tweaks the build system to use copies instead of hard links
unconditionally to ensure that the files accessed by Windows are always
disjoint.

Locally this added .3s to a noop build, so it shouldn't be too much of a
regression hopefully!

Closes #39504
Loading status checks…
9dd81e1

bors added a commit that referenced this issue Mar 8, 2017

@bors
Auto merge of #39518 - alexcrichton:update-cargo, r=brson 
rustbuild: Use copies instead of hard links

The original motivation for hard links was to speed up the various stages of
rustbuild, but in the end this is causing problems on Windows (#39504).

This commit tweaks the build system to use copies instead of hard links
unconditionally to ensure that the files accessed by Windows are always
disjoint.

Locally this added .3s to a noop build, so it shouldn't be too much of a
regression hopefully!

Closes #39504
Loading status checks…
443818e

bors added a commit that referenced this issue Mar 9, 2017

@bors
Auto merge of #39518 - alexcrichton:update-cargo, r=brson 
rustbuild: Use copies instead of hard links

The original motivation for hard links was to speed up the various stages of
rustbuild, but in the end this is causing problems on Windows (#39504).

This commit tweaks the build system to use copies instead of hard links
unconditionally to ensure that the files accessed by Windows are always
disjoint.

Locally this added .3s to a noop build, so it shouldn't be too much of a
regression hopefully!

Closes #39504
Loading status checks…
fb2f1f4

bors added a commit that referenced this issue Mar 9, 2017

@bors
Auto merge of #39518 - alexcrichton:update-cargo, r=brson 
rustbuild: Use copies instead of hard links

The original motivation for hard links was to speed up the various stages of
rustbuild, but in the end this is causing problems on Windows (#39504).

This commit tweaks the build system to use copies instead of hard links
unconditionally to ensure that the files accessed by Windows are always
disjoint.

Locally this added .3s to a noop build, so it shouldn't be too much of a
regression hopefully!

Closes #39504
Loading status checks…
bb28f94

bors added a commit that referenced this issue Mar 9, 2017

@bors
Auto merge of #39518 - alexcrichton:update-cargo, r=alexcrichton 
rustbuild: Use copies instead of hard links

The original motivation for hard links was to speed up the various stages of
rustbuild, but in the end this is causing problems on Windows (#39504).

This commit tweaks the build system to use copies instead of hard links
unconditionally to ensure that the files accessed by Windows are always
disjoint.

Locally this added .3s to a noop build, so it shouldn't be too much of a
regression hopefully!

Closes #39504
Loading status checks…
46ebda5

alexcrichton added a commit to alexcrichton/rust that referenced this issue Mar 9, 2017

@alexcrichton
rustbuild: Use copies instead of hard links 
The original motivation for hard links was to speed up the various stages of
rustbuild, but in the end this is causing problems on Windows (rust-lang#39504).

This commit tweaks the build system to use copies instead of hard links
unconditionally to ensure that the files accessed by Windows are always
disjoint.

Locally this added .3s to a noop build, so it shouldn't be too much of a
regression hopefully!
3be02fc

bors added a commit that referenced this issue Mar 9, 2017

@bors
Auto merge of #39518 - alexcrichton:update-cargo, r=alexcrichton 
rustbuild: Use copies instead of hard links

The original motivation for hard links was to speed up the various stages of
rustbuild, but in the end this is causing problems on Windows (#39504).

This commit tweaks the build system to use copies instead of hard links
unconditionally to ensure that the files accessed by Windows are always
disjoint.

Locally this added .3s to a noop build, so it shouldn't be too much of a
regression hopefully!

Closes #39504
Loading status checks…
5106190

bors added a commit that referenced this issue Mar 9, 2017

@bors
Auto merge of #39518 - alexcrichton:update-cargo, r=alexcrichton 
rustbuild: Use copies instead of hard links

The original motivation for hard links was to speed up the various stages of
rustbuild, but in the end this is causing problems on Windows (#39504).

This commit tweaks the build system to use copies instead of hard links
unconditionally to ensure that the files accessed by Windows are always
disjoint.

Locally this added .3s to a noop build, so it shouldn't be too much of a
regression hopefully!

Closes #39504
Loading status checks…
dc20930

bors added a commit that referenced this issue Mar 9, 2017

@bors
Auto merge of #39518 - alexcrichton:update-cargo, r=alexcrichton 
rustbuild: Use copies instead of hard links

The original motivation for hard links was to speed up the various stages of
rustbuild, but in the end this is causing problems on Windows (#39504).

This commit tweaks the build system to use copies instead of hard links
unconditionally to ensure that the files accessed by Windows are always
disjoint.

Locally this added .3s to a noop build, so it shouldn't be too much of a
regression hopefully!

Closes #39504
Loading status checks…
e4424a8

bors added a commit that referenced this issue Mar 10, 2017

@bors
Auto merge of #39518 - alexcrichton:update-cargo, r=arielb1 
rustbuild: Use copies instead of hard links

The original motivation for hard links was to speed up the various stages of
rustbuild, but in the end this is causing problems on Windows (#39504).

This commit tweaks the build system to use copies instead of hard links
unconditionally to ensure that the files accessed by Windows are always
disjoint.

Locally this added .3s to a noop build, so it shouldn't be too much of a
regression hopefully!

Closes #39504
Loading status checks…
a625e03

bors added a commit that referenced this issue Mar 10, 2017

@bors
Auto merge of #39518 - alexcrichton:update-cargo, r=arielb1 
rustbuild: Use copies instead of hard links

The original motivation for hard links was to speed up the various stages of
rustbuild, but in the end this is causing problems on Windows (#39504).

This commit tweaks the build system to use copies instead of hard links
unconditionally to ensure that the files accessed by Windows are always
disjoint.

Locally this added .3s to a noop build, so it shouldn't be too much of a
regression hopefully!

Closes #39504
Loading status checks…
2485800

bors added a commit that referenced this issue Mar 10, 2017

@bors
Auto merge of #39518 - alexcrichton:update-cargo, r=arielb1 
rustbuild: Use copies instead of hard links

The original motivation for hard links was to speed up the various stages of
rustbuild, but in the end this is causing problems on Windows (#39504).

This commit tweaks the build system to use copies instead of hard links
unconditionally to ensure that the files accessed by Windows are always
disjoint.

Locally this added .3s to a noop build, so it shouldn't be too much of a
regression hopefully!

Closes #39504
Loading status checks…
d538fcf

bors added a commit that referenced this issue Mar 10, 2017

@bors
Auto merge of #39518 - alexcrichton:update-cargo, r=arielb1 
rustbuild: Use copies instead of hard links

The original motivation for hard links was to speed up the various stages of
rustbuild, but in the end this is causing problems on Windows (#39504).

This commit tweaks the build system to use copies instead of hard links
unconditionally to ensure that the files accessed by Windows are always
disjoint.

Locally this added .3s to a noop build, so it shouldn't be too much of a
regression hopefully!

Closes #39504
Loading status checks…
f573db4

alexcrichton added a commit to alexcrichton/rust that referenced this issue Mar 10, 2017

@alexcrichton
Rollup merge of rust-lang#39518 - alexcrichton:update-cargo, r=arielb1 
rustbuild: Use copies instead of hard links

The original motivation for hard links was to speed up the various stages of
rustbuild, but in the end this is causing problems on Windows (rust-lang#39504).

This commit tweaks the build system to use copies instead of hard links
unconditionally to ensure that the files accessed by Windows are always
disjoint.

Locally this added .3s to a noop build, so it shouldn't be too much of a
regression hopefully!

Closes rust-lang#39504
1c0daa5

@bors bors closed this in #39518 Mar 10, 2017

alexcrichton added a commit to alexcrichton/rust that referenced this issue Sep 2, 2017

@alexcrichton
rustbuild: Switch back to using hard links 
The `copy` function historically in rustbuild used hard links to speed up the
copy operations that it does. This logic was backed out, however, in rust-lang#39518 due
to a bug that only showed up on Windows, described in rust-lang#39504. The cause
described in rust-lang#39504 happened because Cargo, on a fresh build, would overwrite
the previous artifacts with new hard links that Cargo itself manages.

This behavior in Cargo was fixed in rust-lang/cargo#4390 where it no longer
should overwrite files on fresh builds, opportunistically leaving the filesystem
intact and not touching it.

Hopefully this can help speed up local builds by doing fewer copies all over the
place!
Loading status checks…
53f6404

@alexcrichton alexcrichton referenced this issue Sep 2, 2017

Merged

rustbuild: Switch back to using hard links #44260

bors added a commit that referenced this issue Sep 2, 2017

@bors
Auto merge of #44260 - alexcrichton:hardlink-no-copy, r=Mark-Simulacrum 
rustbuild: Switch back to using hard links

The `copy` function historically in rustbuild used hard links to speed up the
copy operations that it does. This logic was backed out, however, in #39518 due
to a bug that only showed up on Windows, described in #39504. The cause
described in #39504 happened because Cargo, on a fresh build, would overwrite
the previous artifacts with new hard links that Cargo itself manages.

This behavior in Cargo was fixed in rust-lang/cargo#4390 where it no longer
should overwrite files on fresh builds, opportunistically leaving the filesystem
intact and not touching it.

Hopefully this can help speed up local builds by doing fewer copies all over the
place!
Loading status checks…
3bc47ab

alexcrichton added a commit to alexcrichton/rust that referenced this issue Sep 6, 2017

@alexcrichton
rustbuild: Switch back to using hard links 
The `copy` function historically in rustbuild used hard links to speed up the
copy operations that it does. This logic was backed out, however, in rust-lang#39518 due
to a bug that only showed up on Windows, described in rust-lang#39504. The cause
described in rust-lang#39504 happened because Cargo, on a fresh build, would overwrite
the previous artifacts with new hard links that Cargo itself manages.

This behavior in Cargo was fixed in rust-lang/cargo#4390 where it no longer
should overwrite files on fresh builds, opportunistically leaving the filesystem
intact and not touching it.

Hopefully this can help speed up local builds by doing fewer copies all over the
place!
Loading status checks…
f74711e

alexcrichton added a commit to alexcrichton/rust that referenced this issue Sep 9, 2017

@alexcrichton
rustbuild: Switch back to using hard links 
The `copy` function historically in rustbuild used hard links to speed up the
copy operations that it does. This logic was backed out, however, in rust-lang#39518 due
to a bug that only showed up on Windows, described in rust-lang#39504. The cause
described in rust-lang#39504 happened because Cargo, on a fresh build, would overwrite
the previous artifacts with new hard links that Cargo itself manages.

This behavior in Cargo was fixed in rust-lang/cargo#4390 where it no longer
should overwrite files on fresh builds, opportunistically leaving the filesystem
intact and not touching it.

Hopefully this can help speed up local builds by doing fewer copies all over the
place!
Loading status checks…
71318a6

bors added a commit that referenced this issue Sep 9, 2017

@bors
Auto merge of #44260 - alexcrichton:hardlink-no-copy, r=Mark-Simulacrum 
rustbuild: Switch back to using hard links

The `copy` function historically in rustbuild used hard links to speed up the
copy operations that it does. This logic was backed out, however, in #39518 due
to a bug that only showed up on Windows, described in #39504. The cause
described in #39504 happened because Cargo, on a fresh build, would overwrite
the previous artifacts with new hard links that Cargo itself manages.

This behavior in Cargo was fixed in rust-lang/cargo#4390 where it no longer
should overwrite files on fresh builds, opportunistically leaving the filesystem
intact and not touching it.

Hopefully this can help speed up local builds by doing fewer copies all over the
place!
Loading status checks…
ab0b919

alexcrichton added a commit to alexcrichton/rust that referenced this issue Sep 10, 2017

@alexcrichton
rustbuild: Switch back to using hard links 
The `copy` function historically in rustbuild used hard links to speed up the
copy operations that it does. This logic was backed out, however, in rust-lang#39518 due
to a bug that only showed up on Windows, described in rust-lang#39504. The cause
described in rust-lang#39504 happened because Cargo, on a fresh build, would overwrite
the previous artifacts with new hard links that Cargo itself manages.

This behavior in Cargo was fixed in rust-lang/cargo#4390 where it no longer
should overwrite files on fresh builds, opportunistically leaving the filesystem
intact and not touching it.

Hopefully this can help speed up local builds by doing fewer copies all over the
place!
Loading status checks…
38bedfa

bors added a commit that referenced this issue Sep 10, 2017

@bors
Auto merge of #44260 - alexcrichton:hardlink-no-copy, r=Mark-Simulacrum 
rustbuild: Switch back to using hard links

The `copy` function historically in rustbuild used hard links to speed up the
copy operations that it does. This logic was backed out, however, in #39518 due
to a bug that only showed up on Windows, described in #39504. The cause
described in #39504 happened because Cargo, on a fresh build, would overwrite
the previous artifacts with new hard links that Cargo itself manages.

This behavior in Cargo was fixed in rust-lang/cargo#4390 where it no longer
should overwrite files on fresh builds, opportunistically leaving the filesystem
intact and not touching it.

Hopefully this can help speed up local builds by doing fewer copies all over the
place!
Loading status checks…
6d445e1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.