New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect whitespace check in comment parser #3970

Closed
brson opened this Issue Nov 14, 2012 · 3 comments

Comments

Projects
None yet
3 participants
@brson
Contributor

brson commented Nov 14, 2012

comments.rs contains this:

fn all_whitespace(s: ~str, begin: uint, end: uint) -> bool {                                                                                                                                                         
    let mut i: uint = begin;                                                                                                                                                                                         
    while i != end {                                                                                                                                                                                                 
        if !is_whitespace(s[i] as char) { return false; } i += 1u;                                                                                                                                                   
    }                                                                                                                                                                                                                
    return true;                                                                                                                                                                                                     
}    

Doing a bytewise conversion to chars is not right.

@pnkfelix

This comment has been minimized.

Show comment
Hide comment
@pnkfelix

pnkfelix Mar 25, 2013

Member

Not critical for 0.6; de-milestoning

Member

pnkfelix commented Mar 25, 2013

Not critical for 0.6; de-milestoning

@catamorphism

This comment has been minimized.

Show comment
Hide comment
@catamorphism

catamorphism May 23, 2013

Contributor

far-future

Contributor

catamorphism commented May 23, 2013

far-future

@brson

This comment has been minimized.

Show comment
Hide comment
@brson

brson Jul 20, 2013

Contributor

Fixed.

Contributor

brson commented Jul 20, 2013

Fixed.

@brson brson closed this Jul 20, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment