Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAdjust release process tagging #39731
Comments
brson
added
A-infrastructure
P-high
labels
Feb 11, 2017
brson
added this to the 1.16.0 milestone
Feb 11, 2017
brson
self-assigned this
Feb 11, 2017
This comment has been minimized.
This comment has been minimized.
|
@steveklabnik This issue is mostly about thanks.rlo. The issue at hand is that we can't make the tag until after the release, so we need a different way to tell thanks about the commit. I'd suggest we just use a temporary |
This comment has been minimized.
This comment has been minimized.
|
i wonder if we could use the branch for thanks pre-release, maybe that'd work? really it's about a version ref more than a literal tag |
This comment has been minimized.
This comment has been minimized.
|
Yeah that's fine. Whatever is easiest for thanks. If you can tell it to load data for 1.16 from the 'stable' branch that would require nothing on the Rust side. |
This comment has been minimized.
This comment has been minimized.
|
I can, it'd require modifying some things, but it is easier and cleaner than a special tag for thanks. |
brson
closed this
Mar 23, 2017
This comment has been minimized.
This comment has been minimized.
|
Thanks has been fixed; we can build off of the |
brson commentedFeb 11, 2017
We need to generate thanks.rlo before the release, but the way we did it this time, by tagging prior to releasing is incorrect. Need a different way.