Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust release process tagging #39731

Closed
brson opened this issue Feb 11, 2017 · 5 comments
Closed

Adjust release process tagging #39731

brson opened this issue Feb 11, 2017 · 5 comments
Assignees
Labels
P-high High priority
Milestone

Comments

@brson
Copy link
Contributor

brson commented Feb 11, 2017

We need to generate thanks.rlo before the release, but the way we did it this time, by tagging prior to releasing is incorrect. Need a different way.

@brson brson added this to the 1.16.0 milestone Feb 11, 2017
@brson brson self-assigned this Feb 11, 2017
@brson
Copy link
Contributor Author

brson commented Mar 2, 2017

@steveklabnik This issue is mostly about thanks.rlo. The issue at hand is that we can't make the tag until after the release, so we need a different way to tell thanks about the commit. I'd suggest we just use a temporary thanks-1.16.0 tag, which would mean thanks probably needs some logic to use either the real tag or the thanks tag.

@steveklabnik
Copy link
Member

steveklabnik commented Mar 2, 2017

i wonder if we could use the branch for thanks pre-release, maybe that'd work?

really it's about a version ref more than a literal tag

@brson
Copy link
Contributor Author

brson commented Mar 2, 2017

Yeah that's fine. Whatever is easiest for thanks. If you can tell it to load data for 1.16 from the 'stable' branch that would require nothing on the Rust side.

@steveklabnik
Copy link
Member

I can, it'd require modifying some things, but it is easier and cleaner than a special tag for thanks.

@brson brson closed this as completed Mar 23, 2017
@steveklabnik
Copy link
Member

Thanks has been fixed; we can build off of the stable branch when making a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-high High priority
Projects
None yet
Development

No branches or pull requests

2 participants