ipnetwork-0.12.1 doesn't build on 1.16 beta #39807

Closed
brson opened this Issue Feb 14, 2017 · 4 comments

Projects

None yet

5 participants

@brson
Contributor
brson commented Feb 14, 2017
   Doc-tests ipnetwork

running 11 tests
test IpNetwork::ip_0 ... FAILED
test IpNetwork::prefix_0 ... ok
test ipv4::Ipv4Network::contains_0 ... ok
test ipv4::Ipv4Network::broadcast_0 ... ok
test ipv4::Ipv4Network::mask_0 ... ok
test ipv4::Ipv4Network::network_0 ... ok
test ipv4::Ipv4Network::size_0 ... ok
test ipv4::Ipv4Network::nth_0 ... ok
test ipv4::Ipv4Network_0 ... ok
test ipv6::Ipv6Network::contains_0 ... ok
test ipv6::Ipv6Network::mask_0 ... ok

failures:

---- IpNetwork::ip_0 stdout ----
        error[E0284]: type annotations required: cannot resolve `<_ as std::str::FromStr>::Err == _`
 --> <anon>:6:77
  |
6 | assert_eq!(IpNetwork::V4("10.9.0.32/16".parse().unwrap()).ip(), "10.9.0.32".parse().unwrap());
  |                                                                             ^^^^^

error: aborting due to previous error(s)

thread 'rustc' panicked at 'Box<Any>', /buildslave/rust-buildbot/slave/beta-dist-rustc-linux/build/src/librustc/session/mod.rs:203
note: Run with `RUST_BACKTRACE=1` for a backtrace.


failures:
    IpNetwork::ip_0

test result: FAILED. 10 passed; 1 failed; 0 ignored; 0 measured

error: test failed

Works on 1.15.

cc @achanda

@nagisa
Contributor
nagisa commented Feb 14, 2017

There has been a large number of From implementations around the IpAddr/Ipv4Addr/Ipv6Addr/SocketAddr. Those are likely the reason this code does not compile anymore and such breakage is not considered a breaking change.

Actionable items: send a PR to the crate or inform the crate author via an issue.

@achanda achanda referenced this issue in achanda/ipnetwork Feb 14, 2017
Open

Doc tests fail with rustc 1.16 beta 1 #37

@achanda
Contributor
achanda commented Feb 14, 2017

Thanks for finding this!

@arielb1
Contributor
arielb1 commented Feb 16, 2017

Looks like XIB (aka expected inference breakage). Assigning to T-libs.

@arielb1 arielb1 added the T-libs label Feb 16, 2017
@alexcrichton
Member

I believe this is a dupe of #39825, caused by #38464, so closing in favor of #39825.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment