Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple crates can't find pkg_config in 1.17 #40183

Closed
brson opened this Issue Mar 1, 2017 · 10 comments

Comments

Projects
None yet
6 participants
@brson
Copy link
Contributor

brson commented Mar 1, 2017

due to: rust-lang/cargo#3361

  • rusqlite-0.7.3 -- can't find crate for pkg_config
  • schemamama_rusqlite-0.5.0 -- can't find crate for pkg_config
  • sphinxad-0.1.1 -- can't find crate for pkg_config
  • sphinxad-sys-0.1.2 -- can't find crate for pkg_config

cc @jgallagher @TrionProg

@brson

This comment has been minimized.

@jgallagher

This comment has been minimized.

Copy link
Contributor

jgallagher commented Mar 1, 2017

This has been fixed in later releases of rusqlite (specifically >= 0.9.0). Is proper crates.io hygiene to go back and publish point releases that fix this for older versions? If so, how far back should I go?

@nikomatsakis

This comment has been minimized.

Copy link
Contributor

nikomatsakis commented Mar 2, 2017

@jgallagher what was the problem exactly?

And, I would say it is very kind of you to upgrade your point releases, definitely! The question of how far back to go is a good one. In this case, the problem is that some dependency likes 0.7.3, which is something you can't easily control...

@jgallagher

This comment has been minimized.

Copy link
Contributor

jgallagher commented Mar 2, 2017

@nikomatsakis No problem exactly - there was just a leftover build.rs at the project root that got committed by accident a long time ago. I don't think it was ever referenced by the project or Cargo.toml, but the changes to Cargo linked above made it problematic.

If https://crates.io/crates/rusqlite/reverse_dependencies is the right picture, looks like I should update back to 0.6.x?

@jgallagher

This comment has been minimized.

Copy link
Contributor

jgallagher commented Mar 2, 2017

@brson I pushed rusqlite 0.6.1, 0.7.4, and 0.8.1 which should fix this. 0.9 and up was already fixed.

@TrionProg

This comment has been minimized.

Copy link

TrionProg commented Mar 2, 2017

Hello, am author of sphinxad.

I (and not just me) have made something and this is fixed in new version(0.1.2). But where are examples. Each is cargo project.
Dependency in Cargo.toml is sphinxad = "*"

  • If I run with nighlty 1.17, It downloads sphinxad 0.1.0 and all works(0.1.0 has no build.rs file)
  • But if I change to sphinxad="0.1.2", I get error failed to select a version for pkg-config.
  • Bit if I crate new project with sphinxad = "*", it downloads 0.1.2 and all works perfect.

Why cargo do it? How to fix it?

@steveklabnik steveklabnik self-assigned this Mar 9, 2017

@brson

This comment has been minimized.

Copy link
Contributor Author

brson commented Mar 9, 2017

Seems like this is expected breakage and we just need to help people adapt.

@steveklabnik

This comment has been minimized.

Copy link
Member

steveklabnik commented Mar 9, 2017

I'll look at sending PRs to these crates.

@steveklabnik

This comment has been minimized.

Copy link
Member

steveklabnik commented Mar 9, 2017

So for these four crates:

  • rusqlite-0.7.3: looks like @jgallagher has it handled.
  • schemamama_rusqlite-0.5.0 this failed because of rusqlite0.6, and now pulls in 0.6.1, as it had a ^ dependency, so it's good to go.
  • sphinxad-0.1.1 @TrionProg's comment above seems strange; @alexcrichton, maybe you know what's going on? It seems odd that 0.1.2 works in one context and not another.
  • sphinxad-sys-0.1.2 see above
@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented Mar 9, 2017

@TrionProg sorry for the slow response! It looks like you've already taken care of this and it looks like you've also published, so I don't think there's anything left to be done!

@TrionProg if you're still having trouble locally, could you gist the full error you're seeing and I'll help you debug?

marado added a commit to marado/tendrils that referenced this issue Mar 18, 2019

Update dependencies
This cargo was uninstalable since rust 1.17, due to
rust-lang/rust#40183 .

This patch bumps the dependencies just enough to be able to avoid
this issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.