Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upRustdoc sidebar style change negatively impacts `src` view #40724
Comments
steveklabnik
added
T-rustdoc
regression-from-stable-to-beta
labels
Mar 22, 2017
This comment has been minimized.
This comment has been minimized.
|
This is also broken on beta, tagging as such. |
This comment has been minimized.
This comment has been minimized.
|
I'm looking into this. I see three potential options:
I'm leaning toward option 1 for now but I think option 2 might be worth considering in the future. Thoughts? |
This comment has been minimized.
This comment has been minimized.
|
While I am certainly not the most qualified to weigh in on this, my thoughts would be that 3 is less than desirable (having a random grey stripe on the left side looks out-of-place regardless of whether the color matches or not), 2 would unnecessarily decrease the usability of 3 would also mean that the code block would have padding on the right side but no padding on the left. |
This comment has been minimized.
This comment has been minimized.
|
1 seems good |
This comment has been minimized.
This comment has been minimized.
|
Ok. Option 1 it is! |
Cldfire commentedMar 22, 2017
•
edited
What it looks like on nightly docs:
The strange color change on the side with the new sidebar style looks kind of tacky (especially at the bottom) and was probably not intended.
Currently on stable docs: