Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for the FromUtf8Error::as_bytes #40895

Closed
3Hren opened this Issue Mar 29, 2017 · 9 comments

Comments

Assignees
No one assigned
Labels
B-unstable C-tracking-issue T-libs final-comment-period
Projects
None yet
Milestone
No milestone
8 participants
@3Hren @Mark-Simulacrum @sfackler @rfcbot @ErichDonGubler @SimonSapin @alexcrichton @aturon
@3Hren
Copy link
Contributor

3Hren commented Mar 29, 2017

Added in #40290 under the from_utf8_error_as_bytes feature flag.

@aturon aturon added B-unstable T-libs labels Mar 29, 2017

@Mark-Simulacrum Mark-Simulacrum added the C-tracking-issue label Jul 22, 2017

@Mark-Simulacrum

This comment has been minimized.

Sign in to view
Copy link
Member

Mark-Simulacrum commented Jan 17, 2018

@rust-lang/libs Nominating for stabilization. Seems like a good addition with no (known) blockers.

@Mark-Simulacrum Mark-Simulacrum added the I-nominated label Jan 17, 2018

@sfackler

This comment has been minimized.

Sign in to view
Copy link
Member

sfackler commented Jan 18, 2018

@rfcbot fcp merge

@rfcbot rfcbot added the proposed-final-comment-period label Jan 18, 2018

@rfcbot

This comment has been minimized.

Sign in to view
Copy link

rfcbot commented Jan 18, 2018 •
edited by Kimundi

Team member @sfackler has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once these reviewers reach consensus, this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@alexcrichton alexcrichton removed the I-nominated label Jan 23, 2018

@rfcbot

This comment has been minimized.

Sign in to view
Copy link

rfcbot commented Jan 23, 2018

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot added final-comment-period and removed proposed-final-comment-period labels Jan 23, 2018

@rfcbot

This comment has been minimized.

Sign in to view
Copy link

rfcbot commented Jan 23, 2018

🔔 This is now entering its final comment period, as per the review above. 🔔
1 similar comment
@rfcbot

This comment has been minimized.

Sign in to view
Copy link

rfcbot commented Jan 23, 2018

🔔 This is now entering its final comment period, as per the review above. 🔔
@rfcbot

This comment has been minimized.

Sign in to view
Copy link

rfcbot commented Feb 2, 2018

The final comment period is now complete.

varkor added a commit to varkor/rust that referenced this issue Mar 17, 2018

@varkor
Stabilise FromUtf8Error::as_bytes 
Closes rust-lang#40895.
b57ea56

@varkor varkor referenced this issue Mar 17, 2018

Merged

Stabilise FromUtf8Error::as_bytes #49121

@ErichDonGubler

This comment has been minimized.

Sign in to view
Copy link

ErichDonGubler commented Mar 19, 2018

How does one contribute after the FCP has gone through for stabilization? I'm not familiar with it and want to learn. :) Is that something the community contributes, or do we have a big stabilization PR like this one?
@SimonSapin

This comment has been minimized.

Sign in to view
Copy link
Contributor

SimonSapin commented Mar 19, 2018

Both are possible. In this case I see that #49121 has already been submitted.

alexcrichton added a commit to alexcrichton/rust that referenced this issue Mar 23, 2018

@alexcrichton
Rollup merge of rust-lang#49121 - varkor:stabilise-from_utf8_error_as… 
…_bytes, r=bluss

Stabilise FromUtf8Error::as_bytes

Closes rust-lang#40895.
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
59b5887

kennytm added a commit to kennytm/rust that referenced this issue Mar 24, 2018

@kennytm
Rollup merge of rust-lang#49121 - varkor:stabilise-from_utf8_error_as… 
…_bytes, r=bluss

Stabilise FromUtf8Error::as_bytes

Closes rust-lang#40895.
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
9087282

kennytm added a commit to kennytm/rust that referenced this issue Mar 24, 2018

@kennytm
Rollup merge of rust-lang#49121 - varkor:stabilise-from_utf8_error_as… 
…_bytes, r=bluss

Stabilise FromUtf8Error::as_bytes

Closes rust-lang#40895.
Verified
This commit was signed with a verified signature.
@kennytm kennytm
GPG key ID: FEF6C8051D0E013C Learn about signing commits
cd9981c

kennytm added a commit to kennytm/rust that referenced this issue Mar 24, 2018

@kennytm
Rollup merge of rust-lang#49121 - varkor:stabilise-from_utf8_error_as… 
…_bytes, r=bluss

Stabilise FromUtf8Error::as_bytes

Closes rust-lang#40895.
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
adb7984

@bors bors closed this in #49121 Mar 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.