beta regression: assembunny-plus 0.0.3

[alexcrichton]

The assembunny-plus crate has regressed on beta:

   Compiling assembunny_plus v0.0.3 (file:///home/alex/code/assembunny-plus)
error: borrowed value does not live long enough
   --> src/parser.rs:309:98
    |
309 |     let mut output: Vec<Token> = vec![Token::new(TokenType::KEYWORD, index_of(&KEYWORD_INDEX, &&*str_toks[0].to_lowercase()).unwrap() as i32)];
    |                                                                                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^                   - temporary value only lives until here
    |                                                                                                  |
    |                                                                                                  does not live long enough
    |
    = note: borrowed value must be valid for the static lifetime...
    = note: consider using a `let` binding to increase its lifetime

error: aborting due to previous error

error: Could not compile `assembunny_plus`.

To learn more, run the command again with --verbose.

cc @broad-well

broad-well/assembunny-plus@4ed0f0d

rustc 1.17.0-beta.2 (b7c276653 2017-03-20)
binary: rustc
commit-hash: b7c27665307704a9b158fe242e88e83914029415
commit-date: 2017-03-20
host: x86_64-unknown-linux-gnu
release: 1.17.0-beta.2
LLVM version: 3.9

[nikomatsakis]

OK, I did some digging around. I believe this regression is a bug. Here is a minimal test case:

const FOO: [&'static str; 1] = ["foo"];

fn find<T: PartialEq>(t: &[T], element: &T) { }

fn main() {
    let x = format!("hi");
    find(&FOO, &&*x);
}

Specifically what is happening is that we used to infer the T in find to &'x str for some 'x, but we now infer it to &'static str. I suspect this is related to the soundness fix around unsized coercions. You can make the code compile in various ways, e.g. find::<&str> or &FOO[..], all of which kind of sidestep that aspect of type inference.

cc @eddyb

[nikomatsakis]

(Nominating for compiler team triage -- I can't attend mtg this week, but suggest P-high.)

[eddyb]

There should be enough subtyping to make that work, I'm not sure where it goes wrong. It's broken on nightly too, right?

[nikomatsakis]

This is actually #18653. I will see about fixing that.

[nikomatsakis]

I'm going to mark this as P-high and assign myself. I am investigating.

[nikomatsakis]

triage: P-high

[pnkfelix]

assigning niko to hold him to his earlier comment. 😄

[brson]

Backports are best in by this friday, next thursday is the absolute deadline. cc @nikomatsakis

[nikomatsakis]

@brson working on it :)

[nikomatsakis]

OK, this is fixed be #40570, but I think I also have a more tailored fix that we can backport to beta.

[nikomatsakis]

Status:

• Fixed on nightly through #40570
• Pending PR for beta (#41269) but it is unclear if it makes sense to backport, since the changes are non-trivial, and the impact is not huge. (One crate that I am aware of.)

[nikomatsakis]

After discussion in the @rust-lang/compiler meeting, we decided not to backport the fix for this to beta, as it is non-trivial. The problem is fixed on nightly, and I'll offer a patch to the assembunny crate.

[alexcrichton]

Looks fixed on nightly in assembunny-plus as well, and due to decision to not backport closing.

Thanks for the fixes @nikomatsakis!