Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for 'more_io_inner_methods' #41519

Closed
SergioBenitez opened this Issue Apr 24, 2017 · 6 comments

Comments

Assignees
No one assigned
Labels
B-unstable T-libs final-comment-period
Projects
None yet
Milestone
No milestone
3 participants
@SergioBenitez @alexcrichton @rfcbot
@SergioBenitez
Copy link
Contributor

SergioBenitez commented Apr 24, 2017

Feature was added in #41463, resolving #29067.

This feature enables several internal accessor methods on structures in std::io including Take::{get_ref, get_mut} and Chain::{into_inner, get_ref, get_mut}.

cc @alexcrichton

@alexcrichton alexcrichton added B-unstable T-libs labels Apr 25, 2017

@SergioBenitez SergioBenitez referenced this issue May 19, 2017

Open

Compile with stable Rust #19

8 of 13 tasks complete
@SergioBenitez

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

SergioBenitez commented Jun 3, 2017

I'd like to propose that this be stabilized for 1.20. The added methods are rather uncontroversial: they simply expose the same type of behavior already exposed by other structures. As such, stabilizing these has little to no drawback. @brson, @alexcrichton
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Jun 3, 2017

@rfcbot fcp merge
@rfcbot

This comment has been minimized.

Sign in to view
Copy link

rfcbot commented Jun 3, 2017 •
edited by brson

Team member @alexcrichton has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once these reviewers reach consensus, this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@Mark-Simulacrum Mark-Simulacrum referenced this issue Jun 16, 2017

Closed

Add set_limit() fn to std::io::Take #27269

@rfcbot

This comment has been minimized.

Sign in to view
Copy link

rfcbot commented Jun 21, 2017

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot added the final-comment-period label Jun 21, 2017

@rfcbot

This comment has been minimized.

Sign in to view
Copy link

rfcbot commented Jul 1, 2017

The final comment period is now complete.
@SergioBenitez

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

SergioBenitez commented Jul 1, 2017

Stabilization PR is incoming.

@SergioBenitez SergioBenitez referenced this issue Jul 1, 2017

Merged

Stabilize 'more_io_inner_methods' feature. #43002

bors added a commit that referenced this issue Jul 1, 2017

@bors
Auto merge of #43002 - SergioBenitez:more-io-inner-stable, r=BurntSushi 
Stabilize 'more_io_inner_methods' feature.

As in the title. Closes #41519.
Loading status checks…
944baf3

bors added a commit that referenced this issue Jul 1, 2017

@bors
Auto merge of #43002 - SergioBenitez:more-io-inner-stable, r=BurntSushi 
Stabilize 'more_io_inner_methods' feature.

As in the title. Closes #41519.
Loading status checks…
a19693a

@bors bors closed this in #43002 Jul 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.