Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for struct_field_attributes #41681

Closed
mbrubeck opened this Issue May 1, 2017 · 13 comments

Comments

Assignees
No one assigned
Labels
B-unstable C-tracking-issue E-easy E-mentor T-lang final-comment-period
Projects
None yet
Milestone
No milestone
@mbrubeck
Copy link
Contributor

mbrubeck commented May 1, 2017 •
edited by nikomatsakis

Status

@mbrubeck mbrubeck added B-unstable T-lang labels May 1, 2017

@mbrubeck mbrubeck referenced this issue May 1, 2017

Merged

syntax: enable attributes and cfg on struct fields #38814

@Ms2ger Ms2ger referenced this issue May 1, 2017

Open

Tracking: Unstable Rust feature gates used by Servo #5286

89 of 97 tasks complete

@blt blt referenced this issue May 13, 2017

Open

Use feature gates #177

0 of 2 tasks complete
@SergioBenitez

This comment has been minimized.

Sign in to view
Copy link
Contributor

SergioBenitez commented May 19, 2017

This has been around for a while (since Jan. 2017, ~4 months) and appears to be quite solid in my testing. Is there a reason to not move this into FCP for stabilization? @brson

@SergioBenitez SergioBenitez referenced this issue May 19, 2017

Open

Compile with stable Rust #19

8 of 13 tasks complete

@brson brson added the I-nominated label May 22, 2017

@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor

brson commented May 22, 2017

cc @rust-lang/lang Ready for stabilization?
@withoutboats

This comment has been minimized.

Sign in to view
Copy link
Contributor

withoutboats commented May 22, 2017

@rfcbot fcp merge

@withoutboats withoutboats removed the I-nominated label May 22, 2017

@rfcbot

This comment has been minimized.

Sign in to view
Copy link

rfcbot commented May 23, 2017 •
edited by pnkfelix

Team member @withoutboats has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once these reviewers reach consensus, this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.
@rfcbot

This comment has been minimized.

Sign in to view
Copy link

rfcbot commented Jun 3, 2017

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot added the final-comment-period label Jun 3, 2017

@rfcbot

This comment has been minimized.

Sign in to view
Copy link

rfcbot commented Jun 13, 2017

The final comment period is now complete.
@nikomatsakis

This comment has been minimized.

Sign in to view
Copy link
Contributor

nikomatsakis commented Jun 13, 2017

Now that we've decided to stabilize this, we need someone to prepare a stabilization PR! There are some general instructions for how to do this on forge. Based on a quick run of rg struct_field_attributes, this should be a pretty straight-forward case! Just have to remove some of the feature-gate tests from libsyntax and a few other places.

The other major thing we need before we can stabilize is documentation PRs.

@nikomatsakis nikomatsakis added E-mentor E-easy labels Jun 13, 2017

@nikomatsakis

This comment has been minimized.

Sign in to view
Copy link
Contributor

nikomatsakis commented Jun 13, 2017

Marking as E-mentor. The instructions are here.
@tirr-c

This comment has been minimized.

Sign in to view
Copy link
Contributor

tirr-c commented Jun 13, 2017

I want to work on removing the feature gate.

@tirr-c tirr-c referenced this issue Jun 14, 2017

Merged

Remove struct_field_attributes feature gate #42656

@nikomatsakis

This comment has been minimized.

Sign in to view
Copy link
Contributor

nikomatsakis commented Jun 14, 2017

@VBChunguk nice job :)

frewsxcv added a commit to frewsxcv/rust that referenced this issue Jun 16, 2017

@frewsxcv
Rollup merge of rust-lang#42656 - VBChunguk:struct-field-attributes, … 
…r=nikomatsakis

Remove struct_field_attributes feature gate

Part of rust-lang#41681. ~This PR only removes the feature gate; this *does not* update any documentations.~ This PR removes the feature gate and the corresponding chapter of the Unstable Book.

I'm not very sure about the changes I made though... Just followed the stabilization guideline.

r? @nikomatsakis
999f3ad
@nikomatsakis

This comment has been minimized.

Sign in to view
Copy link
Contributor

nikomatsakis commented Jul 17, 2017

Did we actually write stable documentation here? Skimming the threads I didn't see any PRs...?

@Mark-Simulacrum Mark-Simulacrum added the C-tracking-issue label Jul 22, 2017

@theduke

This comment has been minimized.

Sign in to view
Copy link
Contributor

theduke commented Aug 31, 2017

This was stabilized with 1.20 as far as I can tell?

hcpl added a commit to hcpl/serde_mtproto that referenced this issue Sep 5, 2017

@hcpl
Add commented tests regarding `extprim` 
For now let them be commented until bumping minimal Rust version to 1.20
because of the struct field attributes feature
(rust-lang/rust#41681).
8ccf1a5

@Manishearth Manishearth added hacktoberfest and removed hacktoberfest labels Sep 28, 2017

@cramertj

This comment has been minimized.

Sign in to view
Copy link
Member

cramertj commented Jan 17, 2018

Stabilized-- closing. LMK if there are any outstanding items here and I'll reopen.

@cramertj cramertj closed this Jan 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.