Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-Zdebug-macros should either be the default or continue to be available on release-channel compiler #41743

Open
hsivonen opened this issue May 4, 2017 · 1 comment · May be fixed by #120845
Labels
A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.) C-feature-request Category: A feature request, i.e: not implemented / a PR. F-collapse_debuginfo `#![feature(collapse_debuginfo)]` T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@hsivonen
Copy link
Member

hsivonen commented May 4, 2017

Firefox is built with release-channel Rust, and -Zdebug-macros is needed to get useful debuggability, crash/panic reporting and profiling attributability for Rust code in Firefox.

According to build-time output, the option is going to go away from the release-channel compiler. It seems that the option isn't on track to becoming the default, either.

If it's not made the default, please continue keeping the option (under some name) available to release-channel Rust.

@Mark-Simulacrum Mark-Simulacrum added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 22, 2017
@Mark-Simulacrum Mark-Simulacrum added the C-feature-request Category: A feature request, i.e: not implemented / a PR. label Jul 27, 2017
@LucasFA
Copy link
Contributor

LucasFA commented May 15, 2023

As I understand it, #100758 closes this. @rustbot label +F-collapse_debuginfo +A-debuginfo.

@rustbot rustbot added A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.) F-collapse_debuginfo `#![feature(collapse_debuginfo)]` labels May 15, 2023
bors added a commit to rust-lang-ci/rust that referenced this issue Feb 12, 2024
debuginfo: Stabilize `-Z debug-macros`, `-Z collapse-macro-debuginfo` and `#[collapse_debuginfo]`

`-Z debug-macros` is "stabilized" by enabling it by default and removing.

`-Z collapse-macro-debuginfo` is stabilized as `-C collapse-macro-debuginfo`.
It now supports all typical boolean values (`parse_opt_bool`) in addition to just yes/no.

Default value of `collapse_debuginfo` was changed from `false` to `external` (i.e. collapsed if external, not collapsed if local) - rust-lang#100758 (comment) describes some debugging scenarios that motivate this default as reasonable.
`#[collapse_debuginfo]` attribute without a value is no longer supported to avoid guessing the default.

Closes rust-lang#100758
Closes rust-lang#41743
Closes rust-lang#39153

TODO: Stabilization report
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.) C-feature-request Category: A feature request, i.e: not implemented / a PR. F-collapse_debuginfo `#![feature(collapse_debuginfo)]` T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
4 participants