Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upRe-disable rls packaging for 1.19 #42357
Comments
brson
added
the
P-high
label
Jun 1, 2017
brson
added this to the 1.19 milestone
Jun 1, 2017
bors
added a commit
that referenced
this issue
Jun 6, 2017
bors
added a commit
that referenced
this issue
Jun 6, 2017
bors
added a commit
that referenced
this issue
Jun 6, 2017
bors
added a commit
that referenced
this issue
Jun 6, 2017
brson
referenced this issue
Jul 8, 2017
Closed
building beta with vendor=true fail due to network dependencies #42719
brson
self-assigned this
Jul 8, 2017
This comment has been minimized.
This comment has been minimized.
|
It looks like this was disabled in this backport. |
This comment has been minimized.
This comment has been minimized.
|
AFAIK there is no movement to get rls stable for 1.20 so we may have to do it again.... |
This comment has been minimized.
This comment has been minimized.
|
I'm going to claim this is done. |
brson
closed this
Jul 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
brson commentedJun 1, 2017
Currently on the 1.19 branch rls is packaged for standalone installers and also (I think) for rustup.
Unfortunately there is still debate about the the story we want to tell here wrt the stability of the RLS, so it's not happening for 1.19
Revert the PR that added it to the installers and make sure it's not packaged for rustup. Since 1.19 branches soon this will likely need to be backported.
cc @alexcrichton @nrc