Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve case with one named, one anonymous lifetime parameter #42517

Closed
nikomatsakis opened this Issue Jun 7, 2017 · 4 comments

Comments

Assignees
No one assigned
Labels
A-diagnostics C-enhancement T-compiler
Projects
None yet
Milestone
No milestone
4 participants
@nikomatsakis @gaurikholkar @estebank @Mark-Simulacrum
@nikomatsakis
Copy link
Contributor

nikomatsakis commented Jun 7, 2017

@gaurikholkar is working on a patch to address the case of conflict between one named and one anonymous lifetime parameter. Driving example (with the rough error message that we want displayed inline):

fn foo<'a>(x: &'a i32, y: &i32) -> &'a i32 {
                       - consider changing the type of `y` to `&'a i32`
    if x > y { x } else { y }
                          ^ this reference must have lifetime 'a
}

@nikomatsakis nikomatsakis added A-diagnostics T-compiler labels Jun 7, 2017

@nikomatsakis nikomatsakis referenced this issue Jun 7, 2017

Open

tracking issue for lifetime inference error work (E0495) #42516

10 of 19 tasks complete

@gaurikholkar gaurikholkar referenced this issue Jun 15, 2017

Merged

Adding diagnostic code 0621 for lifetime errors with one named, one anonymous lifetime parameter #42669

bors added a commit that referenced this issue Jun 28, 2017

@bors
Auto merge of #42669 - gaurikholkar:master, r=nikomatsakis 
Adding diagnostic code 0611 for lifetime errors with one named, one anonymous lifetime parameter

This is a fix for #42517
Note that this only handles the above case for **function declarations** and **traits**.
`impl items` and `closures` will be handled in a later PR.
Example
```
fn foo<'a>(x: &i32, y: &'a i32) -> &'a i32 {
    if x > y { x } else { y }
}
```
now displays the following error message. ui tests have been added for the same.
```
error[E0611]: explicit lifetime required in the type of `x`
11 | fn foo<'a>(x: &i32, y: &'a i32) -> &'a i32 {
   |                     ^ consider changing the type of `x` to `&'a i32`
12 |     if x > y { x } else { y }
   |                  - lifetime `'a` required
```
#42516
r? @nikomatsakis
Loading status checks…
90e1c10

frewsxcv added a commit to frewsxcv/rust that referenced this issue Jun 29, 2017

@frewsxcv
Rollup merge of rust-lang#42669 - gaurikholkar:master, r=nikomatsakis 
Adding diagnostic code 0611 for lifetime errors with one named, one anonymous lifetime parameter

This is a fix for rust-lang#42517
Note that this only handles the above case for **function declarations** and **traits**.
`impl items` and `closures` will be handled in a later PR.
Example
```
fn foo<'a>(x: &i32, y: &'a i32) -> &'a i32 {
    if x > y { x } else { y }
}
```
now displays the following error message. ui tests have been added for the same.
```
error[E0611]: explicit lifetime required in the type of `x`
11 | fn foo<'a>(x: &i32, y: &'a i32) -> &'a i32 {
   |                     ^ consider changing the type of `x` to `&'a i32`
12 |     if x > y { x } else { y }
   |                  - lifetime `'a` required
```
rust-lang#42516
r? @nikomatsakis
a674a08

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Jun 30, 2017

@GuillaumeGomez
Rollup merge of rust-lang#42669 - gaurikholkar:master, r=nikomatsakis 
Adding diagnostic code 0611 for lifetime errors with one named, one anonymous lifetime parameter

This is a fix for rust-lang#42517
Note that this only handles the above case for **function declarations** and **traits**.
`impl items` and `closures` will be handled in a later PR.
Example
```
fn foo<'a>(x: &i32, y: &'a i32) -> &'a i32 {
    if x > y { x } else { y }
}
```
now displays the following error message. ui tests have been added for the same.
```
error[E0611]: explicit lifetime required in the type of `x`
11 | fn foo<'a>(x: &i32, y: &'a i32) -> &'a i32 {
   |                     ^ consider changing the type of `x` to `&'a i32`
12 |     if x > y { x } else { y }
   |                  - lifetime `'a` required
```
rust-lang#42516
r? @nikomatsakis
a47e48a

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Jun 30, 2017

@GuillaumeGomez
Rollup merge of rust-lang#42669 - gaurikholkar:master, r=nikomatsakis 
Adding diagnostic code 0611 for lifetime errors with one named, one anonymous lifetime parameter

This is a fix for rust-lang#42517
Note that this only handles the above case for **function declarations** and **traits**.
`impl items` and `closures` will be handled in a later PR.
Example
```
fn foo<'a>(x: &i32, y: &'a i32) -> &'a i32 {
    if x > y { x } else { y }
}
```
now displays the following error message. ui tests have been added for the same.
```
error[E0611]: explicit lifetime required in the type of `x`
11 | fn foo<'a>(x: &i32, y: &'a i32) -> &'a i32 {
   |                     ^ consider changing the type of `x` to `&'a i32`
12 |     if x > y { x } else { y }
   |                  - lifetime `'a` required
```
rust-lang#42516
r? @nikomatsakis
bf3e8ce

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Jun 30, 2017

@GuillaumeGomez
Rollup merge of rust-lang#42669 - gaurikholkar:master, r=nikomatsakis 
Adding diagnostic code 0611 for lifetime errors with one named, one anonymous lifetime parameter

This is a fix for rust-lang#42517
Note that this only handles the above case for **function declarations** and **traits**.
`impl items` and `closures` will be handled in a later PR.
Example
```
fn foo<'a>(x: &i32, y: &'a i32) -> &'a i32 {
    if x > y { x } else { y }
}
```
now displays the following error message. ui tests have been added for the same.
```
error[E0611]: explicit lifetime required in the type of `x`
11 | fn foo<'a>(x: &i32, y: &'a i32) -> &'a i32 {
   |                     ^ consider changing the type of `x` to `&'a i32`
12 |     if x > y { x } else { y }
   |                  - lifetime `'a` required
```
rust-lang#42516
r? @nikomatsakis
f14a366

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Jun 30, 2017

@GuillaumeGomez
Rollup merge of rust-lang#42669 - gaurikholkar:master, r=nikomatsakis 
Adding diagnostic code 0611 for lifetime errors with one named, one anonymous lifetime parameter

This is a fix for rust-lang#42517
Note that this only handles the above case for **function declarations** and **traits**.
`impl items` and `closures` will be handled in a later PR.
Example
```
fn foo<'a>(x: &i32, y: &'a i32) -> &'a i32 {
    if x > y { x } else { y }
}
```
now displays the following error message. ui tests have been added for the same.
```
error[E0611]: explicit lifetime required in the type of `x`
11 | fn foo<'a>(x: &i32, y: &'a i32) -> &'a i32 {
   |                     ^ consider changing the type of `x` to `&'a i32`
12 |     if x > y { x } else { y }
   |                  - lifetime `'a` required
```
rust-lang#42516
r? @nikomatsakis
fc0fb03
@gaurikholkar

This comment has been minimized.

Sign in to view
Copy link
Contributor

gaurikholkar commented Jul 23, 2017

#43434
@gaurikholkar

This comment has been minimized.

Sign in to view
Copy link
Contributor

gaurikholkar commented Jul 23, 2017

#43433

@Mark-Simulacrum Mark-Simulacrum added the C-enhancement label Jul 26, 2017

@gaurikholkar

This comment has been minimized.

Sign in to view
Copy link
Contributor

gaurikholkar commented Sep 29, 2017

@nikomatsakis, we aren't handling Impls here
@estebank

This comment has been minimized.

Sign in to view
Copy link
Contributor

estebank commented Feb 10, 2018

This case seems to be correctly handled now, and the other linked issues cover other improvements over this.

@estebank estebank closed this Feb 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.