Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type inference regression in rustc 1.18 #42545

Closed
khuey opened this Issue Jun 8, 2017 · 8 comments

Comments

Projects
None yet
5 participants
@khuey
Copy link
Contributor

khuey commented Jun 8, 2017

https://github.com/khuey/rustc-1.18-regression

I'm not sure that this is a minimal testcase, but it's small enough to poke around at. With rustc 1.17 this compiles fine. With 1.18 I get

error[E0284]: type annotations required: cannot resolve `<_ as futures::IntoFuture>::Future == _`
  --> src/lib.rs:15:18
   |
15 |           Box::new(join_all(vec2.iter()
   |  __________________^
16 | |                           .map(move |_| {
17 | |                               iter::<_, _, ()>(vec1.iter()
18 | |                                                .filter_map(move |_| {
...  |
24 | |                                   })
25 | |                           })))
@frewsxcv

This comment has been minimized.

Copy link
Member

frewsxcv commented Jun 8, 2017

For posterity, this is also broken on the latest nightly as well

rustc 1.19.0-nightly (f062832b2 2017-06-07)
binary: rustc
commit-hash: f062832b208e94f2f0f26ed7fb5c48c172069fbe
commit-date: 2017-06-07
host: x86_64-apple-darwin
release: 1.19.0-nightly
LLVM version: 4.0
@nikomatsakis

This comment has been minimized.

Copy link
Contributor

nikomatsakis commented Jun 8, 2017

triage: P-high -- regression

@rust-highfive rust-highfive added P-high and removed I-nominated labels Jun 8, 2017

@nikomatsakis nikomatsakis self-assigned this Jun 8, 2017

@Mark-Simulacrum

This comment has been minimized.

Copy link
Member

Mark-Simulacrum commented Jun 8, 2017

Bisected to 141e8a6, #41716 -- cc @nikomatsakis.

@nikomatsakis

This comment has been minimized.

Copy link
Contributor

nikomatsakis commented Jun 13, 2017

Well, I can certainly reproduce it =)

@nikomatsakis

This comment has been minimized.

Copy link
Contributor

nikomatsakis commented Jun 13, 2017

This may be a dup of #42552

@nikomatsakis

This comment has been minimized.

Copy link
Contributor

nikomatsakis commented Jun 14, 2017

My fix for #42552 also fixes this.

nikomatsakis added a commit to nikomatsakis/rust that referenced this issue Jun 14, 2017

@bors bors closed this in 9fec409 Jun 17, 2017

@khuey

This comment has been minimized.

Copy link
Contributor Author

khuey commented Jun 19, 2017

Is the fix going to make it into 1.19? A 1.18.1?

@Mark-Simulacrum

This comment has been minimized.

Copy link
Member

Mark-Simulacrum commented Jun 19, 2017

The PR (#42659) is beta-nominated, so if it's accepted the fix will be backported and make it into 1.19. However, I doubt we'd release 1.18.1 -- it's possible, though.

brson added a commit to brson/rust that referenced this issue Jun 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.