Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAKEFLAGS and nmake.exe with Cargo conflict #42635

Closed
alexcrichton opened this Issue Jun 13, 2017 · 4 comments

Comments

Assignees

@alexcrichton alexcrichton

Labels
I-needs-decision P-high T-cargo regression-from-stable-to-beta
Projects
None yet
Milestone
No milestone
2 participants
@alexcrichton @brson
@alexcrichton
Copy link
Member

alexcrichton commented Jun 13, 2017

I'm filing this issue for tracking purposes but discussion should continue on rust-lang/cargo#4156 (comment) instead, just using this for labels so we don't forget it.

@alexcrichton alexcrichton added the regression-from-stable-to-beta label Jun 13, 2017

@alexcrichton alexcrichton self-assigned this Jun 13, 2017

@alexcrichton alexcrichton referenced this issue Jun 13, 2017

Closed

MAKEFLAGS / MFLAGS env vars are set for nmake.exe which breaks it #4156

@brson brson added P-high T-cargo I-needs-decision labels Jun 15, 2017

@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor

brson commented Jul 7, 2017 •
edited

AFAICT this will affect most every Rust project building on Windows. I've seen this many times.

@brson brson referenced this issue Jul 7, 2017

Closed

Updated releases notes for 1.19 #42503

@alexcrichton alexcrichton referenced this issue Jul 12, 2017

Merged

Don't set MAKEFLAGS for build scripts #4275

bors added a commit to rust-lang/cargo that referenced this issue Jul 12, 2017

@bors
Auto merge of #4275 - alexcrichton:revert-makeflags, r=alexcrichton 
Don't set MAKEFLAGS for build scripts

Closes #4156
Closes rust-lang/rust#42635
Loading status checks…
5982cf9

alexcrichton added a commit to alexcrichton/cargo that referenced this issue Jul 12, 2017

@alexcrichton
Don't set MAKEFLAGS for build scripts 
Closes rust-lang#4156
Closes rust-lang/rust#42635
a9237f9

@alexcrichton alexcrichton referenced this issue Jul 12, 2017

Merged

[beta] Don't set MAKEFLAGS for build scripts #4276

@bors bors closed this in rust-lang/cargo#4275 Jul 12, 2017

bors added a commit to rust-lang/cargo that referenced this issue Jul 12, 2017

@bors
Auto merge of #4276 - alexcrichton:revert2, r=alexcrichton 
[beta] Don't set MAKEFLAGS for build scripts

Closes #4156
Closes rust-lang/rust#42635
Loading status checks…
aec5bbe

alexcrichton added a commit to alexcrichton/cargo that referenced this issue Jul 12, 2017

@alexcrichton
Don't set MAKEFLAGS for build scripts 
Closes rust-lang#4156
Closes rust-lang/rust#42635
ad5a408

bors added a commit to rust-lang/cargo that referenced this issue Jul 12, 2017

@bors
Auto merge of #4276 - alexcrichton:revert2, r=alexcrichton 
[beta] Don't set MAKEFLAGS for build scripts

Closes #4156
Closes rust-lang/rust#42635
Loading status checks…
468dcf6
@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor

brson commented Jul 13, 2017

Looks like this hasn't been backported into rust yet.

@brson brson reopened this Jul 13, 2017

bors added a commit to rust-lang/cargo that referenced this issue Jul 13, 2017

@bors
Auto merge of #4276 - alexcrichton:revert2, r=alexcrichton 
[beta] Don't set MAKEFLAGS for build scripts

Closes #4156
Closes rust-lang/rust#42635
Loading status checks…
e7a185b

@alexcrichton alexcrichton referenced this issue Jul 13, 2017

Merged

Update the `cargo` submodule #43207

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Jul 13, 2017

@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor

brson commented Jul 14, 2017

Should be fixed on current beta 4. Anybody confirm?

bors added a commit that referenced this issue Jul 15, 2017

@bors
Auto merge of #43207 - alexcrichton:update-cargo, r=nikomatsakis 
Update the `cargo` submodule

Notably pull in an update to the `jobserver` crate to have Cargo set the
`CARGO_MAKEFLAGS` environment variable instead of the `MAKEFLAGS` environment
variable.

cc #42635
Loading status checks…
c4373bd

@shepmaster shepmaster closed this in integer32llc/cargo@f429be4 Jul 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.