Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libsyntax not in 1.20 nightly rust-src component? #42667

Closed
brson opened this Issue Jun 15, 2017 · 7 comments

Comments

Assignees
No one assigned
Labels
A-rustbuild C-feature-request P-low T-infra
Projects
None yet
Milestone
No milestone
7 participants
@brson @ishitatsuyuki @nrc @alexcrichton @sanmai-NL @oli-obk @Mark-Simulacrum
@brson
Copy link
Contributor

brson commented Jun 15, 2017

Per a rustup report, are the nightly rust-src packages not including libsyntax?

@brson brson added the regression-from-stable-to-nightly label Jun 15, 2017

@brson brson referenced this issue Jun 15, 2017

Closed

No libsyntax folder for nightly toolchains #1165

@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

brson commented Jun 15, 2017

cc @gbip
@ishitatsuyuki

This comment has been minimized.

Sign in to view
Copy link
Member

ishitatsuyuki commented Jun 15, 2017

Yes, since they're rustc source, and only libstd source is needed for racer.

Blame #41546

@brson brson added I-needs-decision T-dev-tools P-high labels Jun 15, 2017

@brson brson self-assigned this Jun 15, 2017

@nrc nrc removed the I-needs-decision label Jun 19, 2017

@nrc

This comment has been minimized.

Sign in to view
Copy link
Member

nrc commented Jun 19, 2017

We discussed at the dev-tools meeting today, consensus was that this is by design and the decision to remove was good
@nrc

This comment has been minimized.

Sign in to view
Copy link
Member

nrc commented Jun 19, 2017

Further, we thought that for users who want the compiler sources, we should make available a separate rust-src-internals with the source for the compiler including libsyntax.

@nrc nrc added P-low and removed P-high labels Jun 19, 2017

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Jul 23, 2017

Untagging as a regression due to previous comment

@alexcrichton alexcrichton removed the regression-from-stable-to-nightly label Jul 23, 2017

@Mark-Simulacrum Mark-Simulacrum added C-bug T-infra A-rustbuild and removed T-dev-tools labels Jul 27, 2017

@montrivo montrivo referenced this issue Aug 11, 2017

Open

How to point to local rust standard sources? #1618

@alexcrichton alexcrichton unassigned brson Aug 22, 2017

@dwrensha dwrensha referenced this issue Sep 9, 2017

Closed

Using with a crate that uses proc_macro #125

@Mark-Simulacrum Mark-Simulacrum added C-feature-request and removed C-bug labels Sep 15, 2017

@ishitatsuyuki ishitatsuyuki referenced this issue Feb 11, 2019

Closed

Add some crates sources to "rust-src" distribution. #58268

@sanmai-NL

This comment has been minimized.

Sign in to view
Copy link

sanmai-NL commented Mar 17, 2019

@alexcrichton: can this be closed?
@oli-obk

This comment has been minimized.

Sign in to view
Copy link
Contributor

oli-obk commented Mar 18, 2019

fixed in #58269

@oli-obk oli-obk closed this Mar 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.