Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for std::io::Take::set_limit (take_set_limit) #42781

Closed
Mark-Simulacrum opened this Issue Jun 20, 2017 · 6 comments

Comments

Assignees
No one assigned
Labels
B-unstable C-tracking-issue T-libs final-comment-period
Projects
None yet
Milestone
No milestone
4 participants
@Mark-Simulacrum @sfackler @rfcbot @alexcrichton
@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Jun 20, 2017

Filing for #42697 in the presumption that approval will go through.

@Mark-Simulacrum Mark-Simulacrum added B-unstable T-libs labels Jun 20, 2017

@Mark-Simulacrum Mark-Simulacrum added the C-tracking-issue label Jul 22, 2017

@Mark-Simulacrum

This comment has been minimized.

Sign in to view
Copy link
Member Author

Mark-Simulacrum commented Jan 17, 2018

@rust-lang/libs Nominating for stabilization. Small, somewhat useful piece of functionality. Can be duplicated through into_inner().take(N), so arguably we might not want this function since it adds needless complexity.

@Mark-Simulacrum Mark-Simulacrum added the I-nominated label Jan 17, 2018

@sfackler

This comment has been minimized.

Sign in to view
Copy link
Member

sfackler commented Jan 18, 2018

@rfcbot fcp merge
@rfcbot

This comment has been minimized.

Sign in to view
Copy link

rfcbot commented Jan 18, 2018 •
edited by BurntSushi

Team member @sfackler has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once these reviewers reach consensus, this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added the proposed-final-comment-period label Jan 18, 2018

@alexcrichton alexcrichton removed the I-nominated label Jan 23, 2018

@rfcbot rfcbot added the final-comment-period label Jan 23, 2018

@rfcbot

This comment has been minimized.

Sign in to view
Copy link

rfcbot commented Jan 23, 2018

🔔 This is now entering its final comment period, as per the review above. 🔔
1 similar comment
@rfcbot

This comment has been minimized.

Sign in to view
Copy link

rfcbot commented Jan 23, 2018

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot added final-comment-period and removed proposed-final-comment-period labels Jan 23, 2018

@rfcbot

This comment has been minimized.

Sign in to view
Copy link

rfcbot commented Feb 2, 2018

The final comment period is now complete.

tmccombs added a commit to tmccombs/rust that referenced this issue Apr 5, 2018

@tmccombs
Stabilize take_set_limit 
Fixes rust-lang#42781
210a2a2

@tmccombs tmccombs referenced this issue Apr 5, 2018

Merged

Stabilize take_set_limit #49681

bors added a commit that referenced this issue Apr 11, 2018

@bors
Auto merge of #49681 - tmccombs:take-set-limit-stable, r=sfackler 
Stabilize take_set_limit

Fixes #42781
Loading status checks…
ca26ef3

@bors bors closed this in #49681 Apr 11, 2018

spastorino added a commit to spastorino/rust that referenced this issue Apr 11, 2018

@tmccombs @spastorino
Stabilize take_set_limit 
Fixes rust-lang#42781
Verified
This commit was signed with a verified signature.
@spastorino spastorino Santiago Pastorino
GPG key ID: 88C941CDA1D46432 Learn about signing commits
1ba8ef0

spastorino added a commit to spastorino/rust that referenced this issue Apr 11, 2018

@tmccombs @spastorino
Stabilize take_set_limit 
Fixes rust-lang#42781
Verified
This commit was signed with a verified signature.
@spastorino spastorino Santiago Pastorino
GPG key ID: 88C941CDA1D46432 Learn about signing commits
264c546
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.