Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAttribute paths are not checked for absence of generic arguments #43424
Comments
petrochenkov
added
A-attributes
A-macros
A-syntaxext
labels
Jul 23, 2017
This comment has been minimized.
This comment has been minimized.
|
This is a regression from Rust 1.18, before that paths weren't accepted in attributes. |
petrochenkov
added
the
regression-from-stable-to-stable
label
Jul 23, 2017
jseyfried
self-assigned this
Jul 23, 2017
Mark-Simulacrum
added
P-medium
T-compiler
I-nominated
labels
Jul 27, 2017
This comment has been minimized.
This comment has been minimized.
|
Nominating for prioritization. |
Mark-Simulacrum
added
P-high
and removed
P-medium
labels
Jul 27, 2017
This comment has been minimized.
This comment has been minimized.
nikomatsakis
removed
the
I-nominated
label
Jul 27, 2017
Mark-Simulacrum
added
the
C-bug
label
Jul 28, 2017
This comment has been minimized.
This comment has been minimized.
|
Sorry for delay; still working on this. |
jseyfried
referenced this issue
Aug 17, 2017
Merged
Ensure that generic arguments don't end up in attribute paths. #43948
This comment has been minimized.
This comment has been minimized.
|
Fixed in #43948. |
bors
added a commit
that referenced
this issue
Aug 23, 2017
bors
added a commit
that referenced
this issue
Aug 23, 2017
bors
closed this
in
#43948
Aug 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
petrochenkov commentedJul 23, 2017
E.g. this successfully compiles on stable 1.19 / beta 1.20 /nightly
There are too many kinds of attributes - built in, custom, derives, legacy derives, procedural macros, legacy procedural macros, maybe something else - I'm not sure which of them are affected. Many of these attributes are removed from AST during expansion, so simply adding a check into AST validation pass won't be enough, the checking needs to be done during expansion, like for macro paths (
rust/src/librustc_resolve/macros.rs
Line 391 in 3cf2c04
cc @jseyfried