Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for `String::retain` #43874

Closed
murarth opened this Issue Aug 15, 2017 · 6 comments

Comments

Assignees
No one assigned
Labels
B-unstable C-tracking-issue T-libs final-comment-period
Projects
None yet
Milestone
No milestone
5 participants
@murarth @alercah @Mark-Simulacrum @alexcrichton @rfcbot
@murarth
Copy link
Contributor

murarth commented Aug 15, 2017

Tracking issue for method String::retain, introduced in #43500.

@murarth murarth referenced this issue Aug 15, 2017

Merged

Add method `String::retain` #43500

@Mark-Simulacrum Mark-Simulacrum added C-tracking-issue T-libs B-unstable labels Aug 20, 2017

@alercah

This comment has been minimized.

Sign in to view
Copy link
Contributor

alercah commented Mar 7, 2018

Any reason not to stabilize?
@Mark-Simulacrum

This comment has been minimized.

Sign in to view
Copy link
Member

Mark-Simulacrum commented Mar 7, 2018

@rust-lang/libs -- nominating for stabilization. This API was introduced about half a year ago and seems reasonable to stabilize.

@Mark-Simulacrum Mark-Simulacrum added the I-nominated label Mar 7, 2018

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Mar 7, 2018

@rfcbot fcp merge

Sounds good to me!
@rfcbot

This comment has been minimized.

Sign in to view
Copy link

rfcbot commented Mar 7, 2018 •
edited by dtolnay

Team member @alexcrichton has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added the proposed-final-comment-period label Mar 7, 2018

@alexcrichton alexcrichton removed the I-nominated label Mar 7, 2018

@rfcbot rfcbot added final-comment-period and removed proposed-final-comment-period labels Mar 8, 2018

@rfcbot

This comment has been minimized.

Sign in to view
Copy link

rfcbot commented Mar 8, 2018

🔔 This is now entering its final comment period, as per the review above. 🔔
@rfcbot

This comment has been minimized.

Sign in to view
Copy link

rfcbot commented Mar 18, 2018

The final comment period is now complete.

@murarth murarth referenced this issue Mar 21, 2018

Merged

Stabilize method `String::retain` #49243

kennytm added a commit to kennytm/rust that referenced this issue Mar 28, 2018

@kennytm
Rollup merge of rust-lang#49243 - murarth:stabilize-retain, r=BurntSushi 
Stabilize method `String::retain`

Closes rust-lang#43874
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
43f56ce

@bors bors closed this in #49243 Mar 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.