New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for `String::retain` #43874

Closed
murarth opened this Issue Aug 15, 2017 · 6 comments

Comments

Projects
None yet
5 participants
@murarth
Contributor

murarth commented Aug 15, 2017

Tracking issue for method String::retain, introduced in #43500.

@alercah

This comment has been minimized.

Show comment
Hide comment
@alercah

alercah Mar 7, 2018

Contributor

Any reason not to stabilize?

Contributor

alercah commented Mar 7, 2018

Any reason not to stabilize?

@Mark-Simulacrum

This comment has been minimized.

Show comment
Hide comment
@Mark-Simulacrum

Mark-Simulacrum Mar 7, 2018

Member

@rust-lang/libs -- nominating for stabilization. This API was introduced about half a year ago and seems reasonable to stabilize.

Member

Mark-Simulacrum commented Mar 7, 2018

@rust-lang/libs -- nominating for stabilization. This API was introduced about half a year ago and seems reasonable to stabilize.

@alexcrichton

This comment has been minimized.

Show comment
Hide comment
@alexcrichton

alexcrichton Mar 7, 2018

Member

@rfcbot fcp merge

Sounds good to me!

Member

alexcrichton commented Mar 7, 2018

@rfcbot fcp merge

Sounds good to me!

@rfcbot

This comment has been minimized.

Show comment
Hide comment
@rfcbot

rfcbot Mar 7, 2018

Team member @alexcrichton has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

rfcbot commented Mar 7, 2018

Team member @alexcrichton has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot

This comment has been minimized.

Show comment
Hide comment
@rfcbot

rfcbot Mar 8, 2018

🔔 This is now entering its final comment period, as per the review above. 🔔

rfcbot commented Mar 8, 2018

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot

This comment has been minimized.

Show comment
Hide comment
@rfcbot

rfcbot Mar 18, 2018

The final comment period is now complete.

rfcbot commented Mar 18, 2018

The final comment period is now complete.

kennytm added a commit to kennytm/rust that referenced this issue Mar 28, 2018

Rollup merge of #49243 - murarth:stabilize-retain, r=BurntSushi
Stabilize method `String::retain`

Closes #43874

@bors bors closed this in #49243 Mar 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment