Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta issue for FIXMEs that reference closed issues #44366

Open
oli-obk opened this Issue Sep 6, 2017 · 9 comments

Comments

Assignees
No one assigned
Labels
C-cleanup metabug
Projects
None yet
Milestone
No milestone
6 participants
@oli-obk @Eh2406 @nivkner @varkor @alexcrichton @TimNN
@oli-obk
Copy link
Contributor

oli-obk commented Sep 6, 2017 •
edited by jseyfried

@Eh2406 compiled this awesome list. I think it should be a meta issue. So here it is

  • FIXME(https://github.com/rust-lang/cargo/issues/4089): move these to exclude

  • FIXME: Temporary fix for https://github.com/rust-lang/cargo/issues/3005

  • FIXME(#19839) Remove in favor of #[derive(Clone)]``

  • FIXME #19839: deriving is too aggressive on the bounds (T doesn't need to be Clone).

  • FIXME(#19839) Remove in favor of #[derive(Clone)]``

  • FIXME #13101: this method is used solely by #[deriving] to

  • FIXME (#23442): replace the above impls for &/&mut with the following more general one:

  • FIXME (#23442): replace the above impl for &mut with the following more general one:

  • FIXME #19649: intrinsic docs don't render, so these have no docs :(

  • FIXME #13642 (these benchmarks should be in another place)

  • FIXME: #6220 Implement floating point formatting

  • FIXME(nagisa): due to https://bugs.llvm.org/show_bug.cgi?id=33303 we canonicalize by

  • FIXME(nagisa): due to https://bugs.llvm.org/show_bug.cgi?id=33303 we canonicalize by

  • FIXME(nagisa): due to https://bugs.llvm.org/show_bug.cgi?id=33303 we canonicalize by

  • FIXME(nagisa): due to https://bugs.llvm.org/show_bug.cgi?id=33303 we canonicalize by

  • FIXME: There's a LLVM patch (http://reviews.llvm.org/D9284)

  • FIXME(30524): impl Op<T> for Wrapping<T>, impl OpAssign<T> for Wrapping<T>

  • FIXME(#19839) Remove in favor of #[derive(Clone)]``

  • FIXME(#19839) Remove in favor of #[derive(Clone)]``

  • FIXME(#19839) Remove in favor of #[derive(Clone)]``

  • FIXME (#18248) Add tests for hashing Rc<str> and Rc<[T]>

  • FIXME https://github.com/kripken/emscripten/issues/4563

  • FIXME: #5516 should be graphemes not codepoints

  • FIXME: #5516 should be graphemes not codepoints

  • FIXME: #5516 should be graphemes not codepoints

  • FIXME #7771: having next_u32 like this should be unnecessary

  • FIXME #7771: Should be implemented in terms of next_u64

  • FIXME(#19596) this is a workaround, but there should be a better way

  • FIXME (pending discussion of #1697, #2178...): local should really be

  • FIXME(#27942)

  • Ideas for improving the situation:* (FIXME #3696) The correctness

  • FIXME (#6298): Shouldn't this go with CFG?

  • FIXME (#6298): Would it be better to fold formals from decl

  • FIXME (Issue #18207): This code detects whether we are

  • FIXME(#19596) This is a workaround, but there should be a better way to do this

  • FIXME(#6268) Nested method calls

  • FIXME(#6308) -- Note that [] patterns work more smoothly post-DST.

  • FIXME (#2658): I'm not happy how this module turned out. Should

  • FIXME(#20590) straighten story about projection types

  • FIXME(eddyb) #11161 is the original Expr required?

  • FIXME (@jroesch) ISSUE 26721

  • FIXME(#20297): Self is a type variable (e.g. _: AsRef).

  • FIXME(#20297) -- just examining the self-type is very simplistic

  • FIXME(#27086). We are invariant w/r/t our

  • FIXME(#27086). We do not accumulate from substs, since they

  • FIXME 16351: add a sane default search path?

  • FIXME(#13846) this should be enabled for windows

  • FIXME (22079): if you find yourself tempted to cut and paste

  • FIXME (22079): could refactor via hypothetical

  • FIXME(#19596) This is a workaround, but there should be better way to do this

  • **FIXME #10520: Restrictions against mutating the base pointer.** When

  • FIXME(#6268) Nested method calls

  • let all_loans = &mut *self.all_loans; // FIXME(#5074)

  • FIXME (#9639): This needs to handle non-utf8 paths

  • FIXME #19668: these could be span_lint_note's instead of this manual guard.

  • FIXME (#2166): This is not nearly enough to support correct versioning

  • FIXME(#27840) these probably want their own

  • let unwind = self.unwind; // FIXME(#6393)

  • let (succ, unwind) = (self.succ, self.unwind); // FIXME(#6393)

  • let succ = self.succ; // FIXME(#6393)

  • let succ = self.succ; // FIXME(#6393)

  • let unwind = self.unwind; // FIXME(#6393)

  • let unwind = self.unwind; // FIXME(#6393)

  • }; // FIXME(#6393)

  • FIXME(#37712) could use ItemLikeVisitor if trait items were item-like

  • FIXME(jseyfried): This happens when include!()ing a $crate:: path, c.f, #40469.

  • FIXME #4948: Reuse ribs to avoid allocation.

  • FIXME(#6890): Even though you can't treat a method like a

  • FIXME (#1877: If shifting by negative

  • FIXME(#40304): We ought to be using the id as a key and some queries, I think.

  • FIXME(#34960)

  • FIXME (#26403, #27023): We should be adding padding

  • FIXME(#37712) could use ItemLikeVisitor if trait items were item-like

  • FIXME (#2397): At some point we want to rpath our guesses as to

  • FIXME (#9639): This needs to handle non-utf8 paths

  • FIXME (#9639): This needs to handle non-utf8 paths

  • FIXME(#36856) -- extend the bools into i8 because

  • FIXME(#8559) currently requires the unbound to be built-in.

  • FIXME(#18937) -- this is how the code used to

  • (..) FIXME(#3238) should use visit_pat, not visit_arm/visit_local,

  • FIXME(#6268) nested method calls requires that this rule change

  • FIXME(#6268) to support nested method calls, should be callee_id

  • FIXME(#6268) remove to support nested method calls

  • FIXME(#25759) return types should not be implied bounds

  • FIXME: Once RFC #1868 is implemented, switch to use those structures instead.

  • FIXME(#20299) return type comes from a projection now

  • FIXME (#9639): The closure should deal with &[u8] instead of &str

  • FIXME (#9639): This is too conservative, rejecting non-UTF-8 paths

  • FIXME: #15036

  • #[cfg_attr(target_os = "emscripten", ignore)] // FIXME(#39119)

  • FIXME(#19839) Remove in favor of #[derive(Clone)]``

  • FIXME(#19839) Remove in favor of #[derive(Clone)]``

  • FIXME(#19839) Remove in favor of #[derive(Clone)]``

  • FIXME(#19839) Remove in favor of #[derive(Clone)]``

  • FIXME(#19839) Remove in favor of #[derive(Clone)]``

  • FIXME (#19470): cannot provide PartialOrd<OsStr> for str until we

  • FIXME(#24570): implement this for other Unix platforms

  • FIXME(#24570): implement this for other Unix platforms

  • FIXME(#43348): Make libc adapt #[doc(cfg(...))] so we don't need these fake definitions here?

  • FIXME(#43348): This structure is used for backtrace only, and a fake

  • FIXME(#24570): add more info here (e.g. mode)

  • FIXME (pending discussion of #1697, #2178...): local should really be

  • FIXME: #14406 these are processed in trans, which happens after the

  • FIXME (#28244): enforce that active features have issue numbers

  • FIXME: Bad copies (#2543 -- same for everything else that says "bad")

  • FIXME #15962: should be using quote_item, but that stringifies

  • FIXME #15962: should be using quote_expr, but that stringifies

  • FIXME #8372: This could be a for-loop if it didn't borrow the iterator

  • FIXME #2252: bounds checking float literals is deferred until trans

  • FIXME #8372: This could be a for-loop if it didn't borrow the iterator

  • FIXME: perform NFKC normalization here. (Issue #2253)

  • FIXME(#21880): lift this requirement.

  • FIXME(#21880): lift this requirement.

  • FIXME (#13400): this is only a tiny fraction of the Windows console api

  • FIXME (#9639): This needs to handle non-utf8 paths

  • FIXME #11059 handle NaN, inf and overflow

  • FIXME (#2665): move these into a testcase when the testsuite

  • FIXME #25759 This should also have nocapture``

  • FIXME #25759 This should also have nocapture``

  • FIXME #25759 This should also have nocapture``

  • FIXME #25759 This should also have nocapture``

  • FIXME #25759 This should also have nocapture``

  • FIXME #25759 This should also have nocapture``

  • FIXME #25759 This should also have nocapture``

  • ignore-test FIXME(#20574)

  • FIXME(#19495) no_mangle'ing main ICE's.

  • ignore-windows failing on 64-bit bots FIXME #17638

  • ignore-android: FIXME(#24958)

  • ignore-arm: FIXME(#24958)

  • ignore-aarch64: FIXME(#24958)

  • FIXME(#27979)

  • FIXME #13972

  • FIXME #13972

  • FIXME(#33490) Remove the double braces when old trans is gone.

  • FIXME #27889

  • FIXME(#7622): merge with Arrayonce[T; N]: ClonewhereT: Clone``

  • ignore-test: FIXME(#31702) when this test was added it was thought that the

  • FIXME(30524): uncomment this test when it's implemented

  • FIXME(30524): Uncomment this test

  • ignore-android FIXME #18800

  • FIXME #5244: AtomicUsize is not Copy.

  • FIXME(33025): has - '//code' 'for Foo'

  • FIXME(33025): has - '//code' 'for Foo'

  • FIXME(33025): has - '//code' 'for Foo'

  • FIXME(#33000) -- it'd be better to use a dedicated

  • FIXME(#33000) -- it'd be better to use a dedicated UI harness

  • FIXME(#33435) Avoid spurious failures in codegen-units/partitioning tests.

  • FIXME(#41968): Move this check to tidy?

  • FIXME (#9639): This needs to handle non-utf8 paths

  • FIXME (#9639): This needs to handle non-utf8 paths

  • FIXME (#9639): This needs to handle non-utf8 paths

  • FIXME(#11094): we should fix these tests

  • "src/libstd/lib.rs", // FIXME(#44217)
@Eh2406

This comment has been minimized.

Sign in to view
Copy link
Contributor

Eh2406 commented Sep 6, 2017

The good part, this was made with an automated script. I can keep it up-to-date by rerunning as often as we want.

The bad part, it was made with an automated script. Some of these are false positives, like the first one, where the script was too dumb to realize said it's an issue on a different Repository.

In general fees can be fixed by:

  1. Doing what the fix me said to do and seeing if the pr passes
  2. Updating the fix me to refer to a more current issue number
  3. Removing the fix me has the issue was closed won't fix

In the past couple of days I have been reviewing some of these, and if I'm not sure what to do I'v leaving a comment on the clothes issue with a link to the fix me asking for advice.

@alexcrichton alexcrichton added the C-cleanup label Sep 7, 2017

@TimNN TimNN added the metabug label Sep 17, 2017

@nivkner nivkner referenced this issue Sep 30, 2017

Merged

address some FIXME whose associated issues were marked as closed #44943

bors added a commit that referenced this issue Oct 5, 2017

@bors
Auto merge of #44943 - nivkner:fixme_fixup, r=dtolnay 
address some FIXME whose associated issues were marked as closed

part of #44366
Loading status checks…
417c738
@Eh2406

This comment has been minimized.

Sign in to view
Copy link
Contributor

Eh2406 commented Oct 6, 2017

Thanks @nivkner! Let me know when I should rerun the script.
@nivkner

This comment has been minimized.

Sign in to view
Copy link
Contributor

nivkner commented Oct 7, 2017 •
edited

This kind of metabug seems like something that should be tackled continuously, as new FIXMEs are added over time, so if possible this would be better run routinely. Otherwise there really isn't much of a difference between running the script or marking FIXMEs as complete.

Since I wouldn't ask you to dedicate so much time to this one issue, I'd like to know what is your opinion on turning this script into a github bot like "rust-highfive" or "bors". Then whenever an issue is closed, this "FIXME bot" could update this issue.

@nivkner nivkner referenced this issue Oct 7, 2017

Merged

address more FIXME whose associated issues were marked as closed #45097

zackmdavis added a commit to zackmdavis/rust that referenced this issue Oct 12, 2017

@zackmdavis
remove an obsolete FIXME comment 
This comment made sense when it was introduced in fbef241. It does not
make sense in its current context, where the referred-to guard is no
longer present.

This being an item under the fabulous metabug rust-lang#44366.
d258dff

zackmdavis added a commit to zackmdavis/rust that referenced this issue Oct 16, 2017

@zackmdavis
remove an obsolete FIXME comment 
This comment made sense when it was introduced in fbef241. It does not
make sense in its current context, where the referred-to guard is no
longer present.

This being an item under the fabulous metabug rust-lang#44366.
97b2505

zackmdavis added a commit to zackmdavis/rust that referenced this issue Oct 16, 2017

@zackmdavis
code suggestions for no-mangle lints 
At reviewer's suggestion, we remove the function/static name from the
main lint message. While we're correspondingly adjusting the
expectations of a compile-fail test, we remove an obsolete FIXME
comment, another quantum of progress towards resolving the fabulous
metabug rust-lang#44366.
9ee78b7

bors added a commit that referenced this issue Oct 16, 2017

@bors
Auto merge of #45097 - nivkner:fixme_fixup2, r=estebank 
address more FIXME whose associated issues were marked as closed

part of #44366
Loading status checks…
0a2b5c7

zackmdavis added a commit to zackmdavis/rust that referenced this issue Oct 16, 2017

@zackmdavis
remove an obsolete FIXME comment 
This comment made sense when it was introduced in fbef241. It does not
make sense in its current context, where the referred-to guard is no
longer present.

This being an item under the fabulous metabug rust-lang#44366.
e596c1d

zackmdavis added a commit to zackmdavis/rust that referenced this issue Oct 16, 2017

@zackmdavis
code suggestions for no-mangle lints 
At reviewer's suggestion, we remove the function/static name from the
main lint message. While we're correspondingly adjusting the
expectations of a compile-fail test, we remove an obsolete FIXME
comment, another quantum of progress towards resolving the fabulous
metabug rust-lang#44366.
38e5a96

kennytm added a commit to kennytm/rust that referenced this issue Oct 17, 2017

@kennytm
Rollup merge of rust-lang#45097 - nivkner:fixme_fixup2, r=estebank 
address more FIXME whose associated issues were marked as closed

part of rust-lang#44366
40d61f5
@varkor

This comment has been minimized.

Sign in to view
Copy link
Member

varkor commented Jan 20, 2018

It'd be helpful if the code links pointed to specific commit IDs, so that the line numbers remain correct.
@Eh2406

This comment has been minimized.

Sign in to view
Copy link
Contributor

Eh2406 commented Jan 20, 2018

@varkor thank you for the suggestion. I changed the script to use the sha in the links, and updated the gist to master.

@nivkner It looks like my reply to you never posted, I am very sorry for not replying for so long. I don't have the experience to set up a bot like "rust-highfive" or "bors". So I posted the script I am using so someone with more experience can do that if they like. In the meantime it is no bother for me to run it as needed. I had written up a response like this but apparently it did not post.
@nivkner

This comment has been minimized.

Sign in to view
Copy link
Contributor

nivkner commented Jan 20, 2018 •
edited

Thanks for replying @Eh2406,
Could you please post a link here to the script? I can't find it in your github repositories.
If you don't mind, then could you also post the output of the script, just so we'll know where we are standing after all this time.
@Eh2406

This comment has been minimized.

Sign in to view
Copy link
Contributor

Eh2406 commented Jan 20, 2018

The gist is at:
https://gist.github.com/Eh2406/b92f034f8adc193894482e19c79d80f1
it has the current (as of today) output and the code.
I posted the code on Oct 14, 2017, the same day I failed to reply hear.

@nivkner nivkner referenced this issue Mar 17, 2018

Merged

address some FIXME whose associated issues were marked as closed #49117

kennytm added a commit to kennytm/rust that referenced this issue Mar 21, 2018

@kennytm
Rollup merge of rust-lang#49117 - nivkner:fixme_fixup3, r=estebank 
address some FIXME whose associated issues were marked as closed

part of rust-lang#44366
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
c2208d3

kennytm added a commit to kennytm/rust that referenced this issue Mar 21, 2018

@kennytm
Rollup merge of rust-lang#49117 - nivkner:fixme_fixup3, r=estebank 
address some FIXME whose associated issues were marked as closed

part of rust-lang#44366
Verified
This commit was signed with a verified signature.
@kennytm kennytm
GPG key ID: FEF6C8051D0E013C Learn about signing commits
c90871c

kennytm added a commit to kennytm/rust that referenced this issue Mar 22, 2018

@kennytm
Rollup merge of rust-lang#49117 - nivkner:fixme_fixup3, r=estebank 
address some FIXME whose associated issues were marked as closed

part of rust-lang#44366
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
9231e9f

kennytm added a commit to kennytm/rust that referenced this issue Mar 22, 2018

@kennytm
Rollup merge of rust-lang#49117 - nivkner:fixme_fixup3, r=estebank 
address some FIXME whose associated issues were marked as closed

part of rust-lang#44366
Verified
This commit was signed with a verified signature.
@kennytm kennytm
GPG key ID: FEF6C8051D0E013C Learn about signing commits
8d3f3f0
@Eh2406

This comment has been minimized.

Sign in to view
Copy link
Contributor

Eh2406 commented Jun 7, 2018

Just found one not picked up by my script at:

rust/src/libstd/collections/hash/map.rs

Lines 141 to 143 in a86f556

// Annotate exceedingly likely branches in `table::make_hash`
// and `search_hashed` to reduce instruction cache pressure
// and mispredictions once it becomes possible (blocked on issue #11092).

@ljedrz ljedrz referenced this issue Jul 12, 2018

Merged

Resolve FIXME(#27942) #52315

kennytm added a commit to kennytm/rust that referenced this issue Jul 12, 2018

@kennytm
Rollup merge of rust-lang#52315 - ljedrz:FIXME_#27942, r=petrochenkov 
Resolve FIXME(rust-lang#27942)

[related issue](rust-lang#27942)

cc [rust-lang#44366](rust-lang#44366)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
f8039bf

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this issue Jul 13, 2018

@Mark-Simulacrum
Rollup merge of rust-lang#52315 - ljedrz:FIXME_#27942, r=petrochenkov 
Resolve FIXME(rust-lang#27942)

[related issue](rust-lang#27942)

cc [rust-lang#44366](rust-lang#44366)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
82da5ce

kennytm added a commit to kennytm/rust that referenced this issue Jul 13, 2018

@kennytm
Rollup merge of rust-lang#52315 - ljedrz:FIXME_#27942, r=petrochenkov 
Resolve FIXME(rust-lang#27942)

[related issue](rust-lang#27942)

cc [rust-lang#44366](rust-lang#44366)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
2fa00da

@Munksgaard Munksgaard referenced this issue Oct 11, 2018

Merged

Cleanup rustdoc tests with `@!has` and `@!matches` #54824

212 of 212 tasks complete

@nivkner nivkner referenced this issue Dec 18, 2018

Merged

address some FIXME whose associated issues were marked as closed #56962

Centril added a commit to Centril/rust that referenced this issue Dec 22, 2018

@Centril
Rollup merge of rust-lang#56962 - nivkner:fixme_fixup4, r=pnkfelix 
address some FIXME whose associated issues were marked as closed

part of rust-lang#44366
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
6e267fb

kennytm added a commit to kennytm/rust that referenced this issue Dec 22, 2018

@kennytm
Rollup merge of rust-lang#56962 - nivkner:fixme_fixup4, r=pnkfelix 
address some FIXME whose associated issues were marked as closed

part of rust-lang#44366
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
96cf828

bors added a commit that referenced this issue Dec 25, 2018

@bors
Auto merge of #56962 - nivkner:fixme_fixup4, r=pnkfelix 
address some FIXME whose associated issues were marked as closed

part of #44366
Loading status checks…
400df51

bors added a commit that referenced this issue Dec 25, 2018

@bors
Auto merge of #56962 - nivkner:fixme_fixup4, r=pnkfelix 
address some FIXME whose associated issues were marked as closed

part of #44366
Loading status checks…
27a25df
@Eh2406

This comment has been minimized.

Sign in to view
Copy link
Contributor

Eh2406 commented Jan 21, 2019

Sorry for the long break. I am back to running the script and updating the gist on the semi regular.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.