Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upConsider adding a from_micros for `std::time::Duration` #44400
Comments
This comment has been minimized.
This comment has been minimized.
In general, this is how @rust-lang/libs works; small additions can just be a PR, larger additions need an RFC. So, I'd suggest that you send in a PR implementing this. |
This comment has been minimized.
This comment has been minimized.
|
Adding |
This comment has been minimized.
This comment has been minimized.
|
Yeah, I'd be on board with a PR. |
frewsxcv
added
the
T-libs
label
Sep 13, 2017
TimNN
added
the
C-feature-request
label
Sep 17, 2017
bors
added a commit
that referenced
this issue
Sep 23, 2017
bors
closed this
in
#44436
Sep 24, 2017
nagisa
reopened this
Sep 27, 2017
This comment has been minimized.
This comment has been minimized.
|
This is now a tracking issue for the function added in the previously referenced PR. |
nagisa
added
B-unstable
C-tracking-issue
and removed
C-feature-request
labels
Sep 27, 2017
This comment has been minimized.
This comment has been minimized.
|
Looks good to me to stabilize. @rfcbot fcp merge |
This comment has been minimized.
This comment has been minimized.
rfcbot
commented
Mar 17, 2018
•
|
Team member @SimonSapin has proposed to merge this. The next step is review by the rest of the tagged teams: No concerns currently listed. Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
This comment has been minimized.
This comment has been minimized.
rfcbot
commented
Mar 19, 2018
|
|
rfcbot
removed
the
proposed-final-comment-period
label
Mar 19, 2018
This comment has been minimized.
This comment has been minimized.
rfcbot
commented
Mar 29, 2018
|
The final comment period is now complete. |
MicroJoe commentedSep 7, 2017
During the write of an embedded library I needed to make a pause of 10 microseconds. Looking over the Nightly
std::time::Durationdocumentation page I understood that I had to use the following construction:The sad part is that this is less clear to me than
Duration::from_micros(10). Currently thefrom_millisandfrom_secsfunctions are implemented but notfrom_microswhich could help write cleaner code IMO.The fix seems pretty easy, maybe if you judge this useful I can try to write my first pull request to the Rust project!