Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for HashMap::remove_entry #46344

Closed
sfackler opened this Issue Nov 28, 2017 · 5 comments

Comments

Assignees
No one assigned
Labels
B-unstable C-enhancement T-libs final-comment-period
Projects
None yet
Milestone
No milestone
5 participants
@sfackler @stjepang @SimonSapin @rfcbot @XAMPPRocky
@sfackler
Copy link
Member

sfackler commented Nov 28, 2017

We added this to OccupiedEntry a while ago, but weirdly not to the map itself.

@sfackler sfackler referenced this issue Jan 7, 2018

Merged

Add HashMap::remove_entry #47259

@sfackler sfackler changed the title Add HashMap::remove_entry Tracking issue for HashMap::remove_entry Jan 7, 2018

@sfackler sfackler added B-unstable T-libs labels Jan 7, 2018

@stjepang

This comment has been minimized.

Sign in to view
Copy link
Contributor

stjepang commented Jan 8, 2018

Should we also add BTreeMap::remove_entry?

kennytm pushed a commit to kennytm/rust that referenced this issue Jan 8, 2018

@sfackler
Add HashMap::remove_entry 
Implements rust-lang#46344
1fc6ad5

kennytm added a commit to kennytm/rust that referenced this issue Jan 8, 2018

@kennytm
Rollup merge of rust-lang#47259 - sfackler:map-remove-entry, r=dtolnay 
Add HashMap::remove_entry

Implements rust-lang#46344

r? @dtolnay
03eb277

kennytm added a commit to kennytm/rust that referenced this issue Jan 8, 2018

@kennytm
Rollup merge of rust-lang#47259 - sfackler:map-remove-entry, r=dtolnay 
Add HashMap::remove_entry

Implements rust-lang#46344

r? @dtolnay
Verified
This commit was signed with a verified signature.
@kennytm kennytm
GPG key ID: FEF6C8051D0E013C Learn about signing commits
5ffaf4c

@XAMPPRocky XAMPPRocky added the C-enhancement label Feb 19, 2018

@SimonSapin

This comment has been minimized.

Sign in to view
Copy link
Contributor

SimonSapin commented Mar 17, 2018

Looks good to me to stabilize.

@rfcbot fcp merge
@rfcbot

This comment has been minimized.

Sign in to view
Copy link

rfcbot commented Mar 17, 2018 •
edited by aturon

Team member @SimonSapin has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added the proposed-final-comment-period label Mar 17, 2018

@rfcbot

This comment has been minimized.

Sign in to view
Copy link

rfcbot commented Mar 19, 2018

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot added final-comment-period and removed proposed-final-comment-period labels Mar 19, 2018

@bluss bluss referenced this issue Mar 25, 2018

Open

Full Consistency With HashMap #19

12 of 21 tasks complete
@rfcbot

This comment has been minimized.

Sign in to view
Copy link

rfcbot commented Mar 29, 2018

The final comment period is now complete.

@tinaun tinaun referenced this issue Apr 17, 2018

Merged

stabilize a bunch of minor api additions #50017

bors added a commit that referenced this issue Apr 18, 2018

@bors
Auto merge of #50017 - tinaun:stabilize-all-the-things, r=sfackler 
stabilize a bunch of minor api additions

besides `ptr::NonNull::cast` (which is 4 days away from end of FCP) all of these have been finished with FCP for a few weeks now with minimal issues raised

* Closes #41020
* Closes #42818
* Closes #44030
* Closes #44400
* Closes #46507
* Closes #47653
* Closes #46344

the following functions will be stabilized in 1.27:
* `[T]::rsplit`
* `[T]::rsplit_mut`
* `[T]::swap_with_slice`
* `ptr::swap_nonoverlapping`
* `NonNull::cast`
* `Duration::from_micros`
* `Duration::from_nanos`
* `Duration::subsec_millis`
* `Duration::subsec_micros`
* `HashMap::remove_entry`
Loading status checks…
ac3c228

@bors bors closed this in #50017 Apr 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.