Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust stages for armv6/7-linux-gnueabi{hf} from static.rust-lang.org do not include rust-docs anymore #52133

Open
stefson opened this Issue Jul 7, 2018 · 6 comments

Comments

Projects
None yet
6 participants
@stefson
Copy link

stefson commented Jul 7, 2018

This is valid for >=rust-1.26.0, the rust-docs folder has been included before that version. For instance with rust-1.25.0 it was just fine. I know that there is a thing called rustup, but there are various reasons to prefere an install from the stage archives via install.sh

There were a few problems with cross compile and rust-docs in the past, this may be related somehow.

Please include rust-docs in the future, if there is a reason not to do that please communicate it. And also please check other archs for the same error, I can only speak for armv6/7! Thanks!

@Mark-Simulacrum

This comment has been minimized.

Copy link
Member

Mark-Simulacrum commented Jul 7, 2018

We no longer build documentation for these platforms; I believe the expectation is that users will use linux (x86_64-unknown-linux-gnu) documentation instead.

cc @alexcrichton

mikhail-m1 pushed a commit to mikhail-m1/rust that referenced this issue Jul 27, 2018

mikhail-m1 added a commit to mikhail-m1/rust that referenced this issue Jul 27, 2018

mikhail-m1 added a commit to mikhail-m1/rust that referenced this issue Jul 29, 2018

bors added a commit that referenced this issue Jul 29, 2018

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this issue Jul 30, 2018

Rollup merge of rust-lang#52878 - mikhail-m1:master, r=kennytm
Fix wrong issue number in the test name

I made a mistake in previous PR rust-lang#52620, second issue number was wrong, changing from rust-lang#52133 to rust-lang#52113

r? @kennytm

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this issue Jul 31, 2018

Rollup merge of rust-lang#52878 - mikhail-m1:master, r=kennytm
Fix wrong issue number in the test name

I made a mistake in previous PR rust-lang#52620, second issue number was wrong, changing from rust-lang#52133 to rust-lang#52113

r? @kennytm

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Jul 31, 2018

Rollup merge of rust-lang#52878 - mikhail-m1:master, r=kennytm
Fix wrong issue number in the test name

I made a mistake in previous PR rust-lang#52620, second issue number was wrong, changing from rust-lang#52133 to rust-lang#52113

r? @kennytm

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this issue Aug 1, 2018

Rollup merge of rust-lang#52878 - mikhail-m1:master, r=kennytm
Fix wrong issue number in the test name

I made a mistake in previous PR rust-lang#52620, second issue number was wrong, changing from rust-lang#52133 to rust-lang#52113

r? @kennytm

pietroalbini added a commit to pietroalbini/rust that referenced this issue Aug 1, 2018

Rollup merge of rust-lang#52878 - mikhail-m1:master, r=kennytm
Fix wrong issue number in the test name

I made a mistake in previous PR rust-lang#52620, second issue number was wrong, changing from rust-lang#52133 to rust-lang#52113

r? @kennytm
@djc

This comment has been minimized.

Copy link
Contributor

djc commented Aug 4, 2018

This is an issue in https://bugs.gentoo.org/660512.

So where is the policy described? rust-docs is still being published for seemingly obscure target triples like i386-apple-ios, but not things like armv6 that people actually use, which seems a weird thing to do. Either it's something like one-per-OS or everything-for-tier-2.

@Mark-Simulacrum

This comment has been minimized.

Copy link
Member

Mark-Simulacrum commented Aug 4, 2018

It might be a bug that we're publishing the ios docs -- cc @kennytm

Generally speaking the policy isn't described anywhere currently (though we should probably fix that).

@djc

This comment has been minimized.

Copy link
Contributor

djc commented Aug 21, 2018

So can we please get some clarity on why this got changed/what the policy should look like? I'm happy to help clarify a policy and/or put it in writing, I just don't want to encode stuff now that might turn out to be wrong later because I'm guessing at motivations for this particular change.

@pietroalbini

This comment has been minimized.

Copy link
Member

pietroalbini commented Aug 30, 2018

At the moment only tier 1 platforms gets the rust-docs component packaged with rustup.

The change was made in #49187 because building those docs took a long time on our CI system (which was timing out often at the time) and we guessed few people were using those. AFAIK nobody complained (except when the change broke rustup upgrades, but that's another story).

@djc

This comment has been minimized.

Copy link
Contributor

djc commented Aug 30, 2018

@pietroalbini thanks, that helps a lot! It would be nice if this was documented anywhere.

@steveklabnik steveklabnik removed the T-doc label Dec 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.