Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upProcedural macro crates should require at most one definition per macro name #52225
Comments
alexcrichton
added
the
A-macros-1.2
label
Jul 10, 2018
This comment has been minimized.
This comment has been minimized.
|
I believe this would be fixed by @petrochenkov suggestion here where definition of a macro inserts an entry into the macro namespace, although @petrochenkov correct me if I'm wrong! |
alexcrichton
added
the
A-macros-2.0
label
Jul 10, 2018
petrochenkov
self-assigned this
Jul 10, 2018
This comment has been minimized.
This comment has been minimized.
The issue solvable by inserting a dummy entry into macro namespace is not about inert attributes in derives, but about this case. macro foo() {} // Should be future-proofed and report an error
#[proc_macro]
fn foo(...) -> ... { ... } |
petrochenkov
referenced this issue
Jul 10, 2018
Merged
rustc: Stabilize the `proc_macro` feature #52081
petrochenkov
added
the
P-high
label
Jul 10, 2018
This comment has been minimized.
This comment has been minimized.
|
Stabilization PR for proc macro definitions is in process of merge (#52081), so this should be fixed soon too. |
This comment has been minimized.
This comment has been minimized.
|
Fixed locally, will submit a PR today. |
petrochenkov
referenced this issue
Jul 14, 2018
Merged
resolve: Functions introducing procedural macros reserve a slot in the macro namespace as well #52383
bors
added a commit
that referenced
this issue
Jul 15, 2018
bors
closed this
in
#52383
Jul 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
alexcrichton commentedJul 10, 2018
Discovered by @alercah here, this crate should be rejected: