Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stable backport PR 52232 #52312

Closed
pnkfelix opened this Issue Jul 12, 2018 · 7 comments

Comments

Projects
None yet
6 participants
@pnkfelix
Copy link
Member

pnkfelix commented Jul 12, 2018

This is a dummy issue linking to PR #52232 so that we can have an open issue (which is apparently a requirement if one wants to leverage the rfcbot).

@pnkfelix pnkfelix added the T-compiler label Jul 12, 2018

@pnkfelix

This comment has been minimized.

Copy link
Member Author

pnkfelix commented Jul 12, 2018

@rfcbot fcp merge

I propose that we approve backporting #52232 to stable.

I'm more wary of stable backports than I am of beta backports, so: I am not inverting the rfcbot on this ticket the same way that I did on #52311. If we do not get a sufficient number of check boxes ticked off, then the PR will not be approved for a backport to the stable channel.

@rfcbot

This comment has been minimized.

Copy link

rfcbot commented Jul 12, 2018

Team member @pnkfelix has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@nagisa

This comment has been minimized.

Copy link
Contributor

nagisa commented Jul 12, 2018

@rfcbot reviewed

I find it kind of objectionable that we’ll end up releasing not one but two point releases this cycle…

@pietroalbini

This comment has been minimized.

Copy link
Member

pietroalbini commented Jul 12, 2018

By the way, isn't the core team responsible for approving point releases?

@Mark-Simulacrum

This comment has been minimized.

Copy link
Member

Mark-Simulacrum commented Jul 12, 2018

The core team also discussed this today and we're generally in favor of a 1.27.2 release, scheduled for next Thursday. I will be creating and cross-linking an internals post to this thread after the next nightly release asking for interested users to test and try to find holes in the fix (and, probably, match ergonomics in general) with the goal of finding problems before the point release.

@rfcbot

This comment has been minimized.

Copy link

rfcbot commented Jul 14, 2018

🔔 This is now entering its final comment period, as per the review above. 🔔

@pnkfelix

This comment has been minimized.

Copy link
Member Author

pnkfelix commented Jul 19, 2018

closing, @Mark-Simulacrum says this has been backported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.