Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upstable backport PR 52232 #52312
Comments
pnkfelix
added
the
T-compiler
label
Jul 12, 2018
This comment has been minimized.
This comment has been minimized.
|
@rfcbot fcp merge I propose that we approve backporting #52232 to stable. I'm more wary of stable backports than I am of beta backports, so: I am not inverting the rfcbot on this ticket the same way that I did on #52311. If we do not get a sufficient number of check boxes ticked off, then the PR will not be approved for a backport to the stable channel. |
This comment has been minimized.
This comment has been minimized.
rfcbot
commented
Jul 12, 2018
•
|
Team member @pnkfelix has proposed to merge this. The next step is review by the rest of the tagged teams:
No concerns currently listed. Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
rfcbot
added
proposed-final-comment-period
disposition-merge
labels
Jul 12, 2018
This comment has been minimized.
This comment has been minimized.
|
@rfcbot reviewed I find it kind of objectionable that we’ll end up releasing not one but two point releases this cycle… |
rfcbot
added
proposed-final-comment-period
disposition-merge
labels
Jul 12, 2018
kennytm
added
the
T-core
label
Jul 12, 2018
This comment has been minimized.
This comment has been minimized.
|
By the way, isn't the core team responsible for approving point releases? |
Mark-Simulacrum
added
the
T-release
label
Jul 12, 2018
This comment has been minimized.
This comment has been minimized.
|
The core team also discussed this today and we're generally in favor of a 1.27.2 release, scheduled for next Thursday. I will be creating and cross-linking an internals post to this thread after the next nightly release asking for interested users to test and try to find holes in the fix (and, probably, match ergonomics in general) with the goal of finding problems before the point release. |
pnkfelix
added
P-high
I-nominated
labels
Jul 13, 2018
This comment has been minimized.
This comment has been minimized.
rfcbot
commented
Jul 14, 2018
|
|
rfcbot
added
final-comment-period
and removed
proposed-final-comment-period
labels
Jul 14, 2018
pietroalbini
removed
the
final-comment-period
label
Jul 14, 2018
pietroalbini
referenced this issue
Jul 14, 2018
Merged
use the adjusted type for cat_pattern in tuple patterns #52232
This comment has been minimized.
This comment has been minimized.
|
closing, @Mark-Simulacrum says this has been backported. |
pnkfelix commentedJul 12, 2018
This is a dummy issue linking to PR #52232 so that we can have an open issue (which is apparently a requirement if one wants to leverage the rfcbot).