Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nll] do another crater run and check the results #53171

Closed
nikomatsakis opened this Issue Aug 7, 2018 · 2 comments

Comments

Assignees
No one assigned
Labels
NLL-complete T-compiler
Projects
None yet
Milestone
  Rust 2018 RC
2 participants
@nikomatsakis @Mark-Simulacrum
@nikomatsakis
Copy link
Contributor

nikomatsakis commented Aug 7, 2018

We have almost fixed all the problems we found in the last crater run. We should do another cargo check run at some point. We need to have the -Zborrowck=mir -Ztwo-phase-borrows options supplied by default.

Once the crater run is done, we have to analyze the results.

cc @Mark-Simulacrum for advice on the best way to do that, do we need to make a PR with those options enabled by default?

@nikomatsakis nikomatsakis added I-nominated T-compiler WG-compiler-nll NLL-complete labels Aug 7, 2018

@nikomatsakis nikomatsakis added this to the Rust 2018 RC milestone Aug 7, 2018

@Mark-Simulacrum

This comment has been minimized.

Sign in to view
Copy link
Member

Mark-Simulacrum commented Aug 7, 2018

That's probably the easiest way to get what we want, yes.

@nikomatsakis nikomatsakis removed the I-nominated label Aug 9, 2018

@lqd lqd referenced this issue Aug 16, 2018

Closed

[Do not merge] Enable NLL for a crater run #53426

bors added a commit that referenced this issue Aug 16, 2018

@bors
Auto merge of #53426 - lqd:nll-on-crater, r=<try> 
[Do not merge] Enable NLL by default for a crater run

This enables the MIR borrowck and two-phase-borrows by default, so that we can start the next NLL crater run (#53171).
Loading status checks…
a5d98b0

@lqd lqd referenced this issue Aug 19, 2018

Closed

NLL ICEs from 3rd crater run #53482

2 of 2 tasks complete
@nikomatsakis

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

nikomatsakis commented Aug 21, 2018

I'm going to close this -- @lqd did the crater run, and we've analyzed the results and opened the requisite issues. The following links contain the analyzed results:

@nikomatsakis nikomatsakis closed this Aug 21, 2018

bors added a commit that referenced this issue Sep 5, 2018

@bors
Auto merge of #53426 - lqd:nll-on-crater, r=<try> 
[Do not merge] Enable NLL for a perf run

This enables the MIR borrowck and two-phase-borrows by default, so that we can start the next NLL crater run (#53171).
Loading status checks…
3a8b731

bors added a commit that referenced this issue Sep 14, 2018

@bors
Auto merge of #53426 - lqd:nll-on-crater, r=<try> 
[Do not merge] Enable NLL for a crater run

This enables the MIR borrowck and two-phase-borrows by default, so that we can start the next NLL crater run (#53171).
Loading status checks…
e3ede4a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.