Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICE: "broken MIR in DefId" when assigning mismatched closure to `FnMut` #53448

Open
earthengine opened this Issue Aug 17, 2018 · 4 comments

Comments

Projects
None yet
4 participants
@earthengine
Copy link

earthengine commented Aug 17, 2018

The following code

#![feature(unboxed_closures)]

trait Lt<'a> {
    type T;
}
impl<'a> Lt<'a> for () {
    type T = ();
}

fn main() {
    let v:<() as Lt<'_>>::T = ();
    let f:&mut FnMut<(_,),Output=()> = &mut |_:<() as Lt<'_>>::T|{};
    f(v);
}

causes panic with message

cannot access a scoped thread local variable without calling `set` first

which is irrelevant to the code. Simply modify link_binary function in src\librustc_codegen_llvm\back\link.rs to make it panic before return, will then output some result that says

query stack during panic:
end of query stack
error: internal compiler error: broken MIR in DefId(0/0:7 ~ hrtb_fn_parameters[317d]::main[0]) (_7 = &mut (*_2)): bad assignment (&mut dyn std::ops::FnMut(()) = &mut dyn std::ops::FnMut(<() as Lt<'_>>::T)): NoSolution
  --> src/test\run-pass\hrtb-fn-parameters.rs:23:5
   |
23 |     f(v);
   |   

This is a variation of #53420 aka #29997, but is more serious and we should fix this first to make it at least emit the real error.

The proper fix of this issue, is NOT to make the code above compile; instead, it should give ICE with proper messages instead of something irrelevant so that we ensure we can get useful information from ICEs all the time, and the ICE is to be fixed after #53420 aka #29997.

@earthengine earthengine changed the title Compiler unexpected panic when MIRI verification fail in a certain situation ICE with code irrelevant message - cannot access a scoped thread local variable without calling `set` first Aug 22, 2018

@earthengine

This comment has been minimized.

Copy link
Author

earthengine commented Aug 31, 2018

New error messages after PR #53624 :

error: internal compiler error: broken MIR in DefId(0/0:7 ~ playground[3845]::main[0]) (_7 = &mut (*_2)): bad assignment (&mut dyn std::ops::FnMut(()) = &mut dyn std::ops::FnMut(<() as Lt<'_>>::T)): NoSolution
  --> src/main.rs:13:5
   |
13 |     f(v);
   | 
@matthewjasper

This comment has been minimized.

Copy link
Contributor

matthewjasper commented Sep 2, 2018

Marking with A-NLL since this is an issue with MIR typeck, even though this happens without nll.

@pnkfelix

This comment has been minimized.

Copy link
Member

pnkfelix commented Sep 18, 2018

self-assigning for preliminary investigation

@pnkfelix pnkfelix self-assigned this Sep 18, 2018

@pnkfelix

This comment has been minimized.

Copy link
Member

pnkfelix commented Sep 25, 2018

Discussed with @nikomatsakis. He theorizes it is part of collection of bugs around normalization. Its not really an A-NLL thing. So I'm removing that label.

@pnkfelix pnkfelix removed the A-NLL label Sep 25, 2018

@pnkfelix pnkfelix changed the title ICE with code irrelevant message - cannot access a scoped thread local variable without calling `set` first ICE: "broken MIR in DefId" when assigning mismatched closure to `FnMut` Oct 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.