Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upstd::io::Seek's documentation about seeking beyond the end of a stream is confusing #54562
Comments
sfackler
added
the
T-doc
label
Sep 25, 2018
shepmaster
changed the title
[easy][documentation] a line in std::io::Seek is confusing for some people
std::io::Seek's documentation about seeking beyond the end of a stream is confusing
Sep 25, 2018
This comment has been minimized.
This comment has been minimized.
|
Thanks @shepmaster, I know other projects I've worked with have Easy and Documentation as tags so I wasn't sure if you guys might do the same |
shepmaster
added
the
E-easy
label
Sep 25, 2018
This comment has been minimized.
This comment has been minimized.
|
Yep, they're just actual labels over on the right ;-) (I also tabbed away and forgot to put the easy label on immediately |
This comment has been minimized.
This comment has been minimized.
Don't worry about that! It's very easy for developers to misjudge whether such descriptions will make sense to the target users. Pointing these things out is a great way to contribute to documentation. |
neoeinstein
added a commit
to neoeinstein/rust
that referenced
this issue
Sep 28, 2018
kennytm
added a commit
to kennytm/rust
that referenced
this issue
Sep 29, 2018
kennytm
added a commit
to kennytm/rust
that referenced
this issue
Sep 29, 2018
bors
closed this
in
#54635
Sep 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Xpyder commentedSep 25, 2018
•
edited
https://doc.rust-lang.org/std/io/trait.Seek.html
std::io::Seek
I got confused by this line and wasted some people's time over on internals.rust
so after a little discussion it seems like this might be better wording for those of us who are silly
The hyphen makes it clear “implementation defined” is a known concept (and matches it’s usage elsewhere) and the “it is” makes it a bit more clear that the full sentence is considered and intentional.
While normally I find brevity improves clarity, in this case if you don’t realize “implementation defined” is a single concept, it sounds like a thought that trailed off after an edit