Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign uprustdoc intra links: doc of exported private items don't have the namespace of their doc-visible location #55365
Comments
This comment has been minimized.
This comment has been minimized.
|
IMO this seems like spooky action at a distance, I would expect doc links to always resolve from the place where they are written. Otherwise you have issues if the same documentation is expected to be shown at multiple places with different locally visible paths (presumably this changed to fix this exact case, it is an issue that has been hit many times in the |
memoryruins
added
the
T-rustdoc
label
Oct 29, 2018
QuietMisdreavus
added
the
A-intra-doc-links
label
Nov 6, 2018
This comment has been minimized.
This comment has been minimized.
|
reexports are expected to be broken with intra doc links see #43466 , this is why we haven't been able to stabilize it |
Manishearth
closed this
Nov 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
crumblingstatue commentedOct 25, 2018
•
edited
I don't know if this is an accidental regression or intentional, but this used to resolve.
It has been used extensively by rust-sfml. See the example of Event referring to Window. From the viewpoint of the user,
EventandWindowexist in the same module. It's only a private implementation detail that they are implemented in their own submodules, and re-exported into a common module.Ref #43466