Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for std::ptr::hash #56286

Open
dwijnand opened this Issue Nov 27, 2018 · 5 comments

Comments

Projects
None yet
6 participants
@dwijnand
Copy link
Member

dwijnand commented Nov 27, 2018

Implemented in #56250 as #[unstable(feature = "ptr_hash")].

@dtolnay

This comment has been minimized.

Copy link
Member

dtolnay commented Dec 13, 2018

Updated from:

fn hash<T, S: Hasher>(hashee: *const T, into: &mut S)

to:

fn hash<T: ?Sized, S: Hasher>(hashee: *const T, into: &mut S)
           ^^^^^^

in #56751. Thanks @mbrubeck.

@SimonSapin

This comment has been minimized.

Copy link
Contributor

SimonSapin commented Feb 1, 2019

Seems straightforward enough to me.

@rfcbot fcp merge

@rfcbot

This comment has been minimized.

Copy link

rfcbot commented Feb 1, 2019

Team member @SimonSapin has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot

This comment has been minimized.

Copy link

rfcbot commented Feb 8, 2019

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot

This comment has been minimized.

Copy link

rfcbot commented Feb 18, 2019

The final comment period, with a disposition to merge, as per the review above, is now complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.